Code review request: 7025699: Policy Tool is not accessible by keyboard

2013-04-24 Thread Weijun Wang
Hi All Please take a look at http://cr.openjdk.java.net/~weijun/7025699/webrev.00/ The bug is about policytool not accessible through a keyboard. Mainly two problems: First menu items have no key accelerators. Second, pressing ENTER on any button is not working. Basically I made these ch

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2013-04-24 Thread Valerie (Yu-Ching) Peng
Won't this change break systems which don't have libpcsclite.so.1? Changes like this need to be thought through. What happens when libpcsclite.so.2 comes out? As for API changes, shouldn't there be some compatibility requirement on APIs as libpcsclite.so evolves? Valerie On 04/24/13 04:05, Fl

hg: jdk8/tl/jdk: 8012638: test/java/time/test/java/util/TestFormatter fails in UTC TZ

2013-04-24 Thread xueming . shen
Changeset: 8c06a38aa2c5 Author:sherman Date: 2013-04-24 21:27 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c06a38aa2c5 8012638: test/java/time/test/java/util/TestFormatter fails in UTC TZ Summary: updated the offending test case Reviewed-by: alanb ! test/java/time/test/ja

hg: jdk8/tl/jdk: 8009985: [parfait] Uninitialised variable at jdk/src/solaris/native/com/sun/management/UnixOperatingSystem_md.c

2013-04-24 Thread staffan . larsen
Changeset: 754c9bb4f085 Author:sla Date: 2013-04-24 14:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/754c9bb4f085 8009985: [parfait] Uninitialised variable at jdk/src/solaris/native/com/sun/management/UnixOperatingSystem_md.c Reviewed-by: sla, rbackman, alanb, dholmes, r

hg: jdk8/tl/jdk: 8005555: TEST_BUG: java/io/Serializable/accessConstants/AccessConstants.java should be removed

2013-04-24 Thread alan . bateman
Changeset: bbcebf893b83 Author:alanb Date: 2013-04-24 19:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bbcebf893b83 800: TEST_BUG: java/io/Serializable/accessConstants/AccessConstants.java should be removed Reviewed-by: chegar - test/java/io/Serializable/accessConst

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2013-04-24 Thread Florian Weimer
On 03/01/2013 11:30 AM, Severin Gehwolf wrote: Hi, The bug for this review request is at: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=9000142 In PlatformPCSC.java unversioned native libraries are loaded by default if no system property is specified. This could lead to a JVM crash if the

Code review request: 8012615: Realm.getRealmsList returns realms list in wrong

2013-04-24 Thread Weijun Wang
Hi All Please review the fix at http://cr.openjdk.java.net/~weijun/8012615/webrev.00/ Basically, the algorithm to calculate cross-realm authentication path is totally rewritten to be *correct*. This includes both the hierarchy codes and capaths codes. You are welcomed to read this blog po

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2013-04-24 Thread Severin Gehwolf
On Fri, 2013-03-01 at 11:30 +0100, Severin Gehwolf wrote: > Hi, > > The bug for this review request is at: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=9000142 > > In PlatformPCSC.java unversioned native libraries are loaded by default > if no system property is specified. This could lead