hg: jdk8/tl/jdk: 3 new changesets

2013-04-25 Thread mike . duigou
Changeset: a8da4e516bc3 Author:akhil Date: 2013-04-23 11:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8da4e516bc3 8005051: optimized defaults for Iterator.forEachRemaining Reviewed-by: alanb, mduigou, psandoz, ulfzibis Contributed-by: Akhil Arora ! src/share/classes/j

hg: jdk8/tl/langtools: 8013256: javac test failing after Lambda changes to java.util.List

2013-04-25 Thread jonathan . gibbons
Changeset: 4b0038f66d66 Author:jjg Date: 2013-04-25 17:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4b0038f66d66 8013256: javac test failing after Lambda changes to java.util.List Reviewed-by: mduigou ! test/tools/javac/api/TestJavacTaskScanner.java

hg: jdk8/tl/jdk: 8012530: test/sun/security/provider/SecureRandom/StrongSeedReader.java failing

2013-04-25 Thread bradford . wetmore
Changeset: b600d637ef77 Author:wetmore Date: 2013-04-25 17:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b600d637ef77 8012530: test/sun/security/provider/SecureRandom/StrongSeedReader.java failing Reviewed-by: wetmore Contributed-by: [email protected] ! test/sun/se

Reviewed: JDK-8012530 : test/sun/security/provider/SecureRandom/StrongSeedReader.java failing

2013-04-25 Thread Brad Wetmore
This is a simple fix that Alan Bateman noticed during our nightly testing. On some Linux, the java.io.tmp directory does not include the trailing "/", but does on others OS. Apparently, on my JPRT run, whatever Linux machine this ran on did include the slash, or else I was asleep at the switc

hg: jdk8/tl/jdk: 8000529: Regression: SimpleDateFormat incorrectly parses dates formatted with Z and z pattern letters

2013-04-25 Thread sean . coffey
Changeset: 5871d7b1673c Author:coffeys Date: 2013-04-25 21:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5871d7b1673c 8000529: Regression: SimpleDateFormat incorrectly parses dates formatted with Z and z pattern letters Reviewed-by: okutsu ! src/share/classes/java/text/

Re: [8] Code Review Request for 8013228: Create new system properties to control allowable OCSP clock skew and CRL connection timeout

2013-04-25 Thread Vincent Ryan
That fix looks good to me. Thanks. On 25/04/2013 19:47, Sean Mullan wrote: This fix adds support for 2 new system properties to allow users to adjust the maximum allowable clock skew when validating OCSP responses, and a maximum connection timeout for downloading CRLs. webrev: http://cr.openjd

hg: jdk8/tl/jdk: 8012937: Correct errors in javadoc comments.

2013-04-25 Thread eric . mccorkle
Changeset: ca0957f0d408 Author:emc Date: 2013-04-25 14:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca0957f0d408 8012937: Correct errors in javadoc comments. Summary: Correct some errors in the javadoc comments for parameter reflection. Reviewed-by: darcy ! src/share/cl

[8] Code Review Request for 8013228: Create new system properties to control allowable OCSP clock skew and CRL connection timeout

2013-04-25 Thread Sean Mullan
This fix adds support for 2 new system properties to allow users to adjust the maximum allowable clock skew when validating OCSP responses, and a maximum connection timeout for downloading CRLs. webrev: http://cr.openjdk.java.net/~mullan/webrevs/8013228/webrev.00/ Thanks, Sean

Re: Code Review Requests for 7196382 and 8010134

2013-04-25 Thread Valerie (Yu-Ching) Peng
Xuelei, Thanks for the review and comments. Supposedly, we don't have to have default parameters for all valid key sizes. The pre-generated default parameters are for the most-commonly used keysizes. As for the rest of supported key sizes, the needed parameters will be generated at runtime up

hg: jdk8/tl/jdk: 8012044: Give more information about self-suppression from Throwable.addSuppressed

2013-04-25 Thread joe . darcy
Changeset: 4da1d43f5843 Author:darcy Date: 2013-04-25 09:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4da1d43f5843 8012044: Give more information about self-suppression from Throwable.addSuppressed Reviewed-by: alanb, dholmes ! src/share/classes/java/lang/Throwable.jav

Re: [8] Code Review Request for 8011313: OCSP timeout set to wrong value if com.sun.security.ocsp.timeout not defined

2013-04-25 Thread Vincent Ryan
Your fix looks fine. Thanks. On 25 Apr 2013, at 16:00, Sean Mullan wrote: > Hi Vinnie, > > Could I get a code review for the fix for 8011313: > > http://cr.openjdk.java.net/~mullan/webrevs/8011313/webrev.00/ > > The bug has been tagged with noreg-sqe since there is an existing SQE test > for

[8] Code Review Request for 8011313: OCSP timeout set to wrong value if com.sun.security.ocsp.timeout not defined

2013-04-25 Thread Sean Mullan
Hi Vinnie, Could I get a code review for the fix for 8011313: http://cr.openjdk.java.net/~mullan/webrevs/8011313/webrev.00/ The bug has been tagged with noreg-sqe since there is an existing SQE test for this. Thanks, Sean

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2013-04-25 Thread Florian Weimer
On 04/25/2013 12:11 AM, Valerie (Yu-Ching) Peng wrote: Won't this change break systems which don't have libpcsclite.so.1? By linking against libpcsclite.so.1 at the ELF level? Yes. But the dependency is already there, it is just not expressed explicitly, so it will not be discovered by tools

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2013-04-25 Thread Severin Gehwolf
Hi Valerie, Thanks for the review! On Wed, 2013-04-24 at 15:11 -0700, Valerie (Yu-Ching) Peng wrote: > Won't this change break systems which don't have libpcsclite.so.1? Yes. However, currently it breaks systems which don't have libpcsclite.so. [1] would be an example. There is a system property

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2013-04-25 Thread Severin Gehwolf
On Wed, 2013-04-24 at 13:05 +0200, Florian Weimer wrote: > On 03/01/2013 11:30 AM, Severin Gehwolf wrote: > > Hi, > > > > The bug for this review request is at: > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=9000142 > > > > In PlatformPCSC.java unversioned native libraries are loaded by def