hg: jdk8/tl/jdk: 7169142: CookieHandler does not work with localhost

2013-06-13 Thread kurchi . subhra . hazra
Changeset: 42f9ad39bf42 Author:khazra Date: 2013-06-13 17:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/42f9ad39bf42 7169142: CookieHandler does not work with localhost Summary: Add .local to derived effective hostnames without dot Reviewed-by: chegar ! src/share/classes

Re: Code review request, 7188658 Add possibility to disable client initiated renegotiation

2013-06-13 Thread Weijun Wang
I see. The code change looks fine then. Thanks Max On 6/14/13 9:45 AM, Xuelei Fan wrote: On 6/14/2013 9:39 AM, Weijun Wang wrote: What is this for? state != HandshakeMessage.ht_hello_request It is to allow server initialized renegotiation. If server want a renegotiation, it may send a

Re: Code review request, 7188658 Add possibility to disable client initiated renegotiation

2013-06-13 Thread Xuelei Fan
On 6/14/2013 9:39 AM, Weijun Wang wrote: > What is this for? > >state != HandshakeMessage.ht_hello_request > It is to allow server initialized renegotiation. If server want a renegotiation, it may send a HelloRequest message, and than the client may response with a ClientHello message. We s

Re: Code review request, 7188658 Add possibility to disable client initiated renegotiation

2013-06-13 Thread Weijun Wang
What is this for? state != HandshakeMessage.ht_hello_request -Max On 6/13/13 5:05 PM, Xuelei Fan wrote: Ping again. The new system property name is "jdk.tls.rejectClientInitializedRenego". webrev: http://cr.openjdk.java.net/~xuelei/7188658/webrev.01/ Thanks, Xuelei On 5/29/2013 11:43 PM,

Code review request: 6755701 SecretKeySpec & DES

2013-06-13 Thread Anthony Scarpino
Hi all, I'm requesting a code review for the below bug 6755701 SunJCE DES/DESede SecretKeyFactory.generateSecret throws InvalidKeySpecExc if passed SecretKeySpec http://cr.openjdk.java.net/~ascarpino/6755701/webrev.00/ Thanks Tony

hg: jdk8/tl/jdk: 8015421: NegativeArraySizeException occurs in ChunkedOutputStream() with Integer.MAX_VALUE

2013-06-13 Thread kurchi . subhra . hazra
Changeset: ff83bd43e36a Author:khazra Date: 2013-06-13 11:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff83bd43e36a 8015421: NegativeArraySizeException occurs in ChunkedOutputStream() with Integer.MAX_VALUE Summary: Ensure integer overflow does not occur Reviewed-by: ch

hg: jdk8/tl/jdk: 7181748: java/lang/ThreadGroup/Suspend.java test fails intermittently

2013-06-13 Thread chris . hegarty
Changeset: f3609297a868 Author:igerasim Date: 2013-06-13 15:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f3609297a868 7181748: java/lang/ThreadGroup/Suspend.java test fails intermittently Reviewed-by: chegar, dholmes ! test/java/lang/ThreadGroup/Suspend.java

Re: RFR JDK-8014307

2013-06-13 Thread Chris Hegarty
Looks ok to me John. -Chris. On 06/13/2013 01:35 PM, John Zavgren wrote: All: Please give this change one more consideration. Thanks! John Original Message Subject:Re: Re: RFR JDK-8014307 Date: Fri, 24 May 2013 15:56:11 -0400 From: John Zavgren To: Security

RFR JDK-8014307

2013-06-13 Thread John Zavgren
All: Please give this change one more consideration. Thanks! John Original Message Subject:Re: Re: RFR JDK-8014307 Date: Fri, 24 May 2013 15:56:11 -0400 From: John Zavgren To: Security-Dev Thanks, Valerie. I removed the unnecessary resetGSSBuffer(...) call

Re: Code review request for 8012637: Adjust CipherInputStream class to work in AEAD/GCM mode

2013-06-13 Thread Xuelei Fan
Looks fine to me. A very very minor comment is about the code conversions. Personally, I prefer to use braces around all statements (if-else, while, etc). See also: http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-142311.html#15395 - if (!done) cipher.doFinal(); +

hg: jdk8/tl/jdk: 8016251: Balanced spliterator for SpinedBuffer

2013-06-13 Thread paul . sandoz
Changeset: a50394c44464 Author:psandoz Date: 2013-06-13 11:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a50394c44464 8016251: Balanced spliterator for SpinedBuffer Reviewed-by: mduigou Contributed-by: Brian Goetz , Peter Levart , Paul Sandoz ! src/share/classes/java/u

Re: Code review request, 7188658 Add possibility to disable client initiated renegotiation

2013-06-13 Thread Xuelei Fan
Ping again. The new system property name is "jdk.tls.rejectClientInitializedRenego". webrev: http://cr.openjdk.java.net/~xuelei/7188658/webrev.01/ Thanks, Xuelei On 5/29/2013 11:43 PM, Xuelei Fan wrote: > A new system property, "jsse.rejectClientInitializedRenego", is > introduced to reject clie