Re: Code Review Request for 7196805: DH Key interoperability testing between SunJCE and JsafeJCE not successful

> I will also apply the same change to P11DHPrivateKey/P11DHPublicKey then. > Equality check using ASN.1 encoding is fine for non-DH algorithms but not for > DH. I cannot read the source codes now, but is it possible to implement the equals method right in the base interface using the JDK 8 de

hg: jdk8/tl/jdk: 8015402: Lambda metafactory should not attempt to determine bridge methods

Changeset: 989049977d04 Author:rfield Date: 2013-06-17 20:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/989049977d04 8015402: Lambda metafactory should not attempt to determine bridge methods Summary: paired with 8013789: Compiler should emit bridges in interfaces Reviewe

hg: jdk8/tl/langtools: 8013789: Compiler should emit bridges in interfaces

Changeset: 455be95bd1b5 Author:rfield Date: 2013-06-17 20:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/455be95bd1b5 8013789: Compiler should emit bridges in interfaces Summary: paired with 8015402: Lambda metafactory should not attempt to determine bridge methods

hg: jdk8/tl/jdk: 8014620: Signature.getAlgorithm return null in special case

Changeset: 116050227ee9 Author:youdwei Date: 2013-06-17 17:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/116050227ee9 8014620: Signature.getAlgorithm return null in special case Reviewed-by: wetmore ! src/share/classes/java/security/Signature.java + test/java/security/Si

Re: RFR JDK8007636

Ditto. brad On 6/17/2013 5:16 PM, Xuelei Fan wrote: Looks fine to me. Thanks, Xuelei On 6/17/2013 10:29 PM, John Zavgren wrote: Greetings: I'm posting a fix for a memory leak. As you can see, the original code deallocated a structure, thereby rendering it's memory invalid, then it dealloc

Re: Signature.getAlogrithm return null in special case

On 6/17/2013 5:38 PM, Brad Wetmore wrote: Pushed. Thanks for the contribution. P.S. http://hg.openjdk.java.net/jdk8/tl/jdk/rev/116050227ee9 Brad Brad On 5/27/2013 12:11 PM, Brad Wetmore wrote: Hi Deven, I just got back from a short break, hope to return back to this shortly. I twe

Re: Signature.getAlogrithm return null in special case

Pushed. Thanks for the contribution. Brad On 5/27/2013 12:11 PM, Brad Wetmore wrote: Hi Deven, I just got back from a short break, hope to return back to this shortly. I tweaked your test a bit before I left, but the builds were failing (unrelated issue) so I couldn't check in. Still need

Re: RFR JDK8007636

Looks fine to me. Thanks, Xuelei On 6/17/2013 10:29 PM, John Zavgren wrote: > Greetings: > > I'm posting a fix for a memory leak. As you can see, the original code > deallocated a structure, thereby rendering it's memory invalid, then it > deallocated the memory that was allocated to one of its

hg: jdk8/tl/jdk: 7177472: JSR292: MethodType interning penalizes scalability

Changeset: 2b63fda275a3 Author:twisti Date: 2013-06-17 16:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b63fda275a3 7177472: JSR292: MethodType interning penalizes scalability Reviewed-by: twisti Contributed-by: Aleksey Shipilev ! src/share/classes/java/lang/invoke/Met

hg: jdk8/tl/langtools: 8016779: Fix doclint warnings in javax.lang.model

Changeset: b7a10bc02e7a Author:darcy Date: 2013-06-17 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b7a10bc02e7a 8016779: Fix doclint warnings in javax.lang.model Reviewed-by: jjg ! src/share/classes/javax/lang/model/util/ElementScanner6.java ! src/share/classes

Re: Code Review Request for 7196805: DH Key interoperability testing between SunJCE and JsafeJCE not successful

Max, Please find comments in line... On 06/12/13 18:27, Weijun Wang wrote: Hi Valerie Not sure if we really need to fix the equals() method here. Is there a spec saying the equality is based on internal fields instead of encoded bytes? There is no spec saying the equality check should be bas

hg: jdk8/tl/jaxp: 8016133: Regression: diff. behavior with user-defined SAXParser

Changeset: 09d55894844d Author:joehw Date: 2013-06-17 12:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/09d55894844d 8016133: Regression: diff. behavior with user-defined SAXParser Reviewed-by: chegar, dfuchs ! src/org/xml/sax/helpers/XMLReaderFactory.java

hg: jdk8/tl/jdk: 7040556: SimpleDateFormat.format Portuguese Month should not be capitalized

Changeset: 3c7bab68cd2f Author:yhuang Date: 2013-06-12 23:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c7bab68cd2f 7040556: SimpleDateFormat.format Portuguese Month should not be capitalized Reviewed-by: okutsu ! src/share/classes/sun/text/resources/pt/FormatData_pt.ja

hg: jdk8/tl: 8016572: Pass CONCURRENCY=$(JOBS) to test/Makefile

Changeset: f8770fe60d53 Author:mduigou Date: 2013-06-17 09:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/f8770fe60d53 8016572: Pass CONCURRENCY=$(JOBS) to test/Makefile Reviewed-by: alanb, erikj ! common/makefiles/Main.gmk

RFR JDK8007636

Greetings: I'm posting a fix for a memory leak. As you can see, the original code deallocated a structure, thereby rendering it's memory invalid, then it deallocated the memory that was allocated to one of its data members. I merely reversed the order of the free() operations. http://cr.ope

hg: jdk8/tl/jdk: 8016236: Class.getGenericInterfaces performance improvement

Changeset: b0cfde1e70e9 Author:shade Date: 2013-06-17 16:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b0cfde1e70e9 8016236: Class.getGenericInterfaces performance improvement Summary: cache more reflective data and lookup results. Reviewed-by: alanb, plevart, psandoz, dl

hg: jdk8/tl/jdk: 8016747: Replace deprecated PlatformLogger isLoggable(int) with isLoggable(Level)

Changeset: adf70cb48ce0 Author:chegar Date: 2013-06-17 14:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/adf70cb48ce0 8016747: Replace deprecated PlatformLogger isLoggable(int) with isLoggable(Level) Reviewed-by: darcy ! src/macosx/classes/sun/lwawt/LWComponentPeer.java

hg: jdk8/tl/jdk: 36 new changesets

Changeset: 583e6dec1ed7 Author:erikj Date: 2013-05-29 14:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/583e6dec1ed7 8013489: New build system does not run codesign on SA-related launchers on OS X Reviewed-by: sla, tbell ! makefiles/CompileLaunchers.gmk Changeset: d8c97d