Re: Code review request, 7188658 Add possibility to disable client initiated renegotiation

On 6/19/2013 12:09 PM, Matthew Hall wrote: > I think it would be better if the property did use JSSE prefix, because other > crypto providers will likely also want to adjust their own renegotiation > behavior based on the value of the property. Thanks for contributing this > useful security impr

Re: Code review request, 7188658 Add possibility to disable client initiated renegotiation

I think it would be better if the property did use JSSE prefix, because other crypto providers will likely also want to adjust their own renegotiation behavior based on the value of the property. Thanks for contributing this useful security improvement to JSSE. Matthew. -- Sent from my mobile

Re: Code review request, 7188658 Add possibility to disable client initiated renegotiation

On 6/19/2013 10:50 AM, Brad Wetmore wrote: > Sorry for the delay. > > Two comments about the property name. > > I don't see the jdk.tls *System* Property prefix used anywhere else, > except as a *Security* properties: > > jdk.tls.rejectClientInitializedRenego > > Otherwise, I think we shoul

Re: Code review request, 7188658 Add possibility to disable client initiated renegotiation

Sorry for the delay. Two comments about the property name. I don't see the jdk.tls *System* Property prefix used anywhere else, except as a *Security* properties: jdk.tls.rejectClientInitializedRenego Otherwise, I think we should stick to one of the current namespace. jsse.

RFR JDK-8003245

Greetings: Please consider the following changes that eliminate the use of uninitialized memory. http://cr.openjdk.java.net/~jzavgren/8003245/webrev.01/ Thanks! John

hg: jdk8/tl/jdk: 8000456: Add programmatic deadlock detection in SSLEngineDeadlock

Changeset: 2d9da733014f Author:xuelei Date: 2013-06-18 18:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2d9da733014f 8000456: Add programmatic deadlock detection in SSLEngineDeadlock Reviewed-by: wetmore ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl

Re: Code review request, 8000456: Add programmatic deadlock detection in SSLEngineDeadlock

On 6/19/2013 8:21 AM, Brad Wetmore wrote: > I enjoy your codereviews because I generally learn about new libraries. :) > > On 6/18/2013 2:47 AM, Xuelei Fan wrote: >> Hi, >> >> Please review this test update: >> >> http://cr.openjdk.java.net/~xuelei/8000456/webrev.00/ >> >> The test case SSLEngine

Re: Code review request, 8000456: Add programmatic deadlock detection in SSLEngineDeadlock

I enjoy your codereviews because I generally learn about new libraries. :) On 6/18/2013 2:47 AM, Xuelei Fan wrote: Hi, Please review this test update: http://cr.openjdk.java.net/~xuelei/8000456/webrev.00/ The test case SSLEngineDeadlock.java is used to detect the deadlock in SSLEngine. Howe

hg: jdk8/tl: 8016780: README-builds.html misses crucial requirement on bootstrap JDK

Changeset: b9587f41fd55 Author:smarks Date: 2013-06-18 17:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b9587f41fd55 8016780: README-builds.html misses crucial requirement on bootstrap JDK Reviewed-by: dholmes, chegar ! README-builds.html

hg: jdk8/tl/jdk: 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap, ConcurrentMap

Changeset: 1f7cbe4829fe Author:mduigou Date: 2013-06-18 16:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f7cbe4829fe 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap, ConcurrentMap Reviewed-by: forax, mduigou, psando

Re: RFR JDK8007636

I recall reviewing this use-after-free problem a while ago? Isn't this the same one that's caught by parfait earlier? The synopsis for 8007636 is "[parfait] False positive buffer overrun error in jdk/src/solaris/transport/socket/socket_md.c". Your changes do not seem to match the bug description

hg: jdk8/tl/jdk: 8016046: (process) Strict validation of input should be security manager case only [win].

Changeset: 956b00d7d4ea Author:uta Date: 2013-06-18 17:19 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/956b00d7d4ea 8016046: (process) Strict validation of input should be security manager case only [win]. Reviewed-by: alanb, ahgross ! src/windows/classes/java/lang/Proces

hg: jdk8/tl/jdk: 2 new changesets

Changeset: ba544aab1fcd Author:bpb Date: 2013-06-18 11:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ba544aab1fcd 8015395: NumberFormatException during startup if JDK-internal property java.lang.Integer.IntegerCache.high set to bad value Summary: Fall back to default if

hg: jdk8/tl/langtools: 14 new changesets

Changeset: 4d4818b6df72 Author:chegar Date: 2013-04-24 11:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4d4818b6df72 Merge Changeset: 27cda5134748 Author:chegar Date: 2013-04-28 08:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/27cda

hg: jdk8/tl/nashorn: 9 new changesets

Changeset: af8a98ea83d4 Author:chegar Date: 2013-04-24 11:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/af8a98ea83d4 Merge Changeset: 2237e2ff3685 Author:chegar Date: 2013-04-28 08:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2237e2ff3

hg: jdk8/tl/corba: 9 new changesets

Changeset: 39d15bbb5741 Author:coffeys Date: 2013-04-08 23:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/39d15bbb5741 8001032: Restrict object access Summary: Restrict object access; fix reviewed also by Alexander Fomin Reviewed-by: alanb, ahgross ! make/com/sun/corba/

hg: jdk8/tl/jaxp: 9 new changesets

Changeset: f14f72174f00 Author:chegar Date: 2013-04-24 10:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f14f72174f00 Merge Changeset: b225607e056b Author:chegar Date: 2013-04-28 08:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b225607e056b M

hg: jdk8/tl/hotspot: 11 new changesets

Changeset: f75faf51e8c4 Author:hseigel Date: 2013-03-07 11:49 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f75faf51e8c4 7158805: Better rewriting of nested subroutine calls Reviewed-by: mschoene, coleenp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/alloca

hg: jdk8/tl/langtools: 8016607: javac, avoid analyzing lambdas for source 7 compilation

Changeset: e701af23a095 Author:vromero Date: 2013-06-18 18:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e701af23a095 8016607: javac, avoid analyzing lambdas for source 7 compilation Reviewed-by: jjg Contributed-by: maurizio.cimadam...@oracle.com ! src/share/classe

hg: jdk8/tl/langtools: 8016267: javac, TypeTag refactoring has provoked performance issues

Changeset: 9851071b551a Author:vromero Date: 2013-06-18 19:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9851071b551a 8016267: javac, TypeTag refactoring has provoked performance issues Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/s

hg: jdk8/tl/nashorn: 14 new changesets

Changeset: df5d7f34e35e Author:hannesw Date: 2013-06-11 17:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/df5d7f34e35e 8015379: PropertyMap.addProperty() is slow Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/runtime/PropertyMap.java Changeset: aa16622193e1

Re: RFR JDK8007636

On 06/17/2013 04:29 PM, John Zavgren wrote: Greetings: I'm posting a fix for a memory leak. As you can see, the original code deallocated a structure, thereby rendering it's memory invalid, then it deallocated the memory that was allocated to one of its data members. I merely reversed the order

Code review request, 8000456: Add programmatic deadlock detection in SSLEngineDeadlock

Hi, Please review this test update: http://cr.openjdk.java.net/~xuelei/8000456/webrev.00/ The test case SSLEngineDeadlock.java is used to detect the deadlock in SSLEngine. However, the result depends on time out. It is hard to tell whether the timeout is caused by deadlock or heavy loaded syst