hg: jdk8/tl/jdk: 8019381: HashMap.isEmpty is non-final, potential issues for get/remove

2013-07-04 Thread luchsh
Changeset: ed111451b77a Author:zhangshj Date: 2013-07-05 10:51 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ed111451b77a 8019381: HashMap.isEmpty is non-final, potential issues for get/remove Reviewed-by: chegar, mduigou ! src/share/classes/java/util/HashMap.java + test/ja

hg: jdk8/tl/jdk: 8017231: Add StringJoiner.merge

2013-07-04 Thread alan . bateman
Changeset: aa9fefb5d9c4 Author:alanb Date: 2013-07-04 20:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/aa9fefb5d9c4 8017231: Add StringJoiner.merge Reviewed-by: psandoz, alanb Contributed-by: brian.go...@oracle.com, henry@oracle.com ! src/share/classes/java/util/Stri

Re: Code Review Requests for 8012900: CICO ignores AAD in GCM mode

2013-07-04 Thread Matthew Hall
I think the RFC might require that the auth tag gets checked first before any data from the block gets released to the application, to prevent performing any processing on any data that turns out to be insecure. Matthew. -- Sent from my mobile device. Xuelei Fan wrote: >Hi Valerie, > >CC Bra

hg: jdk8/tl/jdk: 8019622: (sl) ServiceLoader.next incorrect when creation and usages are in different contexts

2013-07-04 Thread alan . bateman
Changeset: dd69273a0240 Author:alanb Date: 2013-07-04 14:38 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd69273a0240 8019622: (sl) ServiceLoader.next incorrect when creation and usages are in different contexts Reviewed-by: mchung, ahgross, forax, psandoz ! src/share/cla

Re: Code Review Requests for 8012900: CICO ignores AAD in GCM mode

2013-07-04 Thread Xuelei Fan
Hi Valerie, CC Brad. We start to run into the pain to get authentication tag appended in the tail of cipher text in our design. I looked back the discussion when we designed the APIs for GCM cipher in JDK 7. I found that when we run into GCM mode cipher operations, we may need to update the sou

hg: jdk8/tl/langtools: 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members

2013-07-04 Thread vicente . romero
Changeset: 79c3146e417b Author:vromero Date: 2013-07-04 10:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/79c3146e417b 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/jav

hg: jdk8/tl/langtools: 8009924: some langtools tools do not accept -cp as an alias for -classpath

2013-07-04 Thread vicente . romero
Changeset: d6158f8d7235 Author:vromero Date: 2013-07-04 10:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d6158f8d7235 8009924: some langtools tools do not accept -cp as an alias for -classpath Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/tool