hg: jdk8/tl/jdk: 8021429: Fix lint warnings in java.lang.ref

2013-07-25 Thread joe . darcy
Changeset: 86a827321c39 Author:darcy Date: 2013-07-25 20:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86a827321c39 8021429: Fix lint warnings in java.lang.ref Reviewed-by: lancea, mduigou, alanb ! src/share/classes/java/lang/ref/FinalReference.java ! src/share/classes/j

hg: jdk8/tl/jdk: 2 new changesets

2013-07-25 Thread sean . mullan
Changeset: 1744a32d3db3 Author:mullan Date: 2013-07-25 20:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1744a32d3db3 8012288: XML DSig API allows wrong tag names and extra elements in SignedInfo Reviewed-by: xuelei ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKey

Re: code review request: 8012971 PKCS11Test hiding exception failures

2013-07-25 Thread Valerie (Yu-Ching) Peng
Looks good~ Thanks, Valerie On 07/25/13 15:17, Anthony Scarpino wrote: On 07/24/2013 06:37 PM, Valerie (Yu-Ching) Peng wrote: On 07/24/13 13:53, Anthony Scarpino wrote: On 07/23/2013 06:00 PM, Valerie (Yu-Ching) Peng wrote: 263 System.arraycopy(data, 900, data, 0, 100); 26

Re: [8] Request for review: 8001319: Add SecurityPermission "insertProvider" target name

2013-07-25 Thread Sean Mullan
On 07/25/2013 05:08 PM, Sean Mullan wrote: Hello, Could you please review my fix for 8001319: webrev: http://cr.openjdk.java.net/~mullan/webrevs/8012288/webrev.00/ Correction above webrev: http://cr.openjdk.java.net/~mullan/webrevs/8001319/webrev.00/ bug: http://bugs.sun.com/bugdatabase/vi

Re: TLS extension needed for HTTP/2.0

2013-07-25 Thread Xuelei Fan
On 7/24/2013 6:41 AM, Zhong Yu wrote: Hi there, HTTP/2.0 draft (based on google's SPDY) requires the use of a new TLS extension (ALPN), see http://tools.ietf.org/html/draft-ietf-httpbis-http2-04#section-3.3 The current javax.net.ssl API does not support that, so it'll be a problem for someone t

Re: Code Review Request:8019544: Need to run ProviderTest.java in othervm mode

2013-07-25 Thread Xuelei Fan
Looks fine to me. Thanks! Xuelei On 7/26/2013 6:17 AM, Rajan Halade wrote: Could you please review the small fix for 8019544: http://cr.openjdk.java.net/~juh/rajan/8019544/webrev.00/ This is a test only fix for test stabilization.

Re: [8] Request for review: 8012288: XML DSig API allows wrong tag names and extra elements in SignedInfo

2013-07-25 Thread Xuelei Fan
On 7/26/2013 3:28 AM, Sean Mullan wrote: On 07/24/2013 10:16 AM, Xuelei Fan wrote: DOMUtils.java = It might be a little bit better to reuse the node local name checking with a new private static method. Good suggestion. Otherwise, looks fine. A minor comment is a very personal p

Re: Code Review Request:8019544: Need to run ProviderTest.java in othervm mode

2013-07-25 Thread Brad Wetmore
Looks good. brad On 7/25/2013 3:17 PM, Rajan Halade wrote: Could you please review the small fix for 8019544: http://cr.openjdk.java.net/~juh/rajan/8019544/webrev.00/ This is a test only fix for test stabilization. --

Code Review Request:8019544: Need to run ProviderTest.java in othervm mode

2013-07-25 Thread Rajan Halade
Could you please review the small fix for 8019544: http://cr.openjdk.java.net/~juh/rajan/8019544/webrev.00/ This is a test only fix for test stabilization. -- Rajan Halade, CISSP | Senior Member of Technical

Re: code review request: 8012971 PKCS11Test hiding exception failures

2013-07-25 Thread Anthony Scarpino
On 07/24/2013 06:37 PM, Valerie (Yu-Ching) Peng wrote: On 07/24/13 13:53, Anthony Scarpino wrote: On 07/23/2013 06:00 PM, Valerie (Yu-Ching) Peng wrote: 263 System.arraycopy(data, 900, data, 0, 100); 264 is.read(data, 0, 900); Do you really mean to overwrite

[8] Request for review: 8001319: Add SecurityPermission "insertProvider" target name

2013-07-25 Thread Sean Mullan
Hello, Could you please review my fix for 8001319: webrev: http://cr.openjdk.java.net/~mullan/webrevs/8012288/webrev.00/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001319 In this fix, we are adding a new SecurityPermission "insertProvider" target name for adding new security prov

Re: TLS extension needed for HTTP/2.0

2013-07-25 Thread Bernd Eckenfels
Hello, no direct response, but just a pointer: there is a third party Project by Ben Murphy which brings NPN to JSSE. I guess the same codebase can be used to add ALPN. This will allow to do experiments. https://github.com/benmmurphy/ssl_npn It is btw very unfortunate that there is no clea

hg: jdk8/tl/jdk: 8021148: Regression in SAXParserImpl in 7u40 b34 (NPE)

2013-07-25 Thread huizhe . wang
Changeset: 662ec7782102 Author:joehw Date: 2013-07-25 13:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/662ec7782102 8021148: Regression in SAXParserImpl in 7u40 b34 (NPE) Reviewed-by: chegar, lancea, dfuchs + test/javax/xml/jaxp/parsers/8021148/JAXPSAXParserTest.java + t

hg: jdk8/tl/jaxp: 8021148: Regression in SAXParserImpl in 7u40 b34 (NPE)

2013-07-25 Thread huizhe . wang
Changeset: 251ca1e2ccd3 Author:joehw Date: 2013-07-25 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/251ca1e2ccd3 8021148: Regression in SAXParserImpl in 7u40 b34 (NPE) Reviewed-by: chegar, lancea, dfuchs ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.jav

Re: [8] Request for review: 8012288: XML DSig API allows wrong tag names and extra elements in SignedInfo

2013-07-25 Thread Sean Mullan
On 07/24/2013 10:16 AM, Xuelei Fan wrote: DOMUtils.java = It might be a little bit better to reuse the node local name checking with a new private static method. Good suggestion. Otherwise, looks fine. A minor comment is a very personal preference. I may prefer to return null ins

hg: jdk8/tl/langtools: 8007961: javax.lang.model tests for repeating annotations fail in getAnnotationsByType

2013-07-25 Thread joel . franck
Changeset: a218f7befd55 Author:jfranck Date: 2013-07-25 11:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a218f7befd55 8007961: javax.lang.model tests for repeating annotations fail in getAnnotationsByType Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/co

hg: jdk8/tl/jdk: 8021421: More doclint fixes in java.net

2013-07-25 Thread chris . hegarty
Changeset: 9cd5159fa870 Author:chegar Date: 2013-07-25 19:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9cd5159fa870 8021421: More doclint fixes in java.net Reviewed-by: lancea, darcy ! src/share/classes/java/net/URI.java

hg: jdk8/tl/jdk: 8021417: Fix doclint issues in java.util.concurrent

2013-07-25 Thread chris . hegarty
Changeset: 690dcbaa69b7 Author:chegar Date: 2013-07-25 19:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/690dcbaa69b7 8021417: Fix doclint issues in java.util.concurrent Reviewed-by: chegar, lancea Contributed-by: Doug Lea ! src/share/classes/java/util/concurrent/Abstrac

hg: jdk8/tl/jdk: 8021408: Fix misc doclint issues in java.util and java.io

2013-07-25 Thread joe . darcy
Changeset: 21120e3682ef Author:darcy Date: 2013-07-25 09:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21120e3682ef 8021408: Fix misc doclint issues in java.util and java.io Reviewed-by: dholmes, chegar, psandoz ! src/share/classes/java/io/ObjectInputStream.java ! src/sh

hg: jdk8/tl/jdk: 2 new changesets

2013-07-25 Thread sean . mullan
Changeset: a834ab2c1354 Author:mullan Date: 2013-07-25 10:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a834ab2c1354 8010748: Add PKIXRevocationChecker NO_FALLBACK option and improve SOFT_FAIL option Reviewed-by: vinnie ! src/share/classes/java/security/cert/PKIXRevocat

hg: jdk8/tl/nashorn: 3 new changesets

2013-07-25 Thread sundararajan . athijegannathan
Changeset: 5c035c4ccc61 Author:sundar Date: 2013-07-25 14:05 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5c035c4ccc61 8021252: invokeMethod throws NoSuchMethodException when script object is from different script context Reviewed-by: lagergren, hannesw ! src/jdk/nash

Re: TLS extension needed for HTTP/2.0

2013-07-25 Thread Zhong Yu
Hi, can someone shed some light on the questions? Any information will be greatly appreciated. Thanks, Zhong Yu On Tue, Jul 23, 2013 at 5:41 PM, Zhong Yu wrote: > Hi there, > > HTTP/2.0 draft (based on google's SPDY) requires the use of a new TLS > extension (ALPN), see > http://tools.ietf.org/ht

hg: jdk8/tl/langtools: 3 new changesets

2013-07-25 Thread maurizio . cimadamore
Changeset: 3155e77d2676 Author:mcimadamore Date: 2013-07-25 14:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3155e77d2676 8020804: javac crashes when speculative attribution infers intersection type with array component Summary: Assertion is causing javac to crash

Code review request, 8013809 deadlock in SSLSocketImpl between between write and close

2013-07-25 Thread Xuelei Fan
Hi Brad, Are you available to review this fix? Webrev: http://cr.openjdk.java.net/~xuelei/8013809/webrev.00/ No new regression test, hard to reproduce the issue. Thanks, Xuelei