The fix looks fine.
BTW, I think the relationship between
javax.security.auth.login.Configuration and
javax.security.auth.login.ConfigurationSpi is not that instinctive in
the implementation. For example, the impl of
Configuration.getAppConfigurationEntry() should be able to use the impl
of
Changeset: 0ad00ae4fec6
Author:hannesw
Date: 2013-08-01 12:23 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0ad00ae4fec6
8020132: Big object literal with numerical keys exceeds method size
Reviewed-by: lagergren, sundar
!
Hi,
Please review the bug fix to strict the illegal input checking in IDN.
webrev: http://cr.openjdk.java.net./~xuelei/8020842/webrev.00/
Here is two test cases, which are expected to get IAE.
Case 1:
String host = IDN.toASCII(., IDN.USE_STD3_ASCII_RULES);
Exception in thread main
Changeset: 99b60bcf3862
Author:vromero
Date: 2013-08-06 15:08 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/99b60bcf3862
8022186: javac generates dead code if a try with an empty body has a finalizer
Reviewed-by: jjg
!
I am not sure if IDN.java is the correct place to change. At least I've
seen trailing dots in DNS entries. So maybe it's not so illegal.
--Max
On 8/6/13 7:44 PM, Xuelei Fan wrote:
Hi,
Please review the bug fix to strict the illegal input checking in IDN.
webrev:
On Aug 6, 2013, at 23:08, Weijun Wang weijun.w...@oracle.com wrote:
I am not sure if IDN.java is the correct place to change. At least I've seen
trailing dots in DNS entries. So maybe it's not so illegal.
Per RFC 1034, a domain name cannot end with dot. I will check other related
Changeset: 1f4af3e0447e
Author:mullan
Date: 2013-08-06 08:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f4af3e0447e
8022120: JCK test api/javax_xml/crypto/dsig/TransformService/index_ParamMethods
fails
Summary: TransformService.init and marshalParams must throw
Xuelei,
. (dot) is perfectly valid domain name and it means root domain so com.
is valid domain name as well.
It thinks to me that in context of methods your change we should ignore
trailing dots, rather than throw exception.
-Dmitry
On 2013-08-06 15:44, Xuelei Fan wrote:
Hi,
Please
It might be useful to add a more general method to set boolean options
like this. For example:
public final void setOptions(SetOption options)
public final Option getOptions()
SSLParameters.Option is an enum:
public enum SSLParameters.Option {
ENFORCE_CIPHER_SUITE_ORDER,
// alternate
On 08/06/2013 10:21 AM, Sean Mullan wrote:
It might be useful to add a more general method to set boolean options
like this. For example:
public final void setOptions(SetOption options)
public final Option getOptions()
oops, above should be:
public final SetOption getOptions()
--Sean
Thinking out loud here...seems like we need to talk about impacts on both
sides of the wire.
On the client side, I don't think this can have any effect. According to
the TLS RFC (link), the ClientHello includes the
cipher_suites
This is a list of the cryptographic options supported by
Changeset: 98643f3ddf40
Author:darcy
Date: 2013-08-06 13:25 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/98643f3ddf40
8022174: Fix doclint warnings in javax.sound
8022404: Fix doclint issues in java.applet
Reviewed-by: prr
!
On 08/06/2013 01:16 PM, Jason Uh wrote:
Hi Joe,
Could you please review this changeset, which takes care of
deprecation warnings in sun.security.ec?
http://cr.openjdk.java.net/~juh/8022439/webrev.00
Thanks,
Jason
Hi Jason,
Since this is not a public class, adding @Deprected is fine
Changeset: 12c1b78acf9a
Author:lagergren
Date: 2013-08-06 12:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/12c1b78acf9a
8022412: Fixed warnings in java.util root, except for HashMap
Reviewed-by: mduigou, darcy
Contributed-by: marcus.lagerg...@oracle.com
!
Changeset: 8112076ae424
Author:juh
Date: 2013-08-06 13:46 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8112076ae424
8022439: Fix lint warnings in sun.security.ec
Reviewed-by: darcy
! src/share/classes/sun/security/ec/ECDSASignature.java
Hi Joe,
Please review this changeset, which fixes lint deprecation warnings in
sun.security.pkcs12.
http://cr.openjdk.java.net/~juh/8022443/webrev.00/
Thanks!
Jason
On 08/06/2013 01:54 PM, Jason Uh wrote:
Hi Joe,
Please review this changeset, which fixes lint deprecation warnings in
sun.security.pkcs12.
http://cr.openjdk.java.net/~juh/8022443/webrev.00/
Thanks!
Jason
Hi Jason,
Given the deprecated overload of equals, your changes look fine.
Changeset: 69cfd941aec2
Author:juh
Date: 2013-08-06 14:10 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69cfd941aec2
8022443: Fix lint warnings in sun.security.pkcs12
Reviewed-by: darcy
! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java
Looks fine to me, but is the intention to remove the cast once 8022444
(Remove sun.security.util.equals(ObjectIdentifier other) methods) is
fixed? Wouldn't it be easier just to fix 8022444 instead which would
also fix the lint warnings?
--Sean
On 08/06/2013 01:54 PM, Jason Uh wrote:
Hi Joe,
Changeset: 4b8b811059db
Author:dxu
Date: 2013-08-06 14:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b8b811059db
8022410: Fix Javac Warnings in com.sun.security.auth Package
Reviewed-by: darcy
! src/share/classes/com/sun/security/auth/PolicyFile.java
!
Changeset: d5694d78ebc6
Author:darcy
Date: 2013-08-06 16:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5694d78ebc6
8022406: Fix doclint issues in java.beans
Reviewed-by: prr
! src/share/classes/java/beans/AppletInitializer.java
! src/share/classes/java/beans/Beans.java
Joe, Sean,
Could I please get a review of this changeset? This change fixes
deprecation warnings in:
sun.security.provider
sun.security.rsa
sun.security.x509
In sun.security.provider and sun.security.rsa, I change the use of
sun.security.x509.X509Key's key bytes to the BitArray form of
Changeset: 988a5f2ac559
Author:cl
Date: 2013-08-01 04:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/988a5f2ac559
Added tag jdk8-b101 for changeset 60b623a36164
! .hgtags
Changeset: 528c7e76eaee
Author:cl
Date: 2013-08-01 04:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/528c7e76eaee
Added tag jdk8-b101 for changeset a013024b0747
! .hgtags
Changeset: 342a954b68f3
Author:lana
Date: 2013-08-06 16:54 -0700
URL:
Changeset: 573ccf92d646
Author:cl
Date: 2013-08-01 04:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/573ccf92d646
Added tag jdk8-b101 for changeset a302b05d0ee4
! .hgtags
Changeset: e966ff0a3ffe
Author:lana
Date: 2013-08-06 10:02 -0700
URL:
Changeset: 4c42fba7b0e7
Author:cl
Date: 2013-08-01 04:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4c42fba7b0e7
Added tag jdk8-b101 for changeset 0324dbf07b0f
! .hgtags
Changeset: 453a305e1165
Author:lana
Date: 2013-08-06 10:03 -0700
URL:
Changeset: b52a2ecdb803
Author:cl
Date: 2013-08-01 04:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b52a2ecdb803
Added tag jdk8-b101 for changeset 690161232823
! .hgtags
Changeset: 2978c0a543ed
Author:prr
Date: 2013-07-22 12:52 -0700
URL:
Changeset: 5eb3c1dc348f
Author:cl
Date: 2013-08-01 04:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/5eb3c1dc348f
Added tag jdk8-b101 for changeset 9f74a220677d
! .hgtags
Changeset: 1d21ff5c2b3f
Author:dxu
Date: 2013-08-06 18:16 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d21ff5c2b3f
8022478: Fix Warnings In sun.net.www.protocol.http Package
Reviewed-by: darcy
! src/share/classes/sun/net/www/protocol/http/AuthCacheValue.java
!
Changeset: e117fcdd2176
Author:mduigou
Date: 2013-08-06 18:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e117fcdd2176
8022476: cleanup some raw types and unchecked warnings in java.util.stream
Reviewed-by: darcy
Contributed-by: mike.dui...@oracle.com,
Change looks fine.
Minor issue:
Extra parenthesis in
src/share/classes/sun/security/rsa/RSAPublicKeyImpl.java:
+byte[] keyArray =
+(new DerValue(DerValue.tag_Sequence,
+ out.toByteArray())).toByteArray();
One question:
In
Looks fine to me.
BTW, I was wondering whether we can remove the deprecated attributes in
X509Key after this fix. And as only the encodedKey is serialized, I
think we can use the @serial tag and transient fields to make the code
more friendly.
Xuelei
On 8/7/2013 7:46 AM, Jason Uh wrote:
Joe,
Thank you for the valued feedback!
On 8/7/2013 1:37 AM, Bruce Rich wrote:
Thinking out loud here...seems like we need to talk about impacts on
both sides of the wire.
On the client side, I don't think this can have any effect. According
to the TLS RFC (link
Hello Xuelei,
I dont get the Idea behind this. There are quite a few aspects of the SSL
handshake which could/should be dynamically configurable and we don't have
an option for today (for example the renegotiation).
For SSL Cipher order there is no real demand to make it configurable (and
34 matches
Mail list logo
