Re: Code review request, 8020842 IDN do not throw IAE when hostname ends with a trailing dot

Hi Michael, It is pretty hard to get the issue solved in SNIHostName in a good sharp. Here is my try to state why we should fix the issue in IDN. In SNIHostName, the following hostname are not accepted as valid hostname: 1. empty hostname 2. hostname ends with a trailing dot 3. hostname does not

Re: Code review request, 8020842 IDN do not throw IAE when hostname ends with a trailing dot

Hi Michael, I plan to address this issue in SNIHostName. I have filled another two the potential bugs in IDN. Thank you, and other people, for the feedback. Thanks, Xuelei On 8/9/2013 11:25 PM, Xuelei Fan wrote: > On 8/9/2013 7:31 PM, Michael McMahon wrote: >> I don't see how this fixes the or

hg: jdk8/tl/langtools: 8022161: javac Null Pointer Exception in Enter.visitTopLevel

Changeset: d601238641e6 Author:ksrini Date: 2013-08-09 15:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d601238641e6 8022161: javac Null Pointer Exception in Enter.visitTopLevel Reviewed-by: jjg, vromero, jlahoda ! src/share/classes/com/sun/tools/javac/comp/Enter.j

hg: jdk8/tl/jdk: 8022548: SPECJVM2008 has errors introduced in 7u40-b34

Changeset: 8f01ccb0c981 Author:joehw Date: 2013-08-09 12:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8f01ccb0c981 8022548: SPECJVM2008 has errors introduced in 7u40-b34 Reviewed-by: chegar, lancea + test/javax/xml/jaxp/parsers/8022548/JDK8022548.xml + test/javax/xml/ja

hg: jdk8/tl/jaxp: 8022548: SPECJVM2008 has errors introduced in 7u40-b34

Changeset: 4e23bc205d9d Author:joehw Date: 2013-08-09 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/4e23bc205d9d 8022548: SPECJVM2008 has errors introduced in 7u40-b34 Reviewed-by: chegar, lancea ! src/com/sun/org/apache/xerces/internal/parsers/DTDConfiguration.java

hg: jdk8/tl/jdk: 8020054: (tz) Support tzdata2013d

Changeset: a7c341f30747 Author:sherman Date: 2013-08-09 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7c341f30747 8020054: (tz) Support tzdata2013d Summary: update the jdk8 tz data to version 2013d Reviewed-by: coffeys, peytoia ! make/sun/javazic/tzdata/VERSION ! mak

hg: jdk8/tl/jdk: 8021977: Opening a file using java.io can throw IOException on Windows

Changeset: 03822f2389bf Author:dxu Date: 2013-08-09 10:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/03822f2389bf 8021977: Opening a file using java.io can throw IOException on Windows Summary: Remove IOException related error-handling code for backward compatibility Rev

hg: jdk8/tl/jdk: 8022724: lint warnings in j.u.concurrent packages

Changeset: ce1c874903cb Author:dl Date: 2013-08-09 17:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce1c874903cb 8022724: lint warnings in j.u.concurrent packages Reviewed-by: chegar, lancea, darcy ! src/share/classes/java/util/concurrent/CompletableFuture.java ! src/sha

Re: Code review request, 8020842 IDN do not throw IAE when hostname ends with a trailing dot

On 8/9/2013 7:31 PM, Michael McMahon wrote: > I don't see how this fixes the original problem as the SNIHostName spec > still doesn't like hostnames with a trailing '.' > The bug description did not reflect the IDN specification correctly. If "com." is a valid IDN, SNIHostName should accept it an

Re: Code review request, 8022487 DEREncodedKeyValue.supportedKeyTypes should be private

Looks fine to me. --Sean On 08/08/2013 09:38 PM, Xuelei Fan wrote: Hi, Please review this simple fix in xml security implementation. webrev: http://cr.openjdk.java.net/~xuelei/8022487/webrev.00/ In com/sun/org/apache/xml/internal/security/keys/content/DEREncodedKeyValue.java, the attribute i

hg: jdk8/tl/jdk: 8022661: InetAddress.writeObject() performs flush() on object output stream

Changeset: 84004d0e3fdd Author:chegar Date: 2013-08-09 13:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84004d0e3fdd 8022661: InetAddress.writeObject() performs flush() on object output stream Reviewed-by: michaelm, alanb ! src/share/classes/java/net/InetAddress.java

Re: Code review request, 8020842 IDN do not throw IAE when hostname ends with a trailing dot

I don't see how this fixes the original problem as the SNIHostName spec still doesn't like hostnames with a trailing '.' I'd prefer to check first where that requirement is coming from, if it is actually necessary, and if not consider removing it from SNIHostName. If it is necessary, then the che

hg: jdk8/tl/jdk: 8022326: Spliterator for values of j.u.c.ConcurrentSkipListMap does not report ORDERED

Changeset: c29ca19cb816 Author:psandoz Date: 2013-08-09 11:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c29ca19cb816 8022326: Spliterator for values of j.u.c.ConcurrentSkipListMap does not report ORDERED Reviewed-by: martin, chegar ! src/share/classes/java/util/TreeMap

hg: jdk8/tl/jdk: 6614237: missing codepage Cp290 at java runtime

Changeset: 54f0ccdd9ad7 Author:sherman Date: 2013-08-08 23:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/54f0ccdd9ad7 6614237: missing codepage Cp290 at java runtime Summary: to add charset Cp290 and Cp300 Reviewed-by: okutsu + make/tools/CharsetMapping/IBM290.c2b + make

Re: Code review request, 8020842 IDN do not throw IAE when hostname ends with a trailing dot

On Aug 9, 2013, at 14:08, Dmitry Samersoff wrote: > Xuelei, > > 119 p = q + 1; > 120 if (p < input.length() || q == (input.length() - 1)) { > > Could be simplified to: > > q <= input.length()-1 > It's cool! Xuelei > -Dmitry > > On 2013-08-09 04:41, Xuelei Fan wrote: