Changeset: 21a25911f7f7
Author:xuelei
Date: 2013-08-19 18:49 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21a25911f7f7
8023230: The impl of KerberosClientKeyExchange maybe not exist
Reviewed-by: weijun
! src/share/classes/sun/security/ssl/KerberosClientKeyExchange.java
On 8/20/2013 9:37 AM, Weijun Wang wrote:
> Looks fine now.
>
> Or maybe you can just remove KerberosClientKeyExchange()? I remember an
> empty public constrictor is equivalent to no constructor. Of course you
> made it protected so it's a little different.
>
> When I ask if you saw a failure, I h
Looks fine now.
Or maybe you can just remove KerberosClientKeyExchange()? I remember an
empty public constrictor is equivalent to no constructor. Of course you
made it protected so it's a little different.
When I ask if you saw a failure, I had two different questions:
1. Is the code change
new webrev: http://cr.openjdk.java.net/~xuelei/8023230/webrev.01/
On 8/19/2013 9:53 PM, Weijun Wang wrote:
> Only one change I don't understand:
>
> 73 public KerberosClientKeyExchange() {
> 74 if (impl == null) {
> 75 throw new IllegalStateException("Kerberos is
> u
Changeset: 096e7c665857
Author:xuelei
Date: 2013-08-19 17:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/096e7c665857
8020842: IDN do not throw IAE when hostname ends with a trailing dot
Reviewed-by: weijun, michaelm
! src/share/classes/java/net/IDN.java
+ test/java/net/I
Changeset: f120e2c4b4b1
Author:mullan
Date: 2013-08-19 17:17 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f120e2c4b4b1
8016850: JCK javax.security.auth.Policy tests fail when run in Profiles mode
Summary: Move default javax.security.auth.Policy implementation to compact1
p
Changeset: 2fd841fccb2e
Author:dxu
Date: 2013-08-19 12:38 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2fd841fccb2e
8023203: Wrap RandomAccessFile.seek native method into a Java helper method
Reviewed-by: alanb, chegar
! make/java/java/mapfile-vers
! makefiles/mapfiles/lib
Ditto.
brad
On 8/19/2013 12:08 PM, Sean Mullan wrote:
Looks fine.
--Sean
On 08/19/2013 02:52 PM, Anthony Scarpino wrote:
Hi,
I need a very simple review on enabling a test
http://cr.openjdk.java.net/~ascarpino/8022896/webrev.00/
thanks
Tony
Your change looks fine.
On 19/08/2013 19:52, Anthony Scarpino wrote:
Hi,
I need a very simple review on enabling a test
http://cr.openjdk.java.net/~ascarpino/8022896/webrev.00/
thanks
Tony
Changeset: bce5205dbe84
Author:ascarpino
Date: 2013-08-14 10:50 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bce5205dbe84
8022669: OAEPParameterSpec does not work if MGF1ParameterSpec is set to SHA2
algorithms
Reviewed-by: mullan
! src/share/classes/sun/security/rsa/RSAPa
Your fix looks fine Sean.
On 19/08/2013 15:27, Sean Mullan wrote:
Ping? Can anyone review this for me? The changes are not as extensive as
they look; this is mostly just moving code to a different package. Also,
com.sun.security.auth.PolicyParser.java has been removed as
sun.security.provider.Po
Looks fine.
--Sean
On 08/19/2013 02:52 PM, Anthony Scarpino wrote:
Hi,
I need a very simple review on enabling a test
http://cr.openjdk.java.net/~ascarpino/8022896/webrev.00/
thanks
Tony
Hi,
I need a very simple review on enabling a test
http://cr.openjdk.java.net/~ascarpino/8022896/webrev.00/
thanks
Tony
Changeset: 389eaf6ed973
Author:ksrini
Date: 2013-08-19 07:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/389eaf6ed973
7071377: Exception when javac -processor is given a class name with invalid
postfix
Reviewed-by: jjg, vromero
! src/share/classes/com/sun/tools/jav
Seems fine to me Xuelei.
- Michael
On 19/08/13 06:56, Xuelei Fan wrote:
If no objections, I will push the change by COB Monday.
Thanks,
Xuelei
On 8/13/2013 4:29 PM, Xuelei Fan wrote:
Can I get an additional code review from networking team?
Thanks,
Xuelei
On 8/12/2013 2:07 PM, Weijun Wang
Changeset: bbc4e9d37315
Author:jlaskey
Date: 2013-08-12 18:00 -0300
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bbc4e9d37315
8022676: Confusing error message checking instanceof non-class
Reviewed-by: jlaskey, sundar
Contributed-by: michael.horow...@oracle.com
! src/jdk/nas
Changeset: 3647aab7b1d5
Author:psandoz
Date: 2013-08-06 14:26 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3647aab7b1d5
8014824: Document Spliterator characteristics and binding policy of java util
collection impls
Reviewed-by: chegar
! src/share/classes/java/util/ArrayDe
Ping? Can anyone review this for me? The changes are not as extensive as
they look; this is mostly just moving code to a different package. Also,
com.sun.security.auth.PolicyParser.java has been removed as
sun.security.provider.PolicyParser is functionally equivalent and can be
used instead.
Only one change I don't understand:
73 public KerberosClientKeyExchange() {
74 if (impl == null) {
75 throw new IllegalStateException("Kerberos is
unavailable");
76 }
77 }
It seems this constructor will be automatically called when constructing
an
Hi Sherman
I try out "jar i" after signing and it puts INDEX.LIST at the very
beginning of the file. Does this mean INDEX.LIST was actually an
exception? Or it's just a bug?
Anyway, I think I should update the fix for 8021788 and here is the webrev:
http://cr.openjdk.java.net/~weijun/80227
Hi Weijun,
Please review this update when you are available.
webrev: http://cr.openjdk.java.net/~xuelei/8023230/webrev.00/
If package sun.security.ssl.krb5 does not exist, the impl of
KerberosClientKeyExchange (krb5.KerberosClientKeyExchangeImpl) will not
present as well. Need to consider this c
Changeset: f580728b08b4
Author:alanb
Date: 2013-08-19 11:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f580728b08b4
8023215: test/java/util/Comparator/TypeTest.java not running (failing but
reported as passing)
Reviewed-by: psandoz
! test/java/util/Comparator/TypeTest.j
Changeset: 11ccaabdb2a8
Author:aefimov
Date: 2013-08-16 18:41 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11ccaabdb2a8
8021820: Number of opened files used in select() is limited to 1024 [macosx]
Reviewed-by: alanb, chegar, tbell, smarks
+ test/java/net/ServerSocket/Selec
Changeset: 00dcfaa6bc01
Author:aefimov
Date: 2013-08-16 18:40 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/rev/00dcfaa6bc01
8021820: Number of opened files used in select() is limited to 1024 [macosx]
Reviewed-by: alanb, chegar, tbell, smarks
! common/autoconf/generated-configure.
Changeset: 9e9f5713b26d
Author:psandoz
Date: 2013-08-06 14:26 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e9f5713b26d
8022318: Document Spliterator characteristics and binding policy of java util
concurrent collection impls
Reviewed-by: chegar
Contributed-by: Martin Buch
25 matches
Mail list logo
