Re: FutureTask.cancel(true) should run thread.interrupt within doPrivileged

2013-10-02 Thread David Holmes
On 3/10/2013 2:11 PM, Martin Buchholz wrote: I was responding to Peter Levart's suggestion of checking for the presence of a security manager before calling doPrivileged. Which is not an important question now, given that the primary question is whether we should allow future.cancel() to interru

Re: FutureTask.cancel(true) should run thread.interrupt within doPrivileged

2013-10-02 Thread David Holmes
On 3/10/2013 1:55 PM, Martin Buchholz wrote: On Wed, Oct 2, 2013 at 7:13 PM, David Holmes wrote: On 3/10/2013 2:54 AM, Martin Buchholz wrote: On Wed, Oct 2, 2013 at 9:49 AM, Peter Levart wrote: Hi Martin, If you want to optimize for without-security-manager case I want to optimize f

Re: FutureTask.cancel(true) should run thread.interrupt within doPrivileged

2013-10-02 Thread David Holmes
On 3/10/2013 2:54 AM, Martin Buchholz wrote: On Wed, Oct 2, 2013 at 9:49 AM, Peter Levart wrote: Hi Martin, If you want to optimize for without-security-manager case I want to optimize for the case that Thread.interrupt does not throw SecurityException How is your proposal optimizing tha

Re: [concurrency-interest] FutureTask.cancel(true) should run thread.interrupt within doPrivileged

2013-10-02 Thread David Holmes
On 3/10/2013 3:02 AM, Doug Lea wrote: On 10/02/2013 12:29 PM, Martin Buchholz wrote: FutureTask.cancel(true) invokes thread.interrupt on the thread (if any) currently running the task. This should succeed even if modifyThread permission is denied by the security manager. We haven't interprete

hg: jdk8/tl/jdk: 8020981: Update methods of java.lang.reflect.Parameter to throw correct exceptions

2013-10-02 Thread eric . mccorkle
Changeset: cb8946eda85b Author:emc Date: 2013-10-02 19:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb8946eda85b 8020981: Update methods of java.lang.reflect.Parameter to throw correct exceptions Summary: Fix behavior of parameter reflection API for malformed class file

Re: [concurrency-interest] FutureTask.cancel(true) should run thread.interrupt within doPrivileged

2013-10-02 Thread Doug Lea
On 10/02/2013 12:29 PM, Martin Buchholz wrote: FutureTask.cancel(true) invokes thread.interrupt on the thread (if any) currently running the task. This should succeed even if modifyThread permission is denied by the security manager. We haven't interpreted "should" in this way in the past here

Re: FutureTask.cancel(true) should run thread.interrupt within doPrivileged

2013-10-02 Thread Peter Levart
Hi Martin, If you want to optimize for without-security-manager case, then it would be better this way: private static void privilegedInterrupt(Thread t) { if (System.getSecurityManager() == null) { t.interrupt(); } else { PrivilegedAction doInterrup

hg: jdk8/tl/jdk: 8025694: Rename getStrongSecureRandom based on feedback; ...

2013-10-02 Thread bradford . wetmore
Changeset: a6ac824b463d Author:wetmore Date: 2013-10-02 09:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a6ac824b463d 8025694: Rename getStrongSecureRandom based on feedback 8014838: getStrongSecureRandom() should require at least one implementation Reviewed-by: mullan, d

hg: jdk8/tl/langtools: 8023679: Improve error message for '_' used as a lambda parameter name

2013-10-02 Thread vicente . romero
Changeset: 1e6088da1740 Author:vromero Date: 2013-10-02 17:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e6088da1740 8023679: Improve error message for '_' used as a lambda parameter name Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/parser/Jav

hg: jdk8/tl/jdk: 6696975: JTop plugin fails if connected readonly to target JVM

2013-10-02 Thread staffan . larsen
Changeset: 3bb89c509d59 Author:egahlin Date: 2013-10-01 17:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3bb89c509d59 6696975: JTop plugin fails if connected readonly to target JVM Reviewed-by: mchung, jbachorik, sla, sjiang ! src/share/demo/management/JTop/JTop.java

Re: RFR: JDK-8014838: getStrongSecureRandom() should require at least one implementation

2013-10-02 Thread Sean Mullan
Looks good to me. --Sean On 10/02/2013 12:28 AM, Bradford Wetmore wrote: During the internal CCC review, the CCC lead suggested a change to the method name to more closely follow the existing getInstance() methods, so I've changed the name from: java.security.SecureRandom.getStrongSecureR

hg: jdk8/tl/jdk: 8025535: Unsafe typecast in java.util.stream.SortedOps

2013-10-02 Thread paul . sandoz
Changeset: e1b04fd49204 Author:psandoz Date: 2013-10-01 18:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e1b04fd49204 8025535: Unsafe typecast in java.util.stream.SortedOps Reviewed-by: mduigou, chegar ! src/share/classes/java/util/stream/SortedOps.java ! test/java/util

hg: jdk8/tl/jdk: 8022666: java.util.Calendar.set(int, int, int, int, int, int) documentation typo

2013-10-02 Thread masayoshi . okutsu
Changeset: 82e3150778e0 Author:okutsu Date: 2013-10-02 17:57 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82e3150778e0 8022666: java.util.Calendar.set(int,int,int,int,int,int) documentation typo Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java

hg: jdk8/tl/jdk: 8024952: ClassCastException in PlainSocketImpl.accept() when using custom socketImpl

2013-10-02 Thread sean . coffey
Changeset: 368172cb6dc5 Author:coffeys Date: 2013-10-02 09:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/368172cb6dc5 8024952: ClassCastException in PlainSocketImpl.accept() when using custom socketImpl Reviewed-by: chegar ! src/windows/classes/java/net/PlainSocketImpl.

hg: jdk8/tl/jdk: 6902861: (cal) GregorianCalendar roll WEEK_OF_YEAR is broken for January 1 2010

2013-10-02 Thread masayoshi . okutsu
Changeset: 914c29c10bce Author:okutsu Date: 2013-10-02 15:31 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/914c29c10bce 6902861: (cal) GregorianCalendar roll WEEK_OF_YEAR is broken for January 1 2010 Reviewed-by: peytoia ! src/share/classes/java/util/GregorianCalendar.java