Your changes look fine.
Thanks.
On 10/10/2013 01:56, Weijun Wang wrote:
Hi Vinnie
Please take a review at
http://cr.openjdk.java.net/~weijun/8026235/webrev.00/
Thanks
Max
On 10/9/2013 6:18 PM, David Holmes wrote:
cc'ing Joe Darcy. :)
Joe: there is a try-with-resources question for you below ...
On 9/10/2013 11:20 PM, Sean Mullan wrote:
On 10/09/2013 05:14 AM, Erik Joelsson wrote:
On 2013-10-09 06:33, David Holmes wrote:
In the tool this code doesn't show cor
This looks harmless. But it looks more like a jtreg issue if it cannot
deal with that slash.
I haven't noticed it failing on Windows before. Can you point me to a
jtr file.
Thanks
Max
On 10/10/13 8:56 AM, Jason Uh wrote:
Please review this fix. This changeset removes trailing slashes at the
Changeset: c13309f658e1
Author:darcy
Date: 2013-10-09 18:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c13309f658e1
8024354: Explicitly permit DoubleStream.sum()/average() implementations to use
higher precision summation
Reviewed-by: mduigou, briangoetz
! src/share/cla
Changeset: eab3c09745b6
Author:bchristi
Date: 2013-10-09 12:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eab3c09745b6
8024709: TreeMap.DescendingKeyIterator 'remove' confuses iterator position
Summary: Override remove() method in DescendingKeyIterator
Reviewed-by: alanb,
cc'ing Joe Darcy. :)
Joe: there is a try-with-resources question for you below ...
On 9/10/2013 11:20 PM, Sean Mullan wrote:
On 10/09/2013 05:14 AM, Erik Joelsson wrote:
On 2013-10-09 06:33, David Holmes wrote:
In the tool this code doesn't show correct use of try-with-resources:
51
Please review this fix. This changeset removes trailing slashes at the
end of the test library paths in the jtreg @library tag, which can cause
the tests to fail on Windows.
webrev: http://cr.openjdk.java.net/~juh/8026052/webrev.00/
Thanks,
Jason
Hi Vinnie,
Could you please review this fix? The test
sun/security/tools/keytool/StorePasswords.java can terminate with an
error on Windows because of files not getting cleaned up, so this fix
deletes the keystore file at the end of the test.
webrev: http://cr.openjdk.java.net/~juh/8026233/w
Hi Vinnie
Please take a review at
http://cr.openjdk.java.net/~weijun/8026235/webrev.00/
Thanks
Max
Changeset: 673f8045311e
Author:bpb
Date: 2013-10-09 17:22 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/673f8045311e
7189139: BigInteger's staticRandom field can be a source of bottlenecks.
Summary: Use ThreadLocalRandom instead of SecureRandom.
Reviewed-by: shade, psandoz
C
Changeset: 1597066b58ee
Author:valeriep
Date: 2013-10-08 11:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1597066b58ee
7196382: PKCS11 provider should support 2048-bit DH
Summary: Query and enforce range checking using the values from native PKCS11
library.
Reviewed-by:
Changeset: b86e6700266e
Author:bpb
Date: 2013-10-09 11:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b86e6700266e
8016252: More defensive HashSet.readObject
Summary: Add data validation checks in readObject().
Reviewed-by: alanb, mduigou, chegar
Contributed-by: Brian Burk
Changeset: d42fe440bda8
Author:rriggs
Date: 2013-10-09 13:34 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d42fe440bda8
8024076: Incorrect 2 -> 4 year parsing and resolution in DateTimeFormatter
Summary: Add appendValueReduced method based on a ChronoLocalDate to provide
co
Updated webrev:
http://cr.openjdk.java.net/~mullan/webrevs/8007292/webrev.01/
Let me know if there are any more comments, otherwise I will plan to
push tomorrow.
Thanks,
Sean
On 10/09/2013 09:20 AM, Sean Mullan wrote:
On 10/09/2013 05:14 AM, Erik Joelsson wrote:
Hello Sean,
On 2013-10-09
Changeset: c070001c4f60
Author:henryjen
Date: 2013-10-09 09:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c070001c4f60
8023524: Mechanism to dump generated lambda classes / log lambda code generation
Reviewed-by: plevart, mchung, forax, jjb
Contributed-by: brian.go...@ora
On 2013-10-08 17:41, Vincent Ryan wrote:
> Currently, there is no public API for named curves.
Since I wanted a source-compatible BC, JDK 6-7, and Android solution, I
ended-up using
public key samples instead:
ECParameterSpec spec = ((ECPublicKey) KeyFactory.getInstance
("EC").generatePublic (n
Changeset: e3b70e601c1c
Author:rriggs
Date: 2013-10-09 11:02 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e3b70e601c1c
8024612: java/time/tck/java/time/format/TCKDateTimeFormatters.java failed
Summary: The test should be using the Locale.Category.FORMAT to verify the test
Changeset: cf6e39cfdf50
Author:mchung
Date: 2013-10-09 06:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf6e39cfdf50
8026027: Level.parse should return the custom Level instance instead of the
mirrored Level
Reviewed-by: dfuchs, chegar
! src/share/classes/java/util/logg
Changeset: 1cd20806fd5c
Author:psandoz
Date: 2013-10-09 15:19 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1cd20806fd5c
8020061: Clarify reporting characteristics between splits
Reviewed-by: alanb, chegar
! src/share/classes/java/util/Spliterator.java
On 10/09/2013 05:14 AM, Erik Joelsson wrote:
Hello Sean,
On 2013-10-09 06:33, David Holmes wrote:
Hi Sean,
Not a full review.
On 9/10/2013 5:52 AM, Sean Mullan wrote:
Please review the fix for the following bug:
https://bugs.openjdk.java.net/browse/JDK-8007292
This bug requires build ch
Changeset: 8d29733ad609
Author:sundar
Date: 2013-10-09 10:47 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8d29733ad609
8026112: Function("with(x ? 1e81 : (x2.constructor = 0.1)){}") throws
AssertionError: double is not compatible with object
Reviewed-by: lagergren, han
Changeset: 0be3f1820e8b
Author:jlahoda
Date: 2013-10-09 13:06 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0be3f1820e8b
8025141: java.lang.ClassFormatError: Illegal field modifiers in class (...)
Summary: Should not generate non-public $assertionsDisabled field into
Changeset: 91a752e3d50b
Author:vinnie
Date: 2013-10-09 10:48 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/91a752e3d50b
8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class
Reviewed-by: mullan, weijun
+ src/share/classes/java/security/DomainLoadStorePar
Hello Sean,
On 2013-10-09 06:33, David Holmes wrote:
Hi Sean,
Not a full review.
On 9/10/2013 5:52 AM, Sean Mullan wrote:
Please review the fix for the following bug:
https://bugs.openjdk.java.net/browse/JDK-8007292
This bug requires build changes and a new build tool to add additional
r
Thanks Max.
On 9 Oct 2013, at 01:51, Weijun Wang wrote:
> The code change looks fine. Do we need a CCC for it?
Yes. CCC has been approved.
>
> Thanks
> Max
>
> p.s. I would use the bugs.openjdk.java.net URL.
Right. My webrev generates the old URL by default. I've changed it to use
OpenJDK i
Changeset: 2ea162b2ff55
Author:alanb
Date: 2013-10-09 09:20 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ea162b2ff55
8008662: Add @jdk.Exported to JDK-specific/exported APIs
Reviewed-by: chegar, vinnie, dfuchs, mchung, mullan, darcy
! src/share/classes/com/sun/jdi/AbsentI
Thanks.
On 8 Oct 2013, at 19:33, Sean Mullan wrote:
> Looks good to me.
>
> --Sean
>
> On 10/08/2013 02:14 PM, Vincent Ryan wrote:
>> Please review the following change - it's a simple re-factoring to promote a
>> nested class to a stand-alone class:
>>
>> Bug: http://bugs.sun.com/bugdatabase
Changeset: ea000904db62
Author:alundblad
Date: 2013-10-08 15:33 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ea000904db62
8024415: Bug in javac Pretty: Wrong precedence in JCConditional trees
Summary: Fixed precedence and associativity issues with pretty printing of
28 matches
Mail list logo
