Re: Code Review Request: 8025763

2013-10-18 Thread Anthony Scarpino
On 10/18/2013 12:44 PM, Sean Mullan wrote: Mostly looks good, just a few comments: - for completeness, please add @Override tags to all existing methods that are overridden - you need to also override the new forEach and getOrDefault methods to first check if the provider is initialized. See, f

hg: jdk8/tl/langtools: 8026567: Use meaningful style names for strong and italic styles.

2013-10-18 Thread bhavesh . x . patel
Changeset: 130b8c0e570e Author:bpatel Date: 2013-10-18 16:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/130b8c0e570e 8026567: Use meaningful style names for strong and italic styles. Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractE

hg: jdk8/tl/langtools: 8026749: Missing LV table in lambda bodies

2013-10-18 Thread jonathan . gibbons
Changeset: 7de97abc4a5c Author:jjg Date: 2013-10-18 15:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de97abc4a5c 8026749: Missing LV table in lambda bodies Reviewed-by: vromero, jlahoda ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/co

hg: jdk8/tl/jdk: 8025828: Late binding of Chronology to appendValueReduced

2013-10-18 Thread roger . riggs
Changeset: 7a947daa8f51 Author:rriggs Date: 2013-10-18 16:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a947daa8f51 8025828: Late binding of Chronology to appendValueReduced Summary: Add a listener to the parseContext called when the Chronology changes Reviewed-by: sherm

[8] Review Request for 8021191: Add isAuthorized check to limited doPrivileged methods

2013-10-18 Thread Sean Mullan
Please review this change to the limited doPrivileged methods to check that the passed-in access control context is authorized before using. http://cr.openjdk.java.net/~mullan/webrevs/8021191/webrev.00/ Thanks, Sean

Re: InvocationTargetException when running applet locally

2013-10-18 Thread Bernd Eckenfels
Am 18.10.2013, 22:44 Uhr, schrieb Mickey Segal : There is nothing here that jumps out to me as something that I can fix, so I will go ahead and file the bug report. I'll probably wait a day in case anyone else has something important to add. Yes, looks like a Java bug. One thing you could

RE: InvocationTargetException when running applet locally

2013-10-18 Thread Mickey Segal
Thanks. I didn't know that some Exceptions were not visible until the trace level was set higher. There is nothing here that jumps out to me as something that I can fix, so I will go ahead and file the bug report. I'll probably wait a day in case anyone else has something important to add.

hg: jdk8/tl/jdk: 8004213: JDP packet needs pid, broadcast interval and rmi server hostname fields

2013-10-18 Thread dmitry . samersoff
Changeset: 88436832cfd0 Author:dsamersoff Date: 2013-10-19 00:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88436832cfd0 8004213: JDP packet needs pid, broadcast interval and rmi server hostname fields Summary: Add some extra fileds to jdp packet Reviewed-by: allwin, sla,

Re: InvocationTargetException when running applet locally

2013-10-18 Thread Bernd Eckenfels
Am 18.10.2013, 19:55 Uhr, schrieb Mickey Segal : I'm working this up as a bug report. I have a description, a Web version and a zip file to download and try locally at: http://www.segal.org/java/SignedAppletTest/ I get this in the detail view: java.lang.RuntimeException: java.lang.reflect.

Re: Code Review Request: 8025763

2013-10-18 Thread Sean Mullan
Mostly looks good, just a few comments: - for completeness, please add @Override tags to all existing methods that are overridden - you need to also override the new forEach and getOrDefault methods to first check if the provider is initialized. See, for example, the get method. - nit, say

Re: Code review request: 7025699: Policy Tool is not accessible by keyboard

2013-10-18 Thread Anthony Petrov
+1 -- best regards, Anthony On 10/17/2013 09:11 PM, alexander potochkin wrote: Hello Leif Looks good to me I had a look at the PolicyTool code and indeed it is better to leave the IO processing as is at this moment. Thanks alexp Hi All, A new webrev is available at: http://cr.openjdk.

hg: jdk8/tl/jdk: 8026028: [findbugs] findbugs report some issue in com.sun.jmx.snmp package

2013-10-18 Thread shanliang . jiang
Changeset: 4161f17dfe2b Author:sjiang Date: 2013-10-18 16:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4161f17dfe2b 8026028: [findbugs] findbugs report some issue in com.sun.jmx.snmp package Reviewed-by: psandoz, dfuchs ! src/share/classes/com/sun/jmx/snmp/SnmpString.ja

RE: InvocationTargetException when running applet locally

2013-10-18 Thread Mickey Segal
On Windows there is a folder: C:\Users\MyUserName\AppData\LocalLow\Sun\Java\Deployment\log but it is empty. I'm working this up as a bug report. I have a description, a Web version and a zip file to download and try locally at: http://www.segal.org/java/SignedAppletTest/ If anyone has any insig

Re: InvocationTargetException when running applet locally

2013-10-18 Thread Sean Mullan
On 10/18/2013 10:53 AM, Mickey Segal wrote: I'm having trouble resolving what you mean by $HOME. I'm used to it meaning on Windows the same thing as the user.home property, which is: c:\Users\MyUserName\ but I don't see anything there, even looking with "Hide protected operating system files"

hg: jdk8/tl/jdk: 8024660: TEST_BUG: java/lang/ProcessBuilder/*IOHandle.java leaving hotspot.log open in fastdebug builds

2013-10-18 Thread rob . mckenna
Changeset: 8d1d5a5aeb41 Author:robm Date: 2013-10-18 16:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d1d5a5aeb41 8024660: TEST_BUG: java/lang/ProcessBuilder/*IOHandle.java leaving hotspot.log open in fastdebug builds Reviewed-by: alanb Contributed-by: pavel.pune...@ora

hg: jdk8/tl/jdk: 2 new changesets

2013-10-18 Thread alan . bateman
Changeset: 602aa6fa46c6 Author:alanb Date: 2013-10-18 15:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/602aa6fa46c6 8026876: (fs) Build issue with src/solaris/classes/sun/nio/fs/SolarisUserDefinedFileAttributeView.java Reviewed-by: psandoz ! src/solaris/classes/sun/nio/

hg: jdk8/tl/nashorn: 4 new changesets

2013-10-18 Thread sundararajan . athijegannathan
Changeset: b01a10c7c7c2 Author:attila Date: 2013-10-17 12:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b01a10c7c7c2 8026161: Don't narrow floating-point literals in the lexer Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashor

RE: InvocationTargetException when running applet locally

2013-10-18 Thread Mickey Segal
I'm having trouble resolving what you mean by $HOME. I'm used to it meaning on Windows the same thing as the user.home property, which is: c:\Users\MyUserName\ but I don't see anything there, even looking with "Hide protected operating system files" disabled. Can you help point me in the right

RE: InvocationTargetException when running applet locally

2013-10-18 Thread Mickey Segal
I implemented for our Java applet that runs locally the following Manifest lines: Permissions: all-permissions Codebase: * We'd added these in a Manifest.txt file for our Web version after the changes in a previous version that flagged errors unless these were present. But after installing 7

Re: InvocationTargetException when running applet locally

2013-10-18 Thread Sean Mullan
On 10/18/2013 06:37 AM, Mickey Segal wrote: We were able to get past the problem of getCodeBase() returning null by hard-coding the URL. This worked in 7 update 25 and 7 update 40. We were able to debug that problem because the applet would launch and we could use println statements find that th

hg: jdk8/tl/jdk: 3 new changesets

2013-10-18 Thread alan . bateman
Changeset: da695008417f Author:alanb Date: 2013-10-18 13:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da695008417f 8026859: (fs) test/java/nio/file/Files/StreamTest.java fails to compile intermittently Reviewed-by: psandoz ! test/java/nio/file/Files/StreamTest.java Ch

hg: jdk8/tl/jdk: 8021897: EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals()

2013-10-18 Thread staffan . larsen
Changeset: 8479a48d9fd4 Author:sla Date: 2013-10-18 11:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8479a48d9fd4 8021897: EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals() Reviewed-by: alanb, sspitsyn ! src/share/back/outStream.c + test/com/sun/jdi/GetUnini

RE: InvocationTargetException when running applet locally

2013-10-18 Thread Mickey Segal
There are also some JAR Manifest changes in 7u45, as detailed at http://www.oracle.com/technetwork/java/javase/7u45-relnotes-2016950.html#newft I don't know if that can explain the complete failure to load and the InvocationTargetException, or is just an additional issue. -Original Messag

RE: InvocationTargetException when running applet locally

2013-10-18 Thread Mickey Segal
We were able to get past the problem of getCodeBase() returning null by hard-coding the URL. This worked in 7 update 25 and 7 update 40. We were able to debug that problem because the applet would launch and we could use println statements find that the problem was getCodeBase() returning null

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-18 Thread Alan Bateman
On 17/10/2013 20:25, Andrew wrote: : Is the intention for these 'exported' APIs to be eventually replaced by proper parts of the specification (i.e. java.* or javax.*). I'm not keen on the idea of encouraging the use of APIs that are only in this implementation of the JDK. Just to add to Mandy'