hg: jdk8/tl/langtools: 8028739: javac generates incorrect descriptor for MethodHandle::invoke

2013-11-22 Thread robert . field
Changeset: 4fa835472e3c Author:rfield Date: 2013-11-22 17:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4fa835472e3c 8028739: javac generates incorrect descriptor for MethodHandle::invoke Summary: introduce special handling for signature polymorphic methods Reviewed

Re: Thoughts on possible options to JDK-8027598

2013-11-22 Thread Rajan Halade
On 11/22/2013 11:42, Sean Mullan wrote: On 11/21/2013 04:53 AM, Chris Hegarty wrote: If I am correct, JTREG has support provider cleanup already. But the question is even JTREG reset the providers, it still cannot ensure next test won't be impacted because in some circumstances JDK may need t

Re: Code Review Request for 7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to sign() instead of init()

2013-11-22 Thread Valerie (Yu-Ching) Peng
Thanks for the prompt review~ Valerie On 11/22/13 12:20, Sean Mullan wrote: On 11/22/2013 02:54 PM, Valerie (Yu-Ching) Peng wrote: Even if Solaris PKCS11 provider starts to support 2048-bit DSA keys, its SHA1withDSA signature impl should still only accept up-to-1024-bit DSA keys. The longer DS

Re: Code Review Request for 7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to sign() instead of init()

2013-11-22 Thread Sean Mullan
On 11/22/2013 02:54 PM, Valerie (Yu-Ching) Peng wrote: Even if Solaris PKCS11 provider starts to support 2048-bit DSA keys, its SHA1withDSA signature impl should still only accept up-to-1024-bit DSA keys. The longer DSA keys need newer signature impls using SHA2-family digests. So, the regressio

Re: Code Review Request for 7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to sign() instead of init()

2013-11-22 Thread Valerie (Yu-Ching) Peng
Even if Solaris PKCS11 provider starts to support 2048-bit DSA keys, its SHA1withDSA signature impl should still only accept up-to-1024-bit DSA keys. The longer DSA keys need newer signature impls using SHA2-family digests. So, the regression test should still be valid. Thanks, Valerie On 11

Re: Thoughts on possible options to JDK-8027598

2013-11-22 Thread Sean Mullan
On 11/21/2013 04:53 AM, Chris Hegarty wrote: If I am correct, JTREG has support provider cleanup already. But the question is even JTREG reset the providers, it still cannot ensure next test won't be impacted because in some circumstances JDK may need to cache something which depends on previous

Re: Code Review Request for 7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to sign() instead of init()

2013-11-22 Thread Sean Mullan
The fix looks good. One comment on the test - it looks like the test would start failing if Solaris PKCS11 started to support 2048 bit DSA keys. Is there a way to workaround that by checking the max key length supported by the library? --Sean On 11/19/2013 08:37 PM, Valerie (Yu-Ching) Peng wr

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

2013-11-22 Thread Alan Bateman
On 21/11/2013 15:54, Volker Simonis wrote: : But actually I've just realized that it is not need at all, because 'aix_close.c' isn't in the PATH for any other OS than AIX (that could be probably called a feature of the new file layout:) So I'll simply change it to: 48 ifeq ($(OPENJDK_TARGE

hg: jdk8/tl/jdk: 8023278: Reflection API methods do not throw AnnotationFormatError in case of malformed Runtime[In]VisibleTypeAnnotations attribute

2013-11-22 Thread joel . franck
Changeset: 0775f4f6532a Author:jfranck Date: 2013-11-22 11:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0775f4f6532a 8023278: Reflection API methods do not throw AnnotationFormatError in case of malformed Runtime[In]VisibleTypeAnnotations attribute Reviewed-by: darcy !

hg: jdk8/tl/jdk: 3 new changesets

2013-11-22 Thread sean . coffey
Changeset: cd56de5896b4 Author:aefimov Date: 2013-11-15 15:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd56de5896b4 8027848: The ZoneInfoFile doesn't honor future GMT offset changes Reviewed-by: sherman, coffeys ! src/share/classes/sun/util/calendar/ZoneInfoFile.java