Hi Sean,
Thanks for your suggestion, updated please review:
http://cr.openjdk.java.net/~ewang/kevin/JDK-8028562/webrev.00/
Thanks again,
Kevin
On 2013/12/6 1:13, Sean Mullan wrote:
Sorry for the late comment, but there is a typo in this comment (roud
-> round):
// will try to read one more
Looks good.
> On Dec 5, 2013, at 6:58 PM, Jason Uh wrote:
>
>
>
>> On 12/05/2013 01:26 PM, Sean Mullan wrote:
>> Looks good, just one nit - you can remove the imports of
>> PolicyMappingsExtension and X509CertImpl from ForwardBuilder.
>
> Done. Also, updated copyright date in ForwardBuilder.
On 12/05/2013 01:26 PM, Sean Mullan wrote:
Looks good, just one nit - you can remove the imports of
PolicyMappingsExtension and X509CertImpl from ForwardBuilder.
Done. Also, updated copyright date in ForwardBuilder.java.
http://cr.openjdk.java.net/~juh/8007967/webrev.02/
--Sean
On 12/05/20
Looks good, just one nit - you can remove the imports of
PolicyMappingsExtension and X509CertImpl from ForwardBuilder.
--Sean
On 12/05/2013 04:04 PM, Jason Uh wrote:
Thanks, Sean.
I've updated the webrev with your suggestions. Also, I've changed the
check for loops in ForwardBuilder.java to b
Thanks, Sean.
I've updated the webrev with your suggestions. Also, I've changed the
check for loops in ForwardBuilder.java to bail out whenever the same
certificate is encountered twice.
Please note that none of the policy mapping tests in the NIST PKITS use
loops. Also, RFC 4158's section o
On 12/04/2013 08:46 PM, Bradford Wetmore wrote:
I really don't think formatting changes as part of other approved
changes would be taboo. Joe Darcy has the same opinion. I would
restore, but too late now. I knew I should have got to this email
earlier. :)
Technically, I think we are still b
Sorry for the late comment, but there is a typo in this comment (roud ->
round):
// will try to read one more roud when read error
I suggest rewording this to:
// will try to read one more time if there is a read error
Also, it is too late to push this for JDK 8 as it is not critical, so
you
Changeset: 72ea199e3e1b
Author:robm
Date: 2013-12-05 16:19 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72ea199e3e1b
8029525: java/lang/ProcessBuilder/Basic.java fails intermittently
Reviewed-by: alanb, chegar
Contributed-by: roger.ri...@oracle.com
! test/java/lang/Process
Changeset: d3c4e8fe98c3
Author:bpb
Date: 2013-12-05 07:44 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d3c4e8fe98c3
8029514: java/math/BigInteger/BigIntegerTest.java failing since thresholds
adjusted in 8022181
Summary: Ensure the value returned by getLower() is unsigned.
Changeset: 8534e297484d
Author:yan
Date: 2013-12-05 18:04 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8534e297484d
8029264: [doclint] more doclint and tidy cleanup
Reviewed-by: alexsch, serb, malenkov
! src/share/classes/javax/swing/Action.java
! src/share/classes/javax/s
Changeset: 427c78c88229
Author:erikj
Date: 2013-12-05 09:25 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/427c78c88229
8027963: Create unlimited policy jars.
Reviewed-by: wetmore, ihse
! make/CreateSecurityJars.gmk
! make/SignJars.gmk
- make/data/cryptopolicy/limited/LIMITE
Changeset: dc2f0c40399a
Author:psandoz
Date: 2013-12-05 09:44 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dc2f0c40399a
8028564: Concurrent calls to CHM.put can fail to add the key/value to the map
Reviewed-by: psandoz, chegar, alanb
Contributed-by: Doug Lea
! src/share/c
12 matches
Mail list logo
