Looks good to me Vincent.
-Chris.
On 5 Feb 2014, at 17:06, Vincent Ryan wrote:
> Please review this fix for a potential memory leak in JAAS native code on
> Solaris:
>
> Webrev: http://cr.openjdk.java.net/~vinnie/8025669/webrev.00/
>
> The fix ensures that the calloc’d memory always gets fre
On 05/02/2014 17:06, Vincent Ryan wrote:
Please review this fix for a potential memory leak in JAAS native code on
Solaris:
Webrev: http://cr.openjdk.java.net/~vinnie/8025669/webrev.00/
The fix ensures that the calloc’d memory always gets freed.
Thanks.
This looks okay to me.
-Alan.
Please review this fix for a potential memory leak in JAAS native code on
Solaris:
Webrev: http://cr.openjdk.java.net/~vinnie/8025669/webrev.00/
The fix ensures that the calloc’d memory always gets freed.
Thanks.
Hello,
I’d like to make the following trivial fix to a JAAS function in native code on
Windows.
It simply corrects a printf statement to expect a pointer:
diff --git a/src/windows/native/com/sun/security/auth/module/nt.c
b/src/windows/native/com/sun/security/auth/module/nt.c
--- a/src/windows/
Hi Artem,
The specific fix looks fine, but there are many other calls to
getLength() in DerInputStream that subsequently initialize an array with
the return value, and could also cause the same issue. It seems to me
that a better fix would be to pass a flag to the getLength method (or
create
