Fine to me.
Xuelei
On 3/1/2014 11:53 AM, Wang Weijun wrote:
> Ping again.
>
> On Feb 25, 2014, at 20:44, Wang Weijun wrote:
>
>> Please review the code change at
>>
>> http://cr.openjdk.java.net/~weijun/7176574/7u/webrev.00/
>>
>> This is a backport of 3 jdk8 fixes on sun/security/krb5/auto/
Ping again.
On Feb 25, 2014, at 20:44, Wang Weijun wrote:
> Please review the code change at
>
> http://cr.openjdk.java.net/~weijun/7176574/7u/webrev.00/
>
> This is a backport of 3 jdk8 fixes on sun/security/krb5/auto/TcpTimeout.java
>
> 7176574: sun/security/krb5/auto/TcpTimeout.java fa
On 3/1/2014 7:38 AM, Jason Uh wrote:
> Do I need more than one noreg tag? I already have noreg-sqe.
>
noreg-sqe is OK.
Thanks,
Xuelei
> On 2/28/14 3:31 PM, Xuelei Fan wrote:
>> Looks fine to me. noreg-trivial tag?
>>
>> Xuelei
>>
>> On 3/1/2014 3:56 AM, Jason Uh wrote:
>>> Could I please get a
Do I need more than one noreg tag? I already have noreg-sqe.
On 2/28/14 3:31 PM, Xuelei Fan wrote:
Looks fine to me. noreg-trivial tag?
Xuelei
On 3/1/2014 3:56 AM, Jason Uh wrote:
Could I please get a review of this change?
Just a simple fix for 7u-dev that adds a check for a null CertStore
Looks fine to me. noreg-trivial tag?
Xuelei
On 3/1/2014 3:56 AM, Jason Uh wrote:
> Could I please get a review of this change?
>
> Just a simple fix for 7u-dev that adds a check for a null CertStore, in
> case URICertStore.getInstance returns null.
>
> webrev: http://cr.openjdk.java.net/~juh/8
So I ran a stress test creating a number of keys and did not see much
different memory wise. But what I did notice that the performance was
dependent on the number Cipher.init() calls. If each thread only has
one Cipher.init() call, it performed 5x better (170k vs 844k ops/m), but
as soon as
Could I please get a review of this change?
Just a simple fix for 7u-dev that adds a check for a null CertStore, in
case URICertStore.getInstance returns null.
webrev: http://cr.openjdk.java.net/~juh/8035973/webrev.00/
bug: http://bugs.openjdk.java.net/browse/JDK-8035973
noreg-sqe because an
Hi Sean,
Could I please get a review of this change? This fix allows a certpath
to be validated when a certificate issued by a version 1 trusted cert
has a validity period that doesn't fall within the validity of the
issuer. Trust anchors whose validity do contain the issued cert's
validity p
Changeset: 183a8c520b4a
Author:rfield
Date: 2014-02-28 10:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/183a8c520b4a
8035777: Consistent Lambda construction
Reviewed-by: ahgross, briangoetz, dlsmith
! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory
