Re: Review Request of JDK 9 Enhancement Proposal: AEAD/CCM Cipher Mode

2014-03-24 Thread Anthony Scarpino
On 03/24/2014 04:59 PM, Bernd Eckenfels wrote: Am Mon, 24 Mar 2014 16:13:17 -0700 schrieb "Valerie (Yu-Ching) Peng" : Here is the enhancement proposal for adding CCM cipher mode support to JDK. For details, please refer to the following JEP: http://cr.openjdk.java.net/~valeriep/8008342/jepCCM

Re: Review Request of JDK 9 Enhancement Proposal: AEAD/CCM Cipher Mode

2014-03-24 Thread Matthew Hall
On Tue, Mar 25, 2014 at 12:59:39AM +0100, Bernd Eckenfels wrote: > Sounds great, there is no mentioning of specific machine instructions > to speed up CCM (like PCLMULQDQ for GCM) or no relationship to the AES > intrinsic. It would really be a shame if (both) new modes cannot > benefit from typical

Re: Review Request of JDK 9 Enhancement Proposal: AEAD/CCM Cipher Mode

2014-03-24 Thread Bernd Eckenfels
Am Mon, 24 Mar 2014 16:13:17 -0700 schrieb "Valerie (Yu-Ching) Peng" : > > Here is the enhancement proposal for adding CCM cipher mode support > to JDK. For details, please refer to the following JEP: > > http://cr.openjdk.java.net/~valeriep/8008342/jepCCM.txt > > Comments or feedback welcome.

Review Request of JDK 9 Enhancement Proposal: AEAD/CCM Cipher Mode

2014-03-24 Thread Valerie (Yu-Ching) Peng
Here is the enhancement proposal for adding CCM cipher mode support to JDK. For details, please refer to the following JEP: http://cr.openjdk.java.net/~valeriep/8008342/jepCCM.txt Comments or feedback welcome. Thanks, Valerie

Re: RFR 8037258: AIOB while parsing CRL for revoked certificate

2014-03-24 Thread Sean Mullan
Looks good to me. --Sean On 03/19/2014 11:36 AM, Rajan Halade wrote: Please review this small fix - http://cr.openjdk.java.net/~mullan/webrevs/8037258/webrev.02/ I have also updated the source to remove unused variables and updated javadoc information. Thanks, Rajan

[PATCH] Add class java.security.StandardMessageDigests

2014-03-24 Thread Florian Weimer
This CR adds a new class java.security.StandardMessageDigests: Could I get a bug number if this change is fine in principle? Cryptographic hash functions are frequently used directly, often for non-cryptographic purposes, so I

Re: Review Request of JDK Enhancement Proposal: DTLS

2014-03-24 Thread Michael McMahon
My understanding is that the original PMTU discovery spec RFC 1191 is not very effective due to its reliance on ICMP messages that are often filtered out by routers. There was an update in RFC 4821 which removes the dependency on ICMP and that seems to be effective I'm just wondering then how DTL

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2014-03-24 Thread Florian Weimer
On 03/21/2014 06:28 PM, Andrew Hughes wrote: I still think it's better to remove the dlopen/dlsym machinery and use dynamic linking instead. I've provided that as an option in IcedTea, but it then means that a different PCSC implementation can't be swapped in. I think you can still use LD_

Re: Review Request of JDK Enhancement Proposal: DTLS

2014-03-24 Thread Florian Weimer
On 03/20/2014 01:31 AM, Matthew Hall wrote: Is there an existing method for determining valid PMTU from inside of Java? If not then supplying correct segment size to whatever DTLSEngine (or however it's named) class would be non-trivial and could require native code. If there is not such suppor