Re: [Update]: webrev request: JDK-6996377

2014-05-09 Thread Sean Mullan
Looks good, very comprehensive test. My only comment is that it would be helpful to add the keytool command you used to create each certificate in a comment above the base64-encoded String. Thanks, Sean On 05/08/2014 09:23 PM, Jamil Nimeh wrote: Hello all, Updated webrev to account for Sean

Re: Review Request of JDK Enhancement Proposal: OCSP stapling

2014-05-09 Thread Xuelei Fan
On 5/9/2014 4:54 PM, Florian Weimer wrote: > On 05/06/2014 04:05 PM, Xuelei Fan wrote: >> On 5/6/2014 9:36 PM, Florian Weimer wrote: >>> On 04/02/2014 01:19 AM, Xuelei Fan wrote: Here is the updated version: http://cr.openjdk.java.net/~xuelei/8034248/jep-csre-v01.txt Updated

Re: RFR: 8028192 : Use of PKCS11-NSS provider in FIPS mode broken

2014-05-09 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 5/8/2014 11:59 PM, Seán Coffey wrote: > This is more or less a backport of the 8u20 code to the 7u-dev codebase. > > This update fixes the SunJSSE problem that in FIPS mode, SunJSSE does > not work because keys cannot be extracted from crypto device. > > Buil

Re: [PATCH] Add class java.security.StandardMessageDigests

2014-05-09 Thread Florian Weimer
On 05/06/2014 03:14 PM, Xuelei Fan wrote: True. So you think providing more efficient means for hashing relatively short byte sequences isn't worth the effort? The benefits are small, I think. It is easy to get similar improvement in application layer, but if we want add this to JRE for gen

Re: Review Request of JDK Enhancement Proposal: OCSP stapling

2014-05-09 Thread Florian Weimer
On 05/06/2014 04:05 PM, Xuelei Fan wrote: On 5/6/2014 9:36 PM, Florian Weimer wrote: On 04/02/2014 01:19 AM, Xuelei Fan wrote: Here is the updated version: http://cr.openjdk.java.net/~xuelei/8034248/jep-csre-v01.txt Updated the description section and a few words so that it is easier to un