Re: RFR (S) 8035974: Refactor DigestBase.engineUpdate() method for better code generation by JIT compiler

2014-05-23 Thread Vladimir Kozlov
Thank you, Paul, Remi, Anthony, for reviews. I changed "protected final" to "private" as suggested: http://cr.openjdk.java.net/~kvn/8035974/webrev.01 Note, JIT inlines final and private methods without generation a method's class check. So inlined code is the same. Thanks, Vladimir On 5/23/

Re: RFR (S) 8035974: Refactor DigestBase.engineUpdate() method for better code generation by JIT compiler

2014-05-23 Thread james cheng
On 5/23/2014 3:17 AM, Remi Forax wrote: On 05/23/2014 11:06 AM, Paul Sandoz wrote: On May 22, 2014, at 1:34 AM, Vladimir Kozlov wrote: http://cr.openjdk.java.net/~kvn/8035974/webrev https://bugs.openjdk.java.net/browse/JDK-8035974 Contributed by James Cheng and modified by me. Looks good

Re: RFR (S) 8035974: Refactor DigestBase.engineUpdate() method for better code generation by JIT compiler

2014-05-23 Thread Remi Forax
On 05/23/2014 11:06 AM, Paul Sandoz wrote: On May 22, 2014, at 1:34 AM, Vladimir Kozlov wrote: http://cr.openjdk.java.net/~kvn/8035974/webrev https://bugs.openjdk.java.net/browse/JDK-8035974 Contributed by James Cheng and modified by me. Looks good to me. Paul. implCompressMultiBlock sh

Re: RFR (S) 8035974: Refactor DigestBase.engineUpdate() method for better code generation by JIT compiler

2014-05-23 Thread Anthony Scarpino
This looks fine to me Tony > On May 21, 2014, at 4:34 PM, Vladimir Kozlov > wrote: > > http://cr.openjdk.java.net/~kvn/8035974/webrev > https://bugs.openjdk.java.net/browse/JDK-8035974 > > Contributed by James Cheng and modified by me. > > To use intrinsics to accelerate SHA operations on mu

Re: RFR (S) 8035974: Refactor DigestBase.engineUpdate() method for better code generation by JIT compiler

2014-05-23 Thread Paul Sandoz
On May 22, 2014, at 1:34 AM, Vladimir Kozlov wrote: > http://cr.openjdk.java.net/~kvn/8035974/webrev > https://bugs.openjdk.java.net/browse/JDK-8035974 > > Contributed by James Cheng and modified by me. > Looks good to me. Paul. > To use intrinsics to accelerate SHA operations on multiple b