On May 29, 2014, at 18:19, Xuelei Fan wrote:
> Looks fine to me. A minor comment about the coding conversions.
>
> src/share/classes/sun/security/krb5/KdcComm.java
>
> 437 if (s == null) return -1;
>
> I would suggest always use braces
Thanks for fixing this so quickly, the build appears to be fine now.
Kumar
On 5/29/2014 3:09 PM, Valerie (Yu-Ching) Peng wrote:
Changes look good.
Thanks,
Valerie
On 05/29/14 13:39, Ivan Gerasimov wrote:
Thanks Valerie!
On 30.05.2014 0:09, Valerie (Yu-Ching) Peng wrote:
1) Since we are rol
Changes look good.
Thanks,
Valerie
On 05/29/14 13:39, Ivan Gerasimov wrote:
Thanks Valerie!
On 30.05.2014 0:09, Valerie (Yu-Ching) Peng wrote:
1) Since we are rolling back to the earlier code, how about just use
the original code? I somehow find this easier to parse than the 2
nested almost
Thanks Valerie!
On 30.05.2014 0:09, Valerie (Yu-Ching) Peng wrote:
1) Since we are rolling back to the earlier code, how about just use
the original code? I somehow find this easier to parse than the 2
nested almost-identical for-loops in the current fix.
char* cp = spec;
while (*cp
1) Since we are rolling back to the earlier code, how about just use the
original code? I somehow find this easier to parse than the 2 nested
almost-identical for-loops in the current fix.
char* cp = spec;
while (*cp != 0) {
cp += (strlen(cp) + 1);
++cnt;
}
2) Add
Hi!
With the recent code modification I used a pcsc-lite specific constant
which is only defined on *nix platforms.
As a result, windows builds failed. Sorry about that!
Would you please review the partial backout fix: Dynamic array
allocation is restored.
BUGURL: https://bugs.openjdk.java.
Thanks.
On 29 May 2014, at 15:55, Wang Weijun wrote:
> Great. That looks good.
>
> Thanks
> Max
>
> On May 29, 2014, at 22:50, Vincent Ryan wrote:
>
>> Updated webrev at:
>> http://cr.openjdk.java.net/~vinnie/8044038/webrev.01/
>>
>>
>> On 29 May 2014, at 14:47, Vincent Ryan wrote:
>>
>>
Great. That looks good.
Thanks
Max
On May 29, 2014, at 22:50, Vincent Ryan wrote:
> Updated webrev at:
> http://cr.openjdk.java.net/~vinnie/8044038/webrev.01/
>
>
> On 29 May 2014, at 14:47, Vincent Ryan wrote:
>
>> Sure. I’ll add it to autotest.sh too.
>>
>> On 29 May 2014, at 14:40, Wan
Updated webrev at:
http://cr.openjdk.java.net/~vinnie/8044038/webrev.01/
On 29 May 2014, at 14:47, Vincent Ryan wrote:
> Sure. I’ll add it to autotest.sh too.
>
> On 29 May 2014, at 14:40, Wang Weijun wrote:
>
>> Vinnie
>>
>> The bug report shows sun/security/tools/keytool/autotest.sh als
Sure. I’ll add it to autotest.sh too.
On 29 May 2014, at 14:40, Wang Weijun wrote:
> Vinnie
>
> The bug report shows sun/security/tools/keytool/autotest.sh also failed. The
> test includes
>
>LIBNAME=`find_one \
>"/usr/lib/libsoftokn3.so" \
>"/usr/lib/i386-linu
Vinnie
The bug report shows sun/security/tools/keytool/autotest.sh also failed. The
test includes
LIBNAME=`find_one \
"/usr/lib/libsoftokn3.so" \
"/usr/lib/i386-linux-gnu/nss/libsoftokn3.so" \
"/usr/lib/nss/libsoftokn3.so"`
Maybe adding a line for /us
Looks fine to me.
Xuelei
On 5/29/2014 9:29 PM, Vincent Ryan wrote:
> Please review this trivial change to enable the PKCS11/NSS tests to be run on
> older (Ubuntu) Linux 32-bit releases.
> The ‘/usr/lib32’ directory is now included in the search order for NSS
> libraries.
>
> Bug: https://bugs
Please review this trivial change to enable the PKCS11/NSS tests to be run on
older (Ubuntu) Linux 32-bit releases.
The ‘/usr/lib32’ directory is now included in the search order for NSS
libraries.
Bug: https://bugs.openjdk.java.net/browse/JDK-8044038
Webrev: http://cr.openjdk.java.net/~vinnie/8
Looks fine to me. A minor comment about the coding conversions.
src/share/classes/sun/security/krb5/KdcComm.java
437 if (s == null) return -1;
I would suggest always use braces even for single line statement [1].
if (s == null) {
New webrev at
http://cr.openjdk.java.net/~weijun/8036779/webrev.01/
The value can take the form of a bare non-negative integer in milliseconds, or
a non-negative integer followed by "s" (no space between) in seconds.
Thanks
Max
On May 19, 2014, at 21:49, Wang Weijun wrote:
> After some di
15 matches
Mail list logo
