(smartcardio) Confusing bug fix for wrong DWORD typedef

2014-06-13 Thread Yonathan
In a commit about a month ago[1], Ivan Gerasimov fixed a long-standing bug in using javax.smartcardio on OS X that I previously mentioned[2]. I am uncomfortable with this fix, because to determine whether it was successful requires study of x86_64 calling conventions. Recall that the bug was that

Re: [9] review request for 8036613: [parfait] JNI exception pending in jdk/src/windows/native/sun/security/provider/WinCAPISeedGenerator.c

2014-06-13 Thread Sean Mullan
Looks ok to me. Bug needs a noreg label. --Sean On 06/10/2014 11:02 AM, Vincent Ryan wrote: Please review this fix to check for a memory allocation failure and clean-up: Bug: https://bugs.openjdk.java.net/browse/JDK-8036613 Webrev: http://cr.openjdk.java.net/~vinnie/8036613/webrev.00/ Thanks.