Review request for CR 8044193 Need to add known answer tests for AES cipher

2014-07-28 Thread zaiyao liu
Hello, Please help to review the tests for AES cipher. This tests test AES ciphers with different modes and padding schemes when provider change,are part of tests for bug 8044193(Open part) Bug - https://bugs.openjdk.java.net/browse/JDK-8044193 webrev- http://cr.openjdk.java.net/~rhala

Re: getKDCFromDNS called too often

2014-07-28 Thread Wang Weijun
I understand your problem. Will see what we can do. When you say "Wouldn't it be possible to perform the lookup *once* and then issue all KDC request to the KDC whis is working?" do you mean the DNS query result could contain KDCs which do not work? Is this common? Guess there is no need for lo

Re: JEP Review Request: Improve Security Manager Performance

2014-07-28 Thread David M. Lloyd
On 07/28/2014 03:33 PM, Peter Levart wrote: On 07/28/2014 03:34 PM, David M. Lloyd wrote: On 07/24/2014 04:17 AM, Tom Hawtin wrote: On 23/07/2014 14:40, David M. Lloyd wrote: On 07/23/2014 07:07 AM, Tom Hawtin wrote: On 23/07/2014 05:26, David M. Lloyd wrote: • Always have static initiali

Re: JEP Review Request: Improve Security Manager Performance

2014-07-28 Thread Peter Levart
On 07/28/2014 03:34 PM, David M. Lloyd wrote: On 07/24/2014 04:17 AM, Tom Hawtin wrote: On 23/07/2014 14:40, David M. Lloyd wrote: On 07/23/2014 07:07 AM, Tom Hawtin wrote: On 23/07/2014 05:26, David M. Lloyd wrote: • Always have static initialization blocks be privileged (this does requir

Review request for CR 8049233 Need new tests for testing openssl created certificate

2014-07-28 Thread raghu k.nair
Hello, Please review the tests for openssl generated certificates and CRLS. This tests java.security.cert.Certificate.verify() method and behaviors of the following classes java.security.X509CRL, java.security.X509CRLSelector, java.security.X509CRLRevocationReason and java.security.X50

Re: Re: getKDCFromDNS called too often

2014-07-28 Thread Michael Osipov
> > Is it possible to specify the kdc for the realm inside krb5.conf? Java only > use DNS to get kdc when it cannot read one from krb5.conf. Max, this is what I did but this is not a solution because we have dozens of realms which in turn have tens of KDCs. Add those static lists to all Unix ma

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-07-28 Thread Erik Joelsson
Build change looks good to me now. /Erik On 2014-07-28 15:53, Wang Weijun wrote: Yes, you are right. Webrev updated at http://cr.openjdk.java.net/~weijun/6997010/webrev.02. GendataJavaSecurity.gmk and MakeJavaSecurity.java updated. Thanks Max On Jul 28, 2014, at 19:43, Erik Joelsson wrote:

Re: getKDCFromDNS called too often

2014-07-28 Thread Wang Weijun
Is it possible to specify the kdc for the realm inside krb5.conf? Java only use DNS to get kdc when it cannot read one from krb5.conf. --Max On Jul 28, 2014, at 21:16, Michael Osipov <1983-01...@gmx.net> wrote: > Hi folks, > > I am experiencing a performance degregation when JGSS tries to loca

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-07-28 Thread Wang Weijun
Yes, you are right. Webrev updated at http://cr.openjdk.java.net/~weijun/6997010/webrev.02. GendataJavaSecurity.gmk and MakeJavaSecurity.java updated. Thanks Max On Jul 28, 2014, at 19:43, Erik Joelsson wrote: > Hello Max, > > Shouldn't the rule for $(GENDATA_JAVA_SECURITY) depend on > $(RE

Re: JEP Review Request: Improve Security Manager Performance

2014-07-28 Thread David M. Lloyd
On 07/24/2014 04:17 AM, Tom Hawtin wrote: On 23/07/2014 14:40, David M. Lloyd wrote: On 07/23/2014 07:07 AM, Tom Hawtin wrote: On 23/07/2014 05:26, David M. Lloyd wrote: • Always have static initialization blocks be privileged (this does require users to be cognizant of this fact when writin

getKDCFromDNS called too often

2014-07-28 Thread Michael Osipov
Hi folks, I am experiencing a performance degregation when JGSS tries to locate a KDC via DNS. We have for our default realm 120 KDCs running. My Java code performs a SASL bind with Kerberos (keytab) to get some data from AD over LDAP. This takes sometimes minutes to do where weeks ago mere sec

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-07-28 Thread Erik Joelsson
Hello Max, Shouldn't the rule for $(GENDATA_JAVA_SECURITY) depend on $(RESTRICTED_PKGS_SRC) so that updates to the pkgs file triggers a rebuild? For that to work, the variable $(RESTRICTED_PKGS_SRC) needs to be empty for the OPENJDK case rather than have a dummy name and MakeJavaSecurity.java

RFR 8048052: Permission tests for "setFactory"

2014-07-28 Thread FELIX YANG
Please review a new test to "setFactory" permission. It is to address that "setFactory" permission is required or not as expected in a series of classes/methods under java.net. JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8048052 Webrev: http://cr.openjdk.java.net/~rhalade/8048052/webrev

RFR 8043836: Need new tests for AES cipher

2014-07-28 Thread FELIX YANG
May I request you to review these 6 new tests to be added for AES cipher. New tests are added to address following: - Test AES for different modes and padding schemes - Test AES encryption with no padding - same buffer can be used for encrypt and decrypt with AES JDK Issue: https://bugs.openjdk

Review request for CR 8049233 Need new tests for testing openssl created certificate

2014-07-28 Thread raghu k.nair
Hello, Please review the tests for openssl generated certificates and CRLS. This tests java.security.cert.Certificate.verify() method and behaviors of the following classes java.security.X509CRL, java.security.X509CRLSelector, java.security.X509CRLRevocationReason and java.security.X50

Review request for CR 8048362 Test doPrivileged with accomplice

2014-07-28 Thread raghu k.nair
Hello, Please review the test for doPrivliaged with accomplice. Bug - https://bugs.openjdk.java.net/browse/JDK-8048362 webrev- http://cr.openjdk.java.net/~rhalade/8048362/webrev.00/ Thanks, Raghu Nair

[JDK-9] RFR: 8041787: Need new regressions tests for buffer handling for PBE algorithms

2014-07-28 Thread Rajan Halade
May I request you to review these 4 new tests to be added for PBE keys. New tests are added to address following: - same buffer can be used for encrypt and decrypt with PBE - Mac update works correctly with different size of ByteBuffer - doFinal and update operation result in same PBMac - for PB