Re: RFR 8052999: ProblemList update for Unreachable.java

2014-07-29 Thread Xuelei Fan
Looks fine to me. Xuelei On 7/30/2014 10:56 AM, Wang Weijun wrote: > It seems jtharness just doesn't support one test on two lines. Please review > the same webrev at > >http://cr.openjdk.java.net/~weijun/8052999/webrev.00/ > > Thanks > Max > > On Jul 29, 2014, at 23:29, Wang Weijun wrot

Re: RFR 8052999: ProblemList update for Unreachable.java

2014-07-29 Thread Wang Weijun
It seems jtharness just doesn't support one test on two lines. Please review the same webrev at http://cr.openjdk.java.net/~weijun/8052999/webrev.00/ Thanks Max On Jul 29, 2014, at 23:29, Wang Weijun wrote: > I decide to further investigate why the 2-line version does not work. Webrev > w

Re: apple.security.KeychainStore does not load private key (when called from javaws)

2014-07-29 Thread Petr Pchelko
Added security-dev. With best regards. Petr. > On Jul 29, 2014, at 12:36 PM, Florian Bruckner (3kraft) > wrote: > > Hey guys, > > any feedback on this? > > What is the process to have a patch like this accepted? > > regards, > > Florian > > On 15.07.14 10:56, Florian Bruckner (3kraft) wro

Re: RFR 8052999: ProblemList update for Unreachable.java

2014-07-29 Thread Wang Weijun
I decide to further investigate why the 2-line version does not work. Webrev withdrawn. --Max On Jul 29, 2014, at 23:13, Wang Weijun wrote: > Please review the problem list change at > > http://cr.openjdk.java.net/~weijun/8052999/webrev.00/ > > Looks like the same test on two lines with di

RFR 8052999: ProblemList update for Unreachable.java

2014-07-29 Thread Wang Weijun
Please review the problem list change at http://cr.openjdk.java.net/~weijun/8052999/webrev.00/ Looks like the same test on two lines with different platform labels does not work. Now combined. Should this be a noreg-cleanup? --Max

[9] request for review 8051972: sun/security/pkcs11/ec/ReadCertificates.java fails intermittently

2014-07-29 Thread Vincent Ryan
Please review this simple fix to eliminate an intermittent test failure. Bug: https://bugs.openjdk.java.net/browse/JDK-8051972 Webrev: http://cr.openjdk.java.net/~vinnie/8051972/webrev.00/ The fix detects if a self-signed cert has inadvertently been selected for an invalid-signature test and ign

Re: getKDCFromDNS called too often

2014-07-29 Thread Wang Weijun
I guess we can cache the result and remove invalid ones, and probably requery when all are removed. https://bugs.openjdk.java.net/browse/JDK-8052412 filed. You said you are having double numbers of KDCs now, so I guess the DNS response could also double. How come the time spent change from "mer

Re: Re: getKDCFromDNS called too often

2014-07-29 Thread Michael Osipov
> I understand your problem. Will see what we can do. When you say "Wouldn't it > be possible to perform the lookup *once* and then issue all KDC request to > the KDC whis is working?" do you mean the DNS query result could contain KDCs > which do not work? Is this common? It can contain inval

Re: RFR 8043836: Need new tests for AES cipher

2014-07-29 Thread Florian Weimer
On 07/28/2014 10:57 AM, FELIX YANG wrote: JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8043836 This bug does not seem to be publicly accessible. -- Florian Weimer / Red Hat Product Security