Code review request, JDK-8052406, SSLv2Hello protocol may be filter out unexpectedly

2014-07-30 Thread Xuelei Fan
Hi, Please review this fix for JDK-8052406: Webrev: http://cr.openjdk.java.net/~xuelei/8052406/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8049321 For TLS connections, if no suitable cipher suite available for a particular TLS protocol, such protocol should not be negotiated. For ex

RFR J8050281: New permission tests for JEP 140

2014-07-30 Thread Amanda Jiang
Hi All, Could you please review following 2 new regression tests to be added for JEP140 (Limied doPrivileged). New tests are added to perform permission tests for limited doprivileged with multiple threads , and basic API testing. JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8050281 we

Re: Code review request, JDK-8052406, SSLv2Hello protocol may be filter out unexpectedly

2014-07-30 Thread Wang Weijun
The fix looks harmless, but I don't understand the test. What happens if SSLv2Hello is filtered out? --Max On Jul 30, 2014, at 20:56, Xuelei Fan wrote: > Hi, > > Please review this fix for JDK-8052406: > > Webrev: http://cr.openjdk.java.net/~xuelei/8052406/webrev.00/ > JBS: https://bugs.open

Re: Code review request, JDK-8052406, SSLv2Hello protocol may be filter out unexpectedly

2014-07-30 Thread Xuelei Fan
On 7/31/2014 8:14 AM, Wang Weijun wrote: > The fix looks harmless, but I don't understand the test. What happens if > SSLv2Hello is filtered out? > If SSLv2Hello is filtered out, this side would not support SSLv2Hello any more. If SSLv2Hello format client hello requested, the server would reject

Re: Code review request, JDK-8052406, SSLv2Hello protocol may be filter out unexpectedly

2014-07-30 Thread Wang Weijun
On Jul 31, 2014, at 8:54, Xuelei Fan wrote: > On 7/31/2014 8:14 AM, Wang Weijun wrote: >> The fix looks harmless, but I don't understand the test. What happens if >> SSLv2Hello is filtered out? >> > If SSLv2Hello is filtered out, this side would not support SSLv2Hello > any more. The server s

Re: Code review request, JDK-8052406, SSLv2Hello protocol may be filter out unexpectedly

2014-07-30 Thread Xuelei Fan
On 7/31/2014 9:11 AM, Wang Weijun wrote: > > On Jul 31, 2014, at 8:54, Xuelei Fan wrote: > >> On 7/31/2014 8:14 AM, Wang Weijun wrote: >>> The fix looks harmless, but I don't understand the test. What happens if >>> SSLv2Hello is filtered out? >>> >> If SSLv2Hello is filtered out, this side wou