Hello,
Please review the tests for sun.security.x509 classes.
These cover tests for GeneralName, GeneralNames, GeneralSubtree,
GeneralSubtrees, IPAddressName and IssuerAlternativeNameExtension.
webrev:
http://cr.openjdk.java.net/~rhalade/8049039/webrev.00/
Bug:
https://bugs.openjdk.java.net/
Hello ,
Please find the updated the webrev .
http://cr.openjdk.java.net/~rhalade/8048362/webrev.02/
Thanks,
Raghu
On 8/8/2014 7:21 PM, Vincent Ryan wrote:
Code looks fine.
I noticed a few typos: DoPrivTest.java l.26 and DoPrivAccompliceTest.java
l.34-38
On 4 Aug 2014, at 08:11, raghu k.nai
Hello all,
This webrev covers a fix to LoginContext so it no longer selects the
wrong method when a LoginModule method (login, logout, commit, etc.) has
been overloaded.
Bug: https://bugs.openjdk.java.net/browse/JDK-6562449
Webrev: http://cr.openjdk.java.net/~ascarpino/6562449/webrev.01
Than
Requesting approval for the backport of JDK-8035974. The change was
pushed to jdk 9 in May and it is applied cleanly to jdk8u sources:
Main RFE: https://bugs.openjdk.java.net/browse/JDK-8035974
Changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/dabb44358772
Review:
http://mail.openjdk.jav
Otavio,
Just skimmed through your changes. It looks good. But there are some things we
can make a little bit better though. IMO, it's not always a performance that
matters (looking around to see if Alexey Shipilev is somewhere near) but
readability. It's good to estimate performance requirement
+1
Some suggestions (mostly nits):
- in places like src/share/classes/java/util/regex/Pattern.java you
introducesingle-char
strings which might use a char instead:
-result.append("|"+next);
+result.append('|').append(next);
- in places like src/share/classes
> In the class
> src/share/classes/javax/management/openmbean/CompositeType.java you have
> added the
> annotation @SuppressWarnings("StringConcatenationInsideStringBufferAppend")
> instead of fixing the concatenation inside the append method. Why?
+1 Moreover, I wonder where this value comes from
Thanks, Ivan - approved for jdk7u-dev.
On 07.08.2014 16:54, Ivan Gerasimov wrote:
Hello!
May I ask for the approval to backport into 7u-dev repo?
The fix is the same as in jdk9/8u modulo lambda, so I'm including the
webrev here.
Jdk7 webrev: http://cr.openjdk.java.net/~igerasim/8046343/3/webr
Please review the fix at
http://cr.openjdk.java.net/~weijun/8054817/webrev.00
since we have a new getuid() now for all Unix systems.
It does return -1 on Windows, but I keep the osname.startsWith("Windows") check
to be exactly consistent with the current behavior. getuid() might return
some
On 11/08/2014 13:06, Peter Firmstone wrote:
Thanks Alan, I can relate to time poverty :)
I might be assuming too much, but if there's interest in doing
something with Serialization, I'd be interested in learning about
plans or difficulties involved in deserialization and modules. It can
be a
Hi,
About readable of code I just renamed this class to sb instead of buf,
> strbuf, etc.
>
I doubt that renaming variables does really improve the code readability.
And you changed the indentation (take look at other classes too):
239 public String toString() {
240 StringBuilder s
Thanks Alan, I can relate to time poverty :)
I might be assuming too much, but if there's interest in doing something
with Serialization, I'd be interested in learning about plans or
difficulties involved in deserialization and modules. It can be a
little more difficult to find the correct C
Hi Otávio,
please ignore the previous diff. I'm sorry, there was a small mistake. I
have attached the corrected version.
Best regards,
Andrej Golovnin
On Mon, Aug 11, 2014 at 1:55 PM, Andrej Golovnin
wrote:
> Hi Otávio,
>
> About the template in Parser.jjt, TokenMgrError.java, etc. I don't k
Hi Otávio,
About the template in Parser.jjt, TokenMgrError.java, etc. I don't know how
> can do that. Can anyone help me?
>
See attached diff for the changes in Parser.jjt and Parser.jj. For the
TokenMgrError and ParserException you can just subscribe here:
https://java.net/projects/javacc/lists
On 09/08/2014 06:56, Peter Firmstone wrote:
I've noticed there's not much interest in improving Serialization on
these lists. This makes me wonder if java Serialization has lost
relevance in recent years with the rise of protocol buffers apache
thrift and other means of data transfer over byt
On 11/08/2014 8:12 PM, Peter Firmstone wrote:
Brian,
Thanks for picking up on my frustration ;)
I have something in mind for Serializable2 to address cyclic data
structures and the possibility of independant evolution of super and
child classes, while retaining a relatively clean public api,
Brian,
Thanks for picking up on my frustration ;)
I have something in mind for Serializable2 to address cyclic data
structures and the possibility of independant evolution of super and
child classes, while retaining a relatively clean public api, with one
optional private method. The methods
Hi Otávio,
the class src/share/classes/com/sun/jmx/snmp/IPAcl/Parser.java is generated
from the grammar
src/share/classes/com/sun/jmx/snmp/IPAcl/Parser.jjt
src/share/classes/com/sun/jmx/snmp/IPAcl/Parser.jj
Therefore when you are going to change the Parser class, then you must
change the grammar
'\"' can be written as '"':
com_sun.diff:209:+sb.append('
').append(nodeName).append("=\"").append(att.getNodeValue()).append('\"');
java_lang.diff:31:+ sb.append('\"').append(getThreadName()).append('\"')
java_security.diff:78:+.append('\"');
s
19 matches
Mail list logo
