Re: Please review CR 8049429 tests for java client server communications with various TLS/SSL combinations.

Hi Xuelei, I will send you the updated webrev once made the changes. Thanks, Raghu Nair On 8/28/2014 11:20 AM, Xuelei Fan wrote: Remove Drew from the CC list. I have not read too much about the test code. I think, binary files are not preferred in mercurial workspace. Would you mind convert

Re: Please review CR 8049429 tests for java client server communications with various TLS/SSL combinations.

Remove Drew from the CC list. I have not read too much about the test code. I think, binary files are not preferred in mercurial workspace. Would you mind convert the PKCS12 binary file to nested stream in the test code? Here is an example about how to avoid the use of binary key store file.

Re: Review request for CR 8048832 Implement tests for domain key store

Hi Vincent, Please help me in reviewing Bug - https://bugs.openjdk.java.net/browse/JDK-8048832 webrev- http://cr.openjdk.java.net/~tyan/raghu/8048832/webrev01/ Thanks, Raghu Nair On 8/28/2014 11:12 AM, Wang Weijun wrote: Can you ask Vinnie to look at them? He designed and implemented DKS.

Re: Please review CR 8049429 tests for java client server communications with various TLS/SSL combinations.

I guess you were looking for Xuelei, the other Andrew in our team focusing on SSL/TLS. Normally we use Drew when talking about Andrew Gross. --Max On Aug 28, 2014, at 13:27, raghu k.nair wrote: > Hi Andrew, > >Could you please help in me in reviewing the following tests. > > Thanks, > Ra

Re: Review request for CR 8048832 Implement tests for domain key store

Can you ask Vinnie to look at them? He designed and implemented DKS. Although I know about the concept but I've never really used it. --Max On Aug 28, 2014, at 13:22, raghu k.nair wrote: > Hi Max, > Could you please help me in reviewing the following Domain Keystore tests. > > Thanks, > Rag

Re: Please review CR 8049429 tests for java client server communications with various TLS/SSL combinations.

Hi Andrew, Could you please help in me in reviewing the following tests. Thanks, Raghu Nair On 8/22/2014 2:58 PM, raghu k.nair wrote: Hello, Please help to review the tests for java client server communications with various TLS/SSL combinations. Bug - https://bugs.openjdk.java.net/b

Re: Review request for CR 8048832 Implement tests for domain key store

Hi Max, Could you please help me in reviewing the following Domain Keystore tests. Thanks, Raghu Nair On 8/22/2014 1:21 PM, raghu k.nair wrote: Hello, Please help to review the tests for Domain Keystore tests . Bug - https://bugs.openjdk.java.net/browse/JDK-8048832 webrev- http://cr.openj

RFR 8048621: Implement basic keystore tests

Hi All, Please review the code change,the purpose of this fix is implement basic tests for keystore types supported by JDK. Webrev: http://cr.openjdk.java.net/~tyan/kevin/JDK-8048621/webrev01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8048621 Thanks Kevin

Re: Replace concat String to append in StringBuilder parameters

On 28.08.2014 3:15, Wang Weijun wrote: OK, I'll remember that. Thanks. So you will include the StringBuilder changes into your fix? No. I reimplemented MimeEntry.toProperty() with StringJoiner: http://hg.openjdk.java.net/jdk9/dev/jdk/diff/8be081fb8db1/src/java.base/share/classes/sun/net/ww

Re: Replace concat String to append in StringBuilder parameters

OK, I'll remember that. So you will include the StringBuilder changes into your fix? --Max On Aug 28, 2014, at 2:10, Ivan Gerasimov wrote: > Hi Max! > >> The core part is updated again at >> >> http://cr.openjdk.java.net/~weijun/8055723/core/webrev.03/ > > Can you please revert changes to

Re: Replace concat String to append in StringBuilder parameters

Hi Max! The core part is updated again at http://cr.openjdk.java.net/~weijun/8055723/core/webrev.03/ Can you please revert changes to src/java.base/share/classes/sun/net/www/MimeEntry.java, as they're conflicting with the fix for JDK-8054714? Apologizing for adding you more work. Sinc

Re: RFR 8047031: Need new tests to check socket permission

Amanda, I see you have implemented a getFreePort in this test, and it attempts to find a port within a range of 10 of the given port. I would have a concern about this when the test is run concurrently. Though we have come across similar issues in the past, as the socket permission needs to h

Re: Review request for CR 8049039 Need new tests for sun.securiy.x509 classes

Hi Vincent / Jason, Please review the updated webrev based on Jason's comments. webrev: http://cr.openjdk.java.net/~tyan/raghu/8049039/webrev02/ Thanks, Raghu Nair On 8/27/2014 9:43 AM, raghu k.nair wrote: Hi Jason, Thanks for

Re: Please review CR 8048356 Secure Random provider tests

Hi Brad, Could you please review the updated webrev : http://cr.openjdk.java.net/~tyan/raghu/8048356/webrev02/ Updates are based on Bernd's comments. Thanks, Raghu Nair On 8/27/2014 4:02 PM, raghu k.nair wrote: Hi Bernd, Thank

Re: Replace concat String to append in StringBuilder parameters

On Aug 27, 2014, at 10:07, Wang Weijun wrote: > Webrev updated again, this time include more changes. > > http://cr.openjdk.java.net/~weijun/8055723/client/webrev.02/ > http://cr.openjdk.java.net/~weijun/8055723/core/webrev.02/ The core part is updated again at http://cr.openjdk.java.net/

Re: Please review CR 8048356 Secure Random provider tests

Hi Bernd, Thanks for looking into it. my comments in-line. On 8/27/2014 2:57 PM, Bernd Eckenfels wrote: Hello, Since the topic is interesting to me I took a look. Have some nits or points to discuss: The testProvider() function seems to be missnamed, it actually checks the default Implementat

Re: The future of Serialization

On Aug 9, 2014, at 7:20 PM, Brian Goetz wrote: >> I've noticed there's not much interest in improving Serialization on >> these lists. This makes me wonder if java Serialization has lost >> relevance in recent years with the rise of protocol buffers apache >> thrift and other means of data tran

Re: Please review CR 8048356 Secure Random provider tests

Hello, Since the topic is interesting to me I took a look. Have some nits or points to discuss: The testProvider() function seems to be missnamed, it actually checks the default Implementation (for the right provider). Maybe testDefaultProvider()? i would also remove the elses, especially as

Please review CR 8048356 Secure Random provider tests

Hi Brad, Could you please help in reviewing the following test. webrev: http://cr.openjdk.java.net/~tyan/raghu/8048356/webrev01/ Bug : JDK-8048356 Thanks, Raghu Nair

RFR 8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss

Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8042900/webrev.00/ The purpose of this fix is to move com.sun.security.jgss (where the ExtendedGSSXXX classes reside) out of the java.security.jgss module, since it is openjdk-specific and not defined in Java SE. Thi