Re: RFR 8056141: Move com.sun.security.jgss into a new module

2014-08-28 Thread Mandy Chung
On 8/28/14 3:28 AM, Wang Weijun wrote: This is the sub-task of "8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss" that actually moves the files. Code changes include 2 parts: 1. For jdk9/dev repo: http://cr.openjdk.java.net/~weijun/8056141/webrev.00/ 2. F

Re: RFR 8056141: Move com.sun.security.jgss into a new module

2014-08-28 Thread Wang Weijun
On Aug 28, 2014, at 21:06, Alan Bateman wrote: > On 28/08/2014 14:02, Wang Weijun wrote: >> On Aug 28, 2014, at 18:52, Alan Bateman wrote: >> http://cr.openjdk.java.net/~weijun/8056141/webrev.00/ >>> Max - the main thing is that is missing in this is the update to >>> modules.xm

Re: RFR 8056141: Move com.sun.security.jgss into a new module

2014-08-28 Thread Alan Bateman
On 28/08/2014 14:02, Wang Weijun wrote: On Aug 28, 2014, at 18:52, Alan Bateman wrote: http://cr.openjdk.java.net/~weijun/8056141/webrev.00/ Max - the main thing is that is missing in this is the update to modules.xml, this is temporary document that is checked into the top-level repo

Re: RFR 8056141: Move com.sun.security.jgss into a new module

2014-08-28 Thread Wang Weijun
On Aug 28, 2014, at 18:52, Alan Bateman wrote: >> >> http://cr.openjdk.java.net/~weijun/8056141/webrev.00/ >> > > Max - the main thing is that is missing in this is the update to modules.xml, > this is temporary document that is checked into the top-level repo until > there is a module s

Re: RFR 8056141: Move com.sun.security.jgss into a new module

2014-08-28 Thread Chris Hegarty
On 28 Aug 2014, at 11:28, Wang Weijun wrote: > This is the sub-task of "8042900: Allow com.sun.security.jgss to be in > different module than org.ietf.jgss" that actually moves the files. > > Code changes include 2 parts: > > 1. For jdk9/dev repo: > > http://cr.openjdk.java.net/~weijun/8056

Re: RFR 8056141: Move com.sun.security.jgss into a new module

2014-08-28 Thread Alan Bateman
On 28/08/2014 11:28, Wang Weijun wrote: This is the sub-task of "8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss" that actually moves the files. Code changes include 2 parts: 1. For jdk9/dev repo: http://cr.openjdk.java.net/~weijun/8056141/webrev.00/ 2.

RFR 8056141: Move com.sun.security.jgss into a new module

2014-08-28 Thread Wang Weijun
This is the sub-task of "8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss" that actually moves the files. Code changes include 2 parts: 1. For jdk9/dev repo: http://cr.openjdk.java.net/~weijun/8056141/webrev.00/ 2. For jdk9/dev/jdk. It's just moving everythi

Re: RFR 8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss

2014-08-28 Thread Alan Bateman
On 28/08/2014 10:36, Wang Weijun wrote: : In fact, I have a question. Is there a way to run a test with a module invisible? I can try my tests by removing the com.sun.security.jgss classes manually but that won't work for automatic regression tests. There is requirement for launch-time config

Re: RFR 8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss

2014-08-28 Thread Wang Weijun
Hi Alan Thanks for the review. All suggestions accepted. Change for S4U2selfGSS is not related and can be reverted. In fact, I have a question. Is there a way to run a test with a module invisible? I can try my tests by removing the com.sun.security.jgss classes manually but that won't work fo

Re: RFR 8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss

2014-08-28 Thread Alan Bateman
On 27/08/2014 08:17, Wang Weijun wrote: Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8042900/webrev.00/ The purpose of this fix is to move com.sun.security.jgss (where the ExtendedGSSXXX classes reside) out of the java.security.jgss module, since it is openj