RFR: JDK-8047769 SecureRandom should be more frugal with file descriptors

2014-12-18 Thread Peter Levart
Hi, I propose a patch for the following issue: https://bugs.openjdk.java.net/browse/JDK-8047769 Here's the webrev: http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.01/ The patch uses a package-private FileInputStreamPool class that caches open

Re: [9] request for review 8044445: Create PKCS12 Keystores by Default

2014-12-18 Thread Vincent Ryan
Thanks for reviewing, Max. On 18 Dec 2014, at 06:52, Wang Weijun weijun.w...@oracle.com wrote: On Dec 18, 2014, at 07:58, Vincent Ryan vincent.x.r...@oracle.com wrote: FYI I’ve updated the webrev to include the changes below: http://cr.openjdk.java.net/~vinnie/805/webrev.05/

Re: [9] request for review 8044445: Create PKCS12 Keystores by Default

2014-12-18 Thread Wang Weijun
On Dec 18, 2014, at 22:12, Vincent Ryan vincent.x.r...@oracle.com wrote: Thanks for reviewing, Max. On 18 Dec 2014, at 06:52, Wang Weijun weijun.w...@oracle.com wrote: On Dec 18, 2014, at 07:58, Vincent Ryan vincent.x.r...@oracle.com wrote: FYI I’ve updated the webrev to include

Re: [9] Request for Review: 8046724: XML Signature ECKeyValue elements cannot be marshalled or unmarshalled

2014-12-18 Thread Sean Mullan
Just a few comments: - some of the methods (encodePoint, trimZeroes, ...) can be made private static. 451: if getCurveOid returns null, you should throw MarshalException instead of outputting a null Oid 486: if getECParameterSpec returns null, you should throw MarshalException (otherwise

Re: [9] request for review 8044445: Create PKCS12 Keystores by Default

2014-12-18 Thread Vincent Ryan
The smallest content I could generate using keytool was 200 bytes: a 1-byte password. 000 3082011b 02010330 81d60609 2a864886 020 f70d0107 01a081c8 0481c530 81c23081 040 bf06092a 864886f7 0d010701 a081b104 060 81ae3081 ab3081a8 060b2a86 4886f70d 100 010c0a01 05a05930 57060b2a

Re: [9] request for review 8044445: Create PKCS12 Keystores by Default

2014-12-18 Thread Vincent Ryan
On 18 Dec 2014, at 14:59, Wang Weijun weijun.w...@oracle.com wrote: On Dec 18, 2014, at 22:12, Vincent Ryan vincent.x.r...@oracle.com wrote: Thanks for reviewing, Max. On 18 Dec 2014, at 06:52, Wang Weijun weijun.w...@oracle.com wrote: On Dec 18, 2014, at 07:58, Vincent Ryan

Re: [9] request for review 8044445: Create PKCS12 Keystores by Default

2014-12-18 Thread Sean Mullan
On 12/17/2014 06:58 PM, Vincent Ryan wrote: FYI I’ve updated the webrev to include the changes below: http://cr.openjdk.java.net/~vinnie/805/webrev.05/ The updated webrev looks good. --Sean

Re: RFR: JDK-8047769 SecureRandom should be more frugal with file descriptors

2014-12-18 Thread Bradford Wetmore
Peter, Thanks for looking into this. I'll in the middle of reviewing your change (and TLR/SplittableRandom reply), but have several appointments over the next few days. But did want to respond to: sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.java: Make sure that when no