I'm looking at this version of the webrev.
http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.03/
I just assigned 8047769 to you. My username is wetmore, Alan is alanb.
On 12/24/2014 3:37 AM, Peter Levart wrote:
Looks like you have a committer status, will you
Looks fine.
Thanks
Max
> On Dec 30, 2014, at 08:40, Valerie Peng wrote:
>
>
> Can someone please help review this change? The fix is straightforward -
> remove the key length check inside the code for DSA related signatures.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8039921
> Webrev:
Can someone please help review this change? The fix is straightforward -
remove the key length check inside the code for DSA related signatures.
Bug: https://bugs.openjdk.java.net/browse/JDK-8039921
Webrev: http://cr.openjdk.java.net/~valeriep/8039921/webrev.00/
Thanks,
Valerie
Ok, will put it back tomorrow.
Regards,
Valerie
On 12/29/2014 2:59 PM, Amanda Jiang wrote:
Hi Valerie,
Thanks for reviewing this changeset, could you please sponsor this?
Regards,
Amanda
On 12/29/14 1:51 PM, Valerie Peng wrote:
Hi, Amanda,
Your changes look fine.
Thanks,
Valerie
On 9/9/20
Hi Valerie,
Thanks for reviewing this changeset, could you please sponsor this?
Regards,
Amanda
On 12/29/14 1:51 PM, Valerie Peng wrote:
Hi, Amanda,
Your changes look fine.
Thanks,
Valerie
On 9/9/2014 5:52 PM, Amanda Jiang wrote:
Hello,
Please help to review the changeset below, new t
Hi, Amanda,
Your changes look fine.
Thanks,
Valerie
On 9/9/2014 5:52 PM, Amanda Jiang wrote:
Hello,
Please help to review the changeset below, new tests are added
for javax.smartcardio.CommandAPDU, javax.smartcardio.ResponseAPDU
and javax.smartcardio.TerminalFactorySpi.
Bug - h
On 29/12/2014 09:45, Peter Levart wrote:
Thanks for looking at this, Alan.
You're right about File.getCanonicalFile(). It already checks read
permission for a file. The additional explicit check is superfluous. I
have removed it.
With explicit check I wanted the API to behave uniformly rega
On 12/29/2014 10:08 AM, Alan Bateman wrote:
On 24/12/2014 11:37, Peter Levart wrote:
Hi Brad,
Thanks for looking into this. Here's updated webrev:
http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.02/
This mostly looks good to me too, except the permission che
On 24/12/2014 11:37, Peter Levart wrote:
Hi Brad,
Thanks for looking into this. Here's updated webrev:
http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.02/
This mostly looks good to me too, except the permission checking. As I
read it, getInputStream uses get
