Re: RFR: JDK-8047769 SecureRandom should be more frugal with file descriptors

2015-01-21 Thread Peter Levart
Hi, I have pushed this change. Thanks Brad, Alan and Chris for reviews. Regards, Peter On 01/06/2015 08:52 PM, Bradford Wetmore wrote: I only looked at test, looks good to me. I'd rarely ask to remove extra prints in tests. It adds initial debugging data points in case something breaks down

Re: [9] request for review: 8049171: Additional tests for jarsigner's warnings

2015-01-21 Thread Wang Weijun
Thanks for adding so many tests. Some suggestions: - JarUtils.java You can use the new InputStream.transferTo() method. I am not sure if I understand updateJar correctly. It looks like srcJarFile is opened multiple times so its entries are duplicated a lot in the destination. Or is there a sec