Re: RFR: 8073108: GHASH Intrinsics

2015-02-16 Thread John Rose
Cool stuff. I'm glad to see SPARC xmulx getting some play. This is not a review, but I have a small and a big comment. You don't need the argument vmIntrinsics::ID id unless you are going to do something with it, such as expand one of a family of intrinsics covered by the same LCK::inline* rou

Re: RFR: 8073108: GHASH Intrinsics

2015-02-16 Thread Vladimir Kozlov
On 2/16/15 5:23 PM, David Holmes wrote: Hi Tony, Not a review as hotspot compiler folk need to review this. On 17/02/2015 7:11 AM, Anthony Scarpino wrote: Hi, I'm requesting a code review to intrinsify the GHASH operations for both x86 and SPARC platforms. This greatly increases performance

Re: RFR: 8073108: GHASH Intrinsics

2015-02-16 Thread David Holmes
Hi Tony, Not a review as hotspot compiler folk need to review this. On 17/02/2015 7:11 AM, Anthony Scarpino wrote: Hi, I'm requesting a code review to intrinsify the GHASH operations for both x86 and SPARC platforms. This greatly increases performance over software for AES/GCM crypto operatio

Re: RFR 8073113: sun/security/pkcs11/MessageDigest/TestCloning.java failed due to CloneNotSupportedException: SHA-256

2015-02-16 Thread Anthony Scarpino
On 02/16/2015 02:48 PM, Sean Mullan wrote: On 02/16/2015 02:57 PM, Anthony Scarpino wrote: FYI, the bug number should be JDK-8043951. The one I listed was the backport ID. The link below is still valid Normally, the bug in the comment above a problem list entry is the bug that remains open a

Re: RFR 8073113: sun/security/pkcs11/MessageDigest/TestCloning.java failed due to CloneNotSupportedException: SHA-256

2015-02-16 Thread Sean Mullan
On 02/16/2015 02:57 PM, Anthony Scarpino wrote: FYI, the bug number should be JDK-8043951. The one I listed was the backport ID. The link below is still valid Normally, the bug in the comment above a problem list entry is the bug that remains open and still needs to be fixed for the problem

Re: RFR 8072394: Performance improvement for X.509 certificate parsing

2015-02-16 Thread Sean Mullan
On 02/13/2015 03:16 PM, Florian Weimer wrote: On 02/13/2015 08:43 PM, Sean Mullan wrote: This fix looks fine, but I am trying to remember why a Set/LinkedHashSet was used in the first place, it seem like an List/ArrayList would have been more suitable. Even though PolicyInformation is an interna

RFR: 8073108: GHASH Intrinsics

2015-02-16 Thread Anthony Scarpino
Hi, I'm requesting a code review to intrinsify the GHASH operations for both x86 and SPARC platforms. This greatly increases performance over software for AES/GCM crypto operations, details are in the bug. The review is for two repos, hotspot and jdk: http://cr.openjdk.java.net/~ascarpino/8

Re: RFR 8073113: sun/security/pkcs11/MessageDigest/TestCloning.java failed due to CloneNotSupportedException: SHA-256

2015-02-16 Thread Anthony Scarpino
FYI, the bug number should be JDK-8043951. The one I listed was the backport ID. The link below is still valid On 02/16/2015 11:51 AM, Anthony Scarpino wrote: I'd like a review for adding this TestCloning.java to the ProblemList. This change is not because of a functional problem in Java, i

RFR 8073113: sun/security/pkcs11/MessageDigest/TestCloning.java failed due to CloneNotSupportedException: SHA-256

2015-02-16 Thread Anthony Scarpino
I'd like a review for adding this TestCloning.java to the ProblemList. This change is not because of a functional problem in Java, it's because testing continues to occur on unpatched Solaris 10 machines for this Solaris bug. The test will continue to run on Solaris 11, where the problem does

Re: RFR 8073182: keytool may generate duplicate extensions

2015-02-16 Thread Jason Uh
Hi Max, Not an official reviewer, but this looks good to me. Jason On 2/15/15 11:56 PM, Weijun Wang wrote: Please review the fix at http://cr.openjdk.java.net/~weijun/8073182/webrev.00/ This fix stores extensions inside CertificateExtensions using OID as key so there will never be a type

Re: [9] RFR: 8042967: Add variant of DSA Signature algorithms that do not ASN.1 encode the signature bytes

2015-02-16 Thread Jason Uh
Thanks Sean. Here it is with your suggested changes: http://cr.openjdk.java.net/~juh/8042967/04/ Opened an issue to track the docs changes: https://bugs.openjdk.java.net/browse/JDK-8073261 Jason On 02/16/2015 10:22 AM, Sean Mullan wrote: Hi Jason, Here are my comments - * General - please

Re: [9] RFR: 8042967: Add variant of DSA Signature algorithms that do not ASN.1 encode the signature bytes

2015-02-16 Thread Sean Mullan
Hi Jason, Here are my comments - * General - please open a corresponding issue to add these new algorithms to the "Standard Algorithm Names" and "Oracle Providers" security guides. File in the docs/guides component and add a "securitydocs" label. Please add a release-notes=yes label to the b