Re: JDK 9 RFR of javadoc typo in PKCS8EncodedKeySpec

2015-03-09 Thread joe darcy
Hi Jason, Thanks for the notification; I've closed out the open bug as a duplicate of the fixed one. Cheers, -Joe On 3/9/2015 7:13 PM, Jason Uh wrote: Hi Joe, Looks good to me. There actually is already a bug for this: https://bugs.openjdk.java.net/browse/JDK-8074673 Thanks for the fix,

Re: JDK 9 RFR of javadoc typo in PKCS8EncodedKeySpec

2015-03-09 Thread Jason Uh
Hi Joe, Looks good to me. There actually is already a bug for this: https://bugs.openjdk.java.net/browse/JDK-8074673 Thanks for the fix, Jason On 3/9/15 5:56 PM, joe darcy wrote: Hello, When doing a JDK docs build, I noticed a javadoc warning is reported for PKCS8EncodedKeySpec; the type i

Re: JDK 9 RFR of javadoc typo in PKCS8EncodedKeySpec

2015-03-09 Thread Xuelei Fan
Looks fine to me. Thanks! Xuelei On 3/10/2015 8:56 AM, joe darcy wrote: > Hello, > > When doing a JDK docs build, I noticed a javadoc warning is reported for > PKCS8EncodedKeySpec; the type is missing the "code" in a {@code ...} tag. > > Patch below. Upon successful review, I'll file a bug. >

JDK 9 RFR of javadoc typo in PKCS8EncodedKeySpec

2015-03-09 Thread joe darcy
Hello, When doing a JDK docs build, I noticed a javadoc warning is reported for PKCS8EncodedKeySpec; the type is missing the "code" in a {@code ...} tag. Patch below. Upon successful review, I'll file a bug. Thanks, -Joe diff -r 439cf0adaf29 src/java.base/share/classes/java/security/spec/P

Re: Code review of JDK-8072385, Only the first DNSName entry is checked for endpoint identification

2015-03-09 Thread Xuelei Fan
Ping ... wbrev: http://cr.openjdk.java.net/~xuelei/8072385/webrev.00/ On 3/4/2015 10:51 PM, Xuelei Fan wrote: > Hi, > > Please review the fix for: >https://bugs.openjdk.java.net/browse/JDK-8072385 > > In SunJSSE implementation, during endpoint identification, there is a > bug in SubjectAlte

Re: RFR: JDK-8074096 Disable (most) native warnings in JDK on a per-library basis

2015-03-09 Thread Erik Joelsson
Thanks, looks good! /Erik On 2015-03-06 17:14, Magnus Ihse Bursie wrote: On 2015-03-04 14:31, Erik Joelsson wrote: Hello, Really nice to finally see this patch getting done! Only one comment: flags.m4: In the grep expression, could you move the extra [] outside of the actual command line o

Re: [9] RFR: 8073430: Deprecate security APIs that have been superseded

2015-03-09 Thread Wang Weijun
Code change looks fine. Thanks Max > On Mar 7, 2015, at 13:05, Jason Uh wrote: > > While these methods are going to be removed soon anyway, @Deprecated actually > seems like the more appropriate choice because we do want to discourage use > of these methods, even if they are non-public APIs.