My personal 0.02.
First, my overall reaction to this is pretty much the same as my reaction to
the GSSException change proposed in the rfc5653bis draft: I believe that this
aspect of 2853 / 5653 isn't broken and so I'm leery of "fixing" it -- but I
don't feel strongly about it and I don't real
Please review this change to remove the "Reverse" CertPathBuilder mode,
which has never been supported and is undocumented.
webrev: http://cr.openjdk.java.net/~juh/7194452/00/
bug: https://bugs.openjdk.java.net/browse/JDK-7194452
Thanks,
Jason
Hi Xuelei, this looks good to me.
--Jamil
On 3/9/2015 10:52 PM, Xuelei Fan wrote:
On 3/10/2015 12:27 PM, Jamil Nimeh wrote:
Hi Xuelei, I can't be an official reviewer, but I did look over the code
and it looks pretty good to me.
I think it is OK to push if you reviewed the code.
I did have
On 3/20/15 7:39 AM, Wang Weijun wrote:
Please review the code changes at
http://cr.openjdk.java.net/~weijun/8047789/webrev.03/
It looks okay to me. Removing some use of reflection seems
a good thing.
One observation: invoke(String methodName) now calls the method
statically and the imple
On 20/03/2015 14:39, Wang Weijun wrote:
Please review the code changes at
http://cr.openjdk.java.net/~weijun/8047789/webrev.03/
LoginContext is updated to use ServiceLoader to load configured LoginModules,
and fallback to reflection if it cannot find one. Please notice that the fix
does n
Please review the code changes at
http://cr.openjdk.java.net/~weijun/8047789/webrev.03/
LoginContext is updated to use ServiceLoader to load configured LoginModules,
and fallback to reflection if it cannot find one. Please notice that the fix
does not include configuration of existing LoginM
Yes, please push it.
8048147: Privilege tests with JAAS Subject.doAs
Reviewed-by: weijun
My username is asmotrak
http://openjdk.java.net/census#asmotrak
Artem
On 03/20/2015 10:38 AM, Wang Weijun wrote:
I see no problem now.
Would you like me to push it for you? Please provide me the changes
I see no problem now.
Would you like me to push it for you? Please provide me the changeset comment
you want to use.
Thanks
Max
> On Mar 20, 2015, at 14:49, Artem Smotrakov wrote:
>
> Hi Max,
>
> Please see inline.
>
> On 03/19/2015 05:33 PM, Wang Weijun wrote:
>> This looks fine.
>>
>> On
