On 03/27/2015 03:53 AM, Wang Weijun wrote:
On Mar 27, 2015, at 06:37, Jason Uh wrote:
Please review this revision:
http://cr.openjdk.java.net/~juh/7145757/01/
* a global nameCache is maintained in OIDMap as suggested
Can you just use the existing OIDMap.getId() method? It looks like your
On 3/26/15 9:18 PM, Wang Weijun wrote:
JarSignerException.ErrorCode - do you expect the caller will want
to process error handling differently with different type of error?
I wonder if the error message would be good enough wrapping the
Throwable cause.
Yes, I agree a ctor with arguments (mess
Brad,
you're correct. The debug flag for pkcs11 is enabled via
java.security.debug=pkcs11 - I'll update the bug synopsis. The changeset
has already been pushed though.
regards,
Sean.
On 27/03/2015 19:27, Bradford Wetmore wrote:
Sean,
Is this a java.security.debug or a javax.net.debug issue
Sean,
Is this a java.security.debug or a javax.net.debug issue as mentioned in
the synopsis? It imports from sun.security.util.Debug, which is
java.security.debug, not javax.net.debug.
In the bug, both variables were set.
...deleted...
-Djavax.net.debug=ssl,handshake,record,keygen,session,d
Thanks Sean. Yes - I'll add those braces before pushing.
regards,
Sean.
On 27/03/2015 18:58, Sean Mullan wrote:
This looks fine, just one comment. Can you put braces around the if
debug statement on lines 117-118 (just to be safe).
--Sean
On 03/25/2015 09:52 AM, Seán Coffey wrote:
This issu
This looks fine, just one comment. Can you put braces around the if
debug statement on lines 117-118 (just to be safe).
--Sean
On 03/25/2015 09:52 AM, Seán Coffey wrote:
This issue was reported while debugging a pkcs11 issue. While I can't
reproduce it, the captured stack trace does show a dea
> On Mar 27, 2015, at 06:37, Jason Uh wrote:
>
> Please review this revision:
> http://cr.openjdk.java.net/~juh/7145757/01/
>
> * a global nameCache is maintained in OIDMap as suggested
Can you just use the existing OIDMap.getId() method? It looks like your
getCachedOid(name) is the same as g
