Re: JDK 9 RFR of JDK-8078334: Mark regression tests using randomness

On 24/04/2015 02:54, Joseph D. Darcy wrote: Hello, Any additional comments on marking with tests in question with a "randomness" keyword? Thanks, -Joe I don't object to this keyword although I should say that most of the (apparent) randomness that I've seen hasn't been because of tests usi

RFR 8078495: End time checking for native TGT is wrong

Hi All Please review a fix at http://cr.openjdk.java.net/~weijun/8078495/webrev.00 which is essentially GetSystemTimeAsFileTime(&Now); EndTime.dwLowDateTime = msticket->EndTime.LowPart; EndTime.dwHighDateTime = msticket->EndTime.HighPart; -

Re: JDK 9 RFR of JDK-8078334: Mark regression tests using randomness

Hello, Any additional comments on marking with tests in question with a "randomness" keyword? Thanks, -Joe On 4/21/2015 7:13 PM, Joseph D. Darcy wrote: Hello, As the next step of implementing "Proposed new policies for JDK 9 regression tests: tiered testing, intermittent failures, and ra

Re: JDK 9 RFR of JDK-8078468: Update security libraries to use diamond with anonymous classes

Hi Max, On 4/23/2015 5:33 PM, Weijun Wang wrote: Hi Joe The changes look good. I remember last time when Stuart updated JDK to use diamond there was a rule that if the assignment of a variable is a little far from its definition, then we don't use diamond. It seems we are not obeying it any

Re: JDK 9 RFR of JDK-8078468: Update security libraries to use diamond with anonymous classes

Hi Joe The changes look good. I remember last time when Stuart updated JDK to use diamond there was a rule that if the assignment of a variable is a little far from its definition, then we don't use diamond. It seems we are not obeying it anymore? Thanks Max On 4/24/2015 6:34 AM, Joseph D.

[9] RFR 8038084: CertStore needs a way to add new CertStore types

Hi Sean, Can you please review the following fix? Besides the new API and provider, I have also updated LDAPCertStoreParameters to mention the new URICertStoreParameters class per your suggestions. 8038084: CertStore needs a way to add new CertStore types Webrev: http://cr.openjdk.java.net/~v

JDK 9 RFR of JDK-8078468: Update security libraries to use diamond with anonymous classes

Hello, Please review the straightforward changes to address JDK-8078468: Update security libraries to use diamond with anonymous classes http://cr.openjdk.java.net/~darcy/8078468.0/ This patch combines two kinds of updates; the first to use traditional diamond available since JDK 7 a

Re: [9] RFR 8076535: Deprecate the com.sun.jarsigner package

This looks fine but you should wait until JDK-8078318 (Public API for jarsigner) is resolved, and then change the places where it says "{@code JarSigner}" to an "{@link JarSigner}" (using the correct package name/syntax). Add an "is blocked by" link. Also a few other comments: 1. Add a noreg

Re: Kerberos Bug Introduced in d777e2918a77?

Hi all, FYI We just tried switching to Oracle JRE u45, and the same behaviour is exhibited there. This is a bit of a problem for my client, as they can't use Java and Kerberos whilst still being able to satisfy their security department's policy regarding zero-day bugs. If a new patch gets releas

Re: Kerberos Bug Introduced in d777e2918a77?

Hi all, Thanks to everyone taking the time to look into this. Before I get into the detail of the technical issue, can anyone postulate as to *how quickly fixes tend to make it into releases of OpenJDK*? Are we talking days, weeks, or months? I'm just trying to advise my client on the best mitiga

RFR [9] 8078528: clean out tidy warnings from security.auth

Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8078528/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8078528 Just some HTML markup cleanup for docs. Thanks, Alexander

Re: Kerberos Bug Introduced in d777e2918a77?

Hi Daniel Sorry for the trouble. On 4/23/2015 7:25 PM, Daniel Jones wrote: Hi all, Thanks to everyone taking the time to look into this. Before I get into the detail of the technical issue, can anyone postulate as to *how quickly fixes tend to make it into releases of OpenJDK*? Are we talking

Re: RFR 8072394: java.security.cert.PolicyQualifierInfo needs value-based equality

On 04/06/2015 04:18 PM, Florian Weimer wrote: On 03/04/2015 06:47 PM, Sean Mullan wrote: I can take care of filing an internal CCC and will let you know when that is approved or if there are any questions. This new webrev incorporates feedback from the CCC:

Re: [9] RFR: 8075007: Additional tests for krb5-related cipher suites with unbound server

Agree. Please see an updated webrev: http://cr.openjdk.java.net/~asmotrak/8075007/webrev.02/ Artem On 04/23/2015 11:18 AM, Weijun Wang wrote: One question: As for the 3 boolean flags you added to KDC.java (BTW, maybe "consumer"?), is it possible to wait for them to be true right at the end

Re: [9] RFR: 8048138: Tests for JAAS callbacks

All codes fine. Thanks Max On 4/23/2015 2:18 PM, Artem Smotrakov wrote: Hi Max, Please see inline. On 04/22/2015 06:24 PM, Weijun Wang wrote: Hi Artem In StandardCallbacks.java, you provide an array of callbacks with an unsupported one at the end, hoping all supported ones are processed bef

Re: [9] RFR: 8075007: Additional tests for krb5-related cipher suites with unbound server

One question: As for the 3 boolean flags you added to KDC.java (BTW, maybe "consumer"?), is it possible to wait for them to be true right at the end of the startServer() method? I believe all the current tests can actually benefit from this. --Max On 4/23/2015 2:30 PM, Artem Smotrakov wrote