Re: [9] RFR: 8058543: Certificate returns NULL Subject Alternative Name if it is in X400Address type

2015-05-04 Thread Weijun Wang
Looks fine. Thanks Max On 5/5/2015 8:49 AM, Jason Uh wrote: Please review this fix, which enables parsing of X400Address-type Subject Alternative Names. webrev: http://cr.openjdk.java.net/~juh/8058543/00/ bug: https://bugs.openjdk.java.net/browse/JDK-8058543 Jason

[9] RFR: 8058543: Certificate returns NULL Subject Alternative Name if it is in X400Address type

2015-05-04 Thread Jason Uh
Please review this fix, which enables parsing of X400Address-type Subject Alternative Names. webrev: http://cr.openjdk.java.net/~juh/8058543/00/ bug: https://bugs.openjdk.java.net/browse/JDK-8058543 Jason

Re: RFR: JDK-8075706 : Policy implementation does not allow policy.provider to be on the class path

2015-05-04 Thread Sean Mullan
On 05/04/2015 10:55 AM, Alan Bateman wrote: On 01/05/2015 13:48, Sean Mullan wrote: Please review this change to use the system class loader to locate a policy provider specified with the policy.provider security property. The current implementation tries to load the provider using the extension

Re: RFR: JDK-8075706 : Policy implementation does not allow policy.provider to be on the class path

2015-05-04 Thread Sean Mullan
On 05/04/2015 01:15 PM, Mandy Chung wrote: On 05/04/2015 05:31 AM, Sean Mullan wrote: CustomPolicy.implies 50 if (pd == policyPd) { 51 return true; 52 } This is okay for the test. Just for my understanding, for real world custom policy, should it check

Re: RFR: JDK-8075706 : Policy implementation does not allow policy.provider to be on the class path

2015-05-04 Thread Mandy Chung
On 05/04/2015 05:31 AM, Sean Mullan wrote: CustomPolicy.implies 50 if (pd == policyPd) { 51 return true; 52 } This is okay for the test. Just for my understanding, for real world custom policy, should it check the code source in case the sensitive opera

Re: RFR: JDK-8075706 : Policy implementation does not allow policy.provider to be on the class path

2015-05-04 Thread Alan Bateman
On 01/05/2015 13:48, Sean Mullan wrote: Please review this change to use the system class loader to locate a policy provider specified with the policy.provider security property. The current implementation tries to load the provider using the extension class loader. This will no longer work whe

Re: RFR: JDK-8075706 : Policy implementation does not allow policy.provider to be on the class path

2015-05-04 Thread Sean Mullan
On 05/01/2015 12:33 PM, Mandy Chung wrote: On 05/01/2015 05:48 AM, Sean Mullan wrote: Please review this change to use the system class loader to locate a policy provider specified with the policy.provider security property. The current implementation tries to load the provider using the exten

Re: [9] request for review 8079129: NullPointerException in PKCS#12 Keystore in PKCS12KeyStore.java

2015-05-04 Thread Weijun Wang
1662 for (int i = 0; i < chainLen; i++) { On 5/4/2015 6:08 PM, Vincent Ryan wrote: Which line? On 2 May 2015, at 02:22, Weijun Wang wrote: Is it safe to just run for-each on certs (if it's not null)? --Max On 5/2/2015 6:39 AM, Vincent Ryan wrote: Please review this fix to cor

Re: [9] request for review 8079129: NullPointerException in PKCS#12 Keystore in PKCS12KeyStore.java

2015-05-04 Thread Vincent Ryan
Which line? > On 2 May 2015, at 02:22, Weijun Wang wrote: > > Is it safe to just run for-each on certs (if it's not null)? > > --Max > > On 5/2/2015 6:39 AM, Vincent Ryan wrote: >> Please review this fix to correct the PKCS12 encoding when a secret key is >> being stored in one keystore entry

Re: RFR 8078495: End time checking for native TGT is wrong

2015-05-04 Thread Xuelei Fan
Looks fine to me. Xuelei On 5/4/2015 5:21 PM, Weijun Wang wrote: > Ping again. > > On 4/24/2015 11:29 AM, Weijun Wang wrote: >> Hi All >> >> Please review a fix at >> >> http://cr.openjdk.java.net/~weijun/8078495/webrev.00 >> >> which is essentially >> >> GetSystemTimeAsFileTim

Re: RFR 8078495: End time checking for native TGT is wrong

2015-05-04 Thread Weijun Wang
Ping again. On 4/24/2015 11:29 AM, Weijun Wang wrote: Hi All Please review a fix at http://cr.openjdk.java.net/~weijun/8078495/webrev.00 which is essentially GetSystemTimeAsFileTime(&Now); EndTime.dwLowDateTime = msticket->EndTime.LowPart; EndTim

Re: [9] RFR: 8076486: javax/security/auth/Subject/doAs/NestedActions.java fails if extra VM options are given

2015-05-04 Thread Weijun Wang
Artem If a string starts with whitespace(s), the first element of split("\\s+") will be an empty string. If you can be sure JAVA_OPTS does not have them, your code change is fine. Thanks Max On 4/29/2015 11:44 PM, Artem Smotrakov wrote: Hi Max, These fancy things sometimes make me forget a