Re: [9] RFR: 8049237: Need new tests for X509V3 certificates

Hi Rajan, Sorry for the delay. The code looks fine to me. I was just wondering, what's the purpose for the V1toV3Cert.java test? Is it practice behavior? Thanks, Xuelei On 7/15/2015 9:37 AM, Rajan Halade wrote: > May I request you to review two new tests added. V1toV3Cert tries to > covert a

Re: [9] review request for JDK-8050460: JAAS login/logout tests with LoginContext

Looks fine to me. Xuelei On 8/10/2015 8:57 PM, Svetlana Nikandrova wrote: > Hello, > > Please review tests for login/logout with LoginContex. > > Webrev: http://cr.openjdk.java.net/~asmotrak/sweta/8050460/webrev.00/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8050460 > > Thanks, > Svetlana

Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

Ok, thanks! Valerie On 8/18/2015 12:34 AM, Erik Joelsson wrote: One is enough. /Erik On 2015-08-18 02:21, Valerie Peng wrote: Thanks for the review. Is one more reviewer from build team needed? Valerie On 8/14/2015 4:58 PM, Mandy Chung wrote: Looks good. Mandy On Aug 14, 2015, at 4:30 PM,

[9] code review request for 8130799: KeyStoreSpi.engineProbe does not throw the expected NullPointerException

Please review this trivial change to the KeyStoreSpi.engineProbe method so that it matches its specification wrt NPE. Thanks. Bug: https://bugs.openjdk.java.net/browse/JDK-8130799 Webrev: http://cr.openjdk.java.net/~vinnie/8130799/webrev.00/

RFR [9] 8133802: replace some tags (obsolete in html5) in security-libs docs

Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8133802/webrev.00 for https://bugs.openjdk.java.net/browse/JDK-8133802 Just another portion of deprecated tags replaced with {@code } (some tags were replaced as well). Thanks, Alexander

Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

One is enough. /Erik On 2015-08-18 02:21, Valerie Peng wrote: Thanks for the review. Is one more reviewer from build team needed? Valerie On 8/14/2015 4:58 PM, Mandy Chung wrote: Looks good. Mandy On Aug 14, 2015, at 4:30 PM, Valerie Peng wrote: Updated the webrev in place to use "osxse