Rajan,
TestCipher.java
1) this class is used as the base for many algorithm, modes, and
paddings. But then it hardcodes some values or parameter types which may
not work against some algorithms, e.g. IvParameterSpec with 8-byte
value, padding length being 8 bytes. PAD_LEN=8 vs PAD_BYTES=16, is
Rajan,
I have some comments and will send u later today.
Please hold off the integration of this for a little bit.
Thanks,
Valerie
On 8/19/2015 12:46 AM, Xuelei Fan wrote:
Looks fine to me.
Xuelei
On 7/15/2015 4:27 AM, Rajan Halade wrote:
May I request you to review new tests added to check
Please review this fix for an intermittently failing test. It now expects a
SocketException or a SocketTimeoutException.
Thanks.
Bug: https://bugs.openjdk.java.net/browse/JDK-8132786
Webrev: http://cr.openjdk.java.net/~vinnie/8132786/webrev.00/
Thanks Xuelei, I’ll add that message.
> On 19 Aug 2015, at 16:56, Xuelei Fan wrote:
>
> Looks fine to me. Don't you want to add a exception message to indicate
> the input stream is null?
>
> Xuelei
>
> On 8/18/2015 7:23 PM, Vincent Ryan wrote:
>> Please review this trivial change to the KeyS
Looks fine to me. Don't you want to add a exception message to indicate
the input stream is null?
Xuelei
On 8/18/2015 7:23 PM, Vincent Ryan wrote:
> Please review this trivial change to the KeyStoreSpi.engineProbe method
> so that it matches its specification wrt NPE.
> Thanks.
>
> Bug: https:/
Looks fine to me.
Xuelei
On 7/15/2015 4:27 AM, Rajan Halade wrote:
> May I request you to review new tests added to check Cipher operations
> with different algorithms and modes.
>
> Webrev: http://cr.openjdk.java.net/~rhalade/8048601/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-80
