RFR 8134555: The InquireSecContextPermissionCheck.java test was mistakenly removed

2015-08-26 Thread Weijun Wang
Please review http://cr.openjdk.java.net/~weijun/8134555/webrev.00/ The test was mistakenly removed in a previous changeset. Restored now. Thanks Max

Re: [9] RFR: 8049237: Need new tests for X509V3 certificates

2015-08-26 Thread Rajan Halade
Hi Sean, On 8/26/15 8:39 AM, Sean Mullan wrote: This looks ok now, although I would probably eliminate the tests for SHA-1 and bump up the keysize to 2048, so that this test won't have to be updated when those algorithms/keysizes are constrained in the future. I would take up other enhancements

Re: RFR 8077670: sun/security/krb5/auto/MaxRetries.java may fail with BindException

2015-08-26 Thread Chris Hegarty
> On 26 Aug 2015, at 16:56, Weijun Wang wrote: > > Great it works for me. > > Webrev updated at http://cr.openjdk.java.net/~weijun/8077670/webrev.01/. Looks good to me Max. -Chris. > Thanks > Max > > On 08/26/2015 10:11 PM, Weijun Wang wrote: >> Hi Chris >> >> I don't know about that metho

[9] Request for review 8134112: api/java_security/KeyStore/index.html#GetInstance2Tests[getInstanceIOE2, getInstanceIOE3] still fail after JDK-8130850 is fixed in b77

2015-08-26 Thread Vincent Ryan
Please review this change to the KeyStore.getInstance(File,LoadStoreParameter) method to correctly handle its LoadStoreParameter argument. It now extracts the embedded password before calling the KeyStore.load(InputStream,char[]) method. This fix corrects a JCK test that had been failing. Thanks

Re: RFR 8077670: sun/security/krb5/auto/MaxRetries.java may fail with BindException

2015-08-26 Thread Weijun Wang
Great it works for me. Webrev updated at http://cr.openjdk.java.net/~weijun/8077670/webrev.01/. Thanks Max On 08/26/2015 10:11 PM, Weijun Wang wrote: Hi Chris I don't know about that method. Will try. This test is trying to start a UDP server that does nothing so that its client receives nei

Re: [9] RFR: 8049237: Need new tests for X509V3 certificates

2015-08-26 Thread Sean Mullan
This looks ok now, although I would probably eliminate the tests for SHA-1 and bump up the keysize to 2048, so that this test won't have to be updated when those algorithms/keysizes are constrained in the future. --Sean On 08/25/2015 02:30 PM, Rajan Halade wrote: On 8/25/15 10:09 AM, Sean M

Check for potential buffer overflow in ecdecode.c ??

2015-08-26 Thread Langer, Christoph
Hi, when running coverity checks on src/jdk.crypto.ec/share/native/libsunec/impl/ecdecode.c we had a finding that potentially the buffer "genenc" in function "gf_populate_params" could be exceeded as the length of input strings for the strcat operations is not checked. A check to satisfy cover

Re: RFR 8077670: sun/security/krb5/auto/MaxRetries.java may fail with BindException

2015-08-26 Thread Weijun Wang
Hi Chris I don't know about that method. Will try. This test is trying to start a UDP server that does nothing so that its client receives neither a PortUnreachableException nor a valid reply and can only timeout. Thanks Max On 08/26/2015 04:05 PM, Chris Hegarty wrote: Hi Max, I don't kno

Re: RFR 8077670: sun/security/krb5/auto/MaxRetries.java may fail with BindException

2015-08-26 Thread Chris Hegarty
Hi Max, I don't know the specifics of this test, but can it use the ephemeral port pattern, ds = new DatagramSocket(); ds.getLocalPort()? Rather than looping. -Chris. On 26/08/15 08:57, Weijun Wang wrote: Please take a look at http://cr.openjdk.java.net/~weijun/8077670/webrev.00/ The

RFR 8077670: sun/security/krb5/auto/MaxRetries.java may fail with BindException

2015-08-26 Thread Weijun Wang
Please take a look at http://cr.openjdk.java.net/~weijun/8077670/webrev.00/ The test now tries to find an available port in a loop. Thanks Max