Hello all,
I've removed the CertAttrSet interface from OCSPNonceExtension and
trimmed away a few unneeded methods. As a result the class is immutable
now.
JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8134364
Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8134364/webrev.01
Thanks,
-
Ok, looks good.
Thanks,
Valerie
On 8/25/2015 1:10 PM, Rajan Halade wrote:
Hi Valerie,
Thanks for comments! I have fixed all of them.
http://cr.openjdk.java.net/~rhalade/8048601/webrev.01/
- Rajan
On 8/20/15 4:19 PM, Valerie Peng wrote:
Rajan,
Here are some comments for the other half of th
Hi Tristan,
Mostly fine, just 2 more nits:
1) KeySizeTest: the @test and @bug are still on the same line.
2) SpecTest.java: the @run command from line 40 - 45 still have the old
name, e.g. KeyModulusTest? I think u need to match them.
Thanks,
Valerie
On 8/20/2015 9:31 AM, Tristan Yan wrote:
T
On 08/28/2015 10:53 AM, Pete Brunet wrote:
On 8/27/15 10:04 PM, Mandy Chung wrote:
>Yes one review is enough to push to jdk9/dev (until later in the development
cycle).
>
>Your change looks fine to me. What about the question Sean asked about
CheckPackageMatching? I think that test is passi
On 8/27/15 10:04 PM, Mandy Chung wrote:
> Yes one review is enough to push to jdk9/dev (until later in the development
> cycle).
>
> Your change looks fine to me. What about the question Sean asked about
> CheckPackageMatching? I think that test is passing.
Sean/Mandy, Is there someone who wo
