Re: RFR 8056174: New APIs for jar signing

2015-08-31 Thread Weijun Wang
Updated a little: rewrite of jarsigner tool itself using the JarSigner API included. Still at the same URL below. --Max On 08/24/2015 09:56 PM, Weijun Wang wrote: Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8056174/webrev.02/ A new JarSigner public API is i

[9] RFR 8133801: sun/security/pkcs11/Provider/ConfigShortPath.java failed in jigsaw nightly at Windows

2015-08-31 Thread Valerie Peng
Hi, Can someone please help reviewing this regression test update? http://cr.openjdk.java.net/~valeriep/8133801/webrev.00/ Both tests are updated to not using private SunPKCS11 constructors. The test Absolute.java has been updated in Jigsaw workspace, so I just matched the copy in JDK workspac

Re: [9] RFR: 8049237: Need new tests for X509V3 certificates

2015-08-31 Thread Sean Mullan
On 08/27/2015 07:52 PM, Rajan Halade wrote: On 8/27/15 4:43 AM, Sean Mullan wrote: I don't think the different signature variants buy you much, since what you are mainly testing here is the ability to parse the created certificate without errors. I would simplify the test by just having a single

Re: 8130800: KeyStore.getInstance(File, char[]) does not throw IOE for null password

2015-08-31 Thread Vincent Ryan
Thanks Max. > On 31 Aug 2015, at 10:02, Weijun Wang wrote: > > This looks good. > > Thanks > Max > > On 08/31/2015 04:58 PM, Vincent Ryan wrote: >> Please review this spec change in java.security.KeyStore to clarify that a >> keystore integrity check is not performed when a null password is s

Re: 8130800: KeyStore.getInstance(File, char[]) does not throw IOE for null password

2015-08-31 Thread Weijun Wang
This looks good. Thanks Max On 08/31/2015 04:58 PM, Vincent Ryan wrote: Please review this spec change in java.security.KeyStore to clarify that a keystore integrity check is not performed when a null password is supplied. Thanks. Webrev: http://cr.openjdk.java.net/~vinnie/8130800/webrev.00/

8130800: KeyStore.getInstance(File, char[]) does not throw IOE for null password

2015-08-31 Thread Vincent Ryan
Please review this spec change in java.security.KeyStore to clarify that a keystore integrity check is not performed when a null password is supplied. Thanks. Webrev: http://cr.openjdk.java.net/~vinnie/8130800/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8130800