Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

2015-09-29 Thread Wang Weijun
Can you describe if there is any effect on signed jars? Including: 1. Will jarsigner be able to sign such a jar? Are all items inside signed? If you sign a jar using jarsigner from different versions of JDK, will there be any difference? 2. Will jarsigner be able to verify such a jar? Will it o

Re: RFR 8056174: New APIs for jar signing

2015-09-29 Thread Wang Weijun
> On 2015年9月30日, at 上午10:46, Mandy Chung wrote: > > >> On Sep 28, 2015, at 4:34 PM, Weijun Wang wrote: >> >>> >>> Function: are you missing an @modules tag for the jarsigner module? >> >> Which one? I thought @modules is only used if you want to call non-exported >> classes. > > @modules

Re: RFR 8056174: New APIs for jar signing

2015-09-29 Thread Mandy Chung
> On Sep 28, 2015, at 4:34 PM, Weijun Wang wrote: > >> >> Function: are you missing an @modules tag for the jarsigner module? > > Which one? I thought @modules is only used if you want to call non-exported > classes. @modules can also be used to specify which modules this test requires that

Re: RFR 8056174: New APIs for jar signing

2015-09-29 Thread Wang Weijun
> On 2015年9月30日, at 上午2:36, Mike StJohns wrote: > > The first and probably most important is that you can't/shouldn't pick the > default signature algorithm solely based on the key type, but instead on the > key type and strength. Great. I'll pick up your suggested code. Thanks Max

Re: RFR: 8129988: JSSE should create a single instance of the cacerts KeyStore

2015-09-29 Thread Xuelei Fan
private synchronized static KeyStore getDefaultCacertsKeyStore() --- private synchronized static KeyStore getDefaultCacertsKeyStore( String javaHome, String type, St

Re: RFR 8056174: New APIs for jar signing

2015-09-29 Thread Mike StJohns
Sorry for the late comment here - On 9/28/2015 7:34 PM, Weijun Wang wrote: On 9/29/2015 3:27 AM, Sean Mullan wrote: Looks good, just a couple of comments: AlgorithmId: can you use braces around the conditional statements on lines 1008-1017? OK. I had a few issues with how this was coded.

RFR: 8129988: JSSE should create a single instance of the cacerts KeyStore

2015-09-29 Thread Sean Mullan
Please review this fix to modify the TrustManagerFactory implementation to create a single instance of the cacerts or jssecacerts KeyStore. This significantly improves performance in a multithreaded environment. The code has been refactored a bit to move common code into a few private methods.

Re: OCSP clock skew configuration

2015-09-29 Thread Jamil Nimeh
Hi Usha, you might try setting the System property com.sun.security.ocsp.clockSkew. It takes an integer value for the clock skew in seconds. Give that a try and let me know how that works out. --Jamil On 09/29/2015 06:49 AM, Seshadri, Usha wrote: Hi, The following bug reports seems to ind

Re: TLS ALPN Proposal v5

2015-09-29 Thread David M. Lloyd
Hi Brad, thanks for replying; comments are inline: On 09/28/2015 08:40 PM, Bradford Wetmore wrote: Several comments about David's proposal: 1. Only the initial ClientHellos are parsable. === The biggest problem I have with an Explorer-based design i

Re: [9] RFR 8136600: sun/security/krb5/auto/tools/KinitConfPlusProps.java test intermittently fails because PortUnreachableException is missing

2015-09-29 Thread Artem Smotrakov
Hi Max, I observed SocketTimeoutException on Windows only, but I suppose it can happen on other platforms. Artem On 09/29/2015 05:49 PM, Wang Weijun wrote: Looks fine. Is it Mac or Windows? Is it a SocketTimeoutException? Thanks Max On 2015年9月29日, at 下午10:01, Artem Smotrakov wrote: Hel

Re: [9] RFR 8136600: sun/security/krb5/auto/tools/KinitConfPlusProps.java test intermittently fails because PortUnreachableException is missing

2015-09-29 Thread Wang Weijun
Looks fine. Is it Mac or Windows? Is it a SocketTimeoutException? Thanks Max > On 2015年9月29日, at 下午10:01, Artem Smotrakov wrote: > > Hello, > > Please review this small test fix for > https://bugs.openjdk.java.net/browse/JDK-8136600 > > The test runs kinit, and expects PortUnreachableExcept

[9] RFR 8136600: sun/security/krb5/auto/tools/KinitConfPlusProps.java test intermittently fails because PortUnreachableException is missing

2015-09-29 Thread Artem Smotrakov
Hello, Please review this small test fix for https://bugs.openjdk.java.net/browse/JDK-8136600 The test runs kinit, and expects PortUnreachableException because of wrong KDC port number specified. It seems that other exceptions may be thrown as well. That may depend on platform where the test

OCSP clock skew configuration

2015-09-29 Thread Seshadri, Usha
Hi, The following bug reports seems to indicate the OCSP validation code should permit clock skew when checking the validity of OCSP responses. 1. JDK-674888 (Bug - affected version 6u11) 2. JDK-2166696 (Backport - fixed version 6u10 (b32) 3. JDK-2186994 (Backport - fixed versio

Re: RFR 8056174: New APIs for jar signing

2015-09-29 Thread Sean Mullan
Function: are you missing an @modules tag for the jarsigner module? Which one? I thought @modules is only used if you want to call non-exported classes. Ok, never mind then. Options.java: why not use the JarSigner API here instead of the jarsigner tool? This test is to make sure jarsigne