Re: RFR 8085904: Test timeout on Mac

2015-10-08 Thread Wang Weijun
> On Oct 9, 2015, at 7:50 AM, Bradford Wetmore > wrote: > > That look ok. > > I'm assuming this change won't cause problems on Windows that don't have a > /tmp? I'm guessing not, since /home likely doesn't exist either on Windows. I believe so. > JRPT runs ok? Yes. The Mac test shows al

Re: RFR 8085904: Test timeout on Mac

2015-10-08 Thread Bradford Wetmore
That look ok. I'm assuming this change won't cause problems on Windows that don't have a /tmp? I'm guessing not, since /home likely doesn't exist either on Windows. JRPT runs ok? Brad On 10/8/2015 4:43 PM, Wang Weijun wrote: Please review the fix at http://cr.openjdk.java.net/~weij

RFR 8085904: Test timeout on Mac

2015-10-08 Thread Wang Weijun
Please review the fix at http://cr.openjdk.java.net/~weijun/8085904/webrev.00/ I just s/home/tmp/g. /home is an autofs mount point and resolving it slows everything down. Hopefully FQDN look up is not the problem here. Thanks Max

Re: RFR [9] 8138978: Examine usages of sun.misc.IOUtils

2015-10-08 Thread Chris Hegarty
> On 8 Oct 2015, at 13:34, Sean Mullan wrote: > > Looks fine to me, though I have one question below. Thanks for looking at this Sean. > On 10/7/15 2:19 PM, Chris Hegarty wrote: >> This primary motivation behind this bug [1] is the clearing out of >> sun.misc, in preparation for JEP 260 [2]. >

Re: TLS ALPN Proposal v7

2015-10-08 Thread Bradford Wetmore
On Sat, Oct 3, 2015 at 2:19 AM, Bradford Wetmore wrote: Thanks for the comments everyone. I'm submitting the following to the CCC (internal review board): http://cr.openjdk.java.net/~wetmore/8051498/webrev.17/ Changes: 1. No H2 Blacklist/Comparator 2. set/getApplicationProtocols()

Re: TLS ALPN Proposal v7

2015-10-08 Thread Simone Bordet
Bradford, On Sat, Oct 3, 2015 at 2:19 AM, Bradford Wetmore wrote: > Thanks for the comments everyone. I'm submitting the following to the CCC > (internal review board): > > http://cr.openjdk.java.net/~wetmore/8051498/webrev.17/ > > Changes: > > 1. No H2 Blacklist/Comparator > > 2. set/getA

Re: RFR [9] 8138978: Examine usages of sun.misc.IOUtils

2015-10-08 Thread Sean Mullan
Looks fine to me, though I have one question below. On 10/7/15 2:19 PM, Chris Hegarty wrote: This primary motivation behind this bug [1] is the clearing out of sun.misc, in preparation for JEP 260 [2]. sun.misc.IOUtils is a JDK internal convenience utility class that provides a single method th

Re: RFR [9] 8138978: Examine usages of sun.misc.IOUtils

2015-10-08 Thread Paul Sandoz
> On 8 Oct 2015, at 10:46, Chris Hegarty wrote: >> It reads at most “seqlen" bytes, so the array may be larger than necessary, >> which might be ok depending on whether one can trust "seqlen”. > > We do no trust ‘seqlen’. :-( > Good! >> The following pattern occurs a few times: >> >> byte[

Re: RFR [9] 8138978: Examine usages of sun.misc.IOUtils

2015-10-08 Thread Chris Hegarty
On 8 Oct 2015, at 09:32, Paul Sandoz wrote: > >> On 7 Oct 2015, at 22:28, Alan Bateman wrote: >> >> >> On 07/10/2015 20:57, Chris Hegarty wrote: >>> : >>> I updated Connection with a readFully that has the same >>> semantics as IOUtils. >>> >>> http://cr.openjdk.java.net/~chegar/8138978/web

Re: RFR [9] 8138978: Examine usages of sun.misc.IOUtils

2015-10-08 Thread Paul Sandoz
> On 7 Oct 2015, at 22:28, Alan Bateman wrote: > > > On 07/10/2015 20:57, Chris Hegarty wrote: >> : >> I updated Connection with a readFully that has the same >> semantics as IOUtils. >> >> http://cr.openjdk.java.net/~chegar/8138978/webrev.01/jdk/ >> > I agree with Roger. Couldn't this be c