RE: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

2015-11-10 Thread Langer, Christoph
Hi Vincent, thanks for your comments and sponsoring this. I just saw that I introduced an unnecessary space – will update my webrev with the final version later today. Best regards Christoph From: Vincent Ryan [mailto:vincent.x.r...@oracle.com] Sent: Mittwoch, 11. November 2015 08:46 To: Mike S

Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

2015-11-10 Thread Vincent Ryan
Explicitly referencing the Sun JCE provider makes the jdk.crypto.mscapi module depend on the java.base module. And that’s OK. I can sponsor this changeset. > On 10 Nov 2015, at 22:39, Mike StJohns wrote: > > On 11/10/2015 4:12 PM, Langer, Christoph wrote: >> Hi folks, >> >> is there any fee

Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

2015-11-10 Thread Mike StJohns
On 11/10/2015 4:12 PM, Langer, Christoph wrote: Hi folks, is there any feedback/review for this change? I missed the 4 Nov message when it came past. No further objections. But still unclear if modularization will permit this. Mike Thanks Christoph *From:*Langer, Christoph *Sent:* M

RE: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

2015-11-10 Thread Langer, Christoph
Hi folks, is there any feedback/review for this change? Thanks Christoph From: Langer, Christoph Sent: Mittwoch, 4. November 2015 12:11 To: 'Michael StJohns' Cc: security-dev@openjdk.java.net Subject: RE: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data Hi Mike,

Re: FYI.... Fwd: Re: [9] RFR:JDK-8076359:Test Task: Develop new tests for Leverage CPU Instructions for GHASH and RSA

2015-11-10 Thread Sean Mullan
Looks good. Thanks, Sean On 11/10/2015 03:36 AM, Tim Du wrote: Hi Sean: Thanks for reviewing the codes. Updated them follow your comments, see http://cr.openjdk.java.net/~fyuan/tim/8076359/webrev.02/ ,please help to review them again. Regards Tim On 11/10/2015 8:18 AM, Sean Mullan wrote: Cou

RFR: [JDK-8072463] Remove requirement that AKID and SKID have to match when building certificate chain

2015-11-10 Thread Sean Mullan
Please review this fix for a regression that removes the requirement that a certificate's Authority Key Identifier must match the issuing certificate's Subject Key Identifier when building a certificate chain. The certificate chain validation algorithm in RFC 5280 does not require that the AKI

Re: FYI.... Fwd: Re: [9] RFR:JDK-8076359:Test Task: Develop new tests for Leverage CPU Instructions for GHASH and RSA

2015-11-10 Thread Tim Du
Hi Sean: Thanks for reviewing the codes. Updated them follow your comments, see http://cr.openjdk.java.net/~fyuan/tim/8076359/webrev.02/ ,please help to review them again. Regards Tim On 11/10/2015 8:18 AM, Sean Mullan wrote: Couple of comments: - SolarisProviderTest is too generic for me.