Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

2015-11-13 Thread Wang Weijun
Hi Christoph I tried updating the entry line in TestProvider and it starts working. this.put("CertificateFactory.X.509", "IterateWindowsRootStore$TestFactory"); PrngSlow.java: Do you still need the "// Not supported here, maybe not a Win32" block? Is there other exception you want to ignore?

Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

2015-11-13 Thread Wang Weijun
It is my understanding that if you write multiple files for a single test, they should be put inside a sub-directory. But in this case you can combine them into a single class by putting the provider-related codes into static inner classes. --Max P. S. Sent from my iPhone so I haven't read al

Re: Design review: JEP 273: DRBG-Based SecureRandom Implementations

2015-11-13 Thread Sean Mullan
On 11/12/2015 07:58 PM, Wang Weijun wrote: What happens if configure is called more than once, or simultaneously by more than one thread? The state is reset. The last one rules. The implementation can be made synchronized. * This method can be called multiple times. After each call, this * {@co

Re: RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

2015-11-13 Thread Mark Sheppard
Hi, to summarize the amendments below: ServiceConfigurationError removed - the code no longer reads the nameservice provider property, it silently ignored try-with-resources statement added in getHostByAddr and lookupAllHostAddr methods of NameService, and duplicate statements removed ho

RE: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

2015-11-13 Thread Langer, Christoph
Hi Max, thanks for your hint. I now implemented a dummy provider that would recreate the issue. Also thanks for the hint regarding the @requires tag. I implemented that and I also reworked all the other testcases for sunmscapi to make use of @requires and threw out unnecessary checks for MSCAP

Re: RFR 8048357: PKCS basic tests

2015-11-13 Thread Amanda Jiang
Hi Max, Please check the updated webrev which address your comments, please let me know if you have any other suggestions. http://cr.openjdk.java.net/~amjiang/8048357/webrev.02/ Thanks, Amanda On 15/8/21 上午12:13, Weijun Wang wrote: PKCS10AttrOrder.java: - Why not inline revAttributes(), pro