Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

2015-11-15 Thread Wang Weijun
> On Nov 16, 2015, at 3:19 PM, Vincent Ryan wrote: > > Yes the source changes look fine. > Last week I ran the tests using webrev.4 and all passed. FYI: webrev.6 also pass. --Max > > Thanks Christoph for the comprehensive fix.

Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

2015-11-15 Thread Vincent Ryan
Yes the source changes look fine. Last week I ran the tests using webrev.4 and all passed. Thanks Christoph for the comprehensive fix. > On 16 Nov 2015, at 00:32, Wang Weijun wrote: > > All tests look fine. > > I suppose Vincent already agreed with the src change. Right? > > For safety, I am

Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

2015-11-15 Thread Wang Weijun
All tests look fine. I suppose Vincent already agreed with the src change. Right? For safety, I am running all related tests on windows-i586 and windows-x64 now. Thanks Max > On 2015年11月16日, at 上午7:27, Langer, Christoph wrote: > > Hi Max, > > thanks for that hint about correctly referencing

RE: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

2015-11-15 Thread Langer, Christoph
Hi Max, thanks for that hint about correctly referencing the inner class. Now I could do it. As for PrngSlow.java: By having a closer look, I discovered that the test was always running into an exception, as the algorithm name "PRNG" is not available for MSCAPI. I renamed it to the correct val