Hi Max,
Sorry for the formatting issue, I have removed all TAB characters and
ran jcheck on the changeset below, could you please sponsor it?
http://cr.openjdk.java.net/~amjiang/8048357/webrev.06/
Thanks,
Amanda
On 15/11/19 下午4:32, Wang Weijun wrote:
Looks fine, but there are TAB characters
Looks fine, but there are TAB characters. Have you run jcheck?
remote: test/sun/security/pkcs/pkcs10/PKCS10AttrEncoding.java:29: Tab character
remote: test/sun/security/pkcs/pkcs10/PKCS10AttributeReader.java:52: Tab
character
remote: test/sun/security/pkcs/pkcs7/PKCS7VerifyTest.java:48: Tab chara
Ding dong.
> On Nov 9, 2015, at 3:35 PM, Wang Weijun wrote:
>
> Hi All
>
> Please review the code change at
>
> http://cr.openjdk.java.net/~weijun/8141690/webrev.00/
>
> JDK-8133151 added support for "#ifdef solaris-sparc" but not "#ifndef
> solaris-spare". This is fixed and I also added "
Done at http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c071ebc7f3bf
Thanks
Max
> On Nov 20, 2015, at 11:00 AM, Amanda Jiang wrote:
>
> Hi Max,
>
> Sorry for the formatting issue, I have removed all TAB characters and ran
> jcheck on the changeset below, could you please sponsor it?
> http://cr.o
> On Nov 20, 2015, at 1:11 AM, Sean Mullan wrote:
>>
>> However, I cannot get it working, and I found difficulties understanding the
>> EngineDescription inner class inside Provider.java.
>>
>> 1. For each engine that can take an extra parameter (not provider) in
>> getInstance(), it is alway
Hi Max,
Please check the webrev below which includes fixes for you previous
comments:
http://cr.openjdk.java.net/~amjiang/8048357/webrev.05/
Thanks,
Amanda
On 15/11/16 下午11:55, Weijun Wang wrote:
Hi Amanda
On 11/17/2015 15:03, Amanda Jiang wrote:
http://cr.openjdk.java.net/~amjiang/8048357
On 11/19/2015 08:41 AM, Wang Weijun wrote:
On Nov 18, 2015, at 9:32 PM, Sean Mullan wrote:
The getInstance methods can now take a SecureRandomParameterSpec object (rather
than an AlgorithmParameterSpec). They should throw
InvalidAlgorithmParameterException (not IllegalArgumentException) if
> On Nov 18, 2015, at 9:32 PM, Sean Mullan wrote:
>
> The getInstance methods can now take a SecureRandomParameterSpec object
> (rather than an AlgorithmParameterSpec). They should throw
> InvalidAlgorithmParameterException (not IllegalArgumentException) if the
> parameters are null or not th
On 11/18/2015 09:54 PM, Wang Weijun wrote:
In AlgorithmId.getDefaultSigAlgForKey, I think you can remove the
last sentence ("Remember ...") - this seems like a ToDo note to
yourself which has been done.
It's a reminder if we update it again in the future.
Ok.
It makes me feel a little uncomf
