Re: RFR [9] 8144480: Remove test dependencies on sun.misc.BASE64Encoder and BASE64Decoder

2015-12-02 Thread Amy Lu
(I'm not a reviewer) Just a minor question. jdk/test/sun/misc/Encode/GetBytes.java also use sun.misc.BASE64Encoder and BASE64Decoder, but is not included in this fix. Missed? or justbecause this test will be totally removed soon in a separate bugid? Thanks, Amy On 12/2/15 11:03 PM, Chris He

Re: RFR 8058778: New APIs for some keytool functions

2015-12-02 Thread larry mccay
Applications that depend on such APIs are currently jumping through hoops to provide the same functionality on multiple JVMs. We have some nasty reflection based code in order to deal with build-time dependencies. It really should be formalized and made part of the SE API. It will be great that I

Re: RFR 8058778: New APIs for some keytool functions

2015-12-02 Thread Wang Weijun
> On Dec 3, 2015, at 4:11 AM, larry mccay wrote: > > Hi Max - > > Happy to see this enhancement - it would be great if it made its way into SE > and other JVM implementations as a result! I replied to Mandy's mail. > > If not, what would the added dependency be for consuming applications?

Re: RFR 8058778: New APIs for some keytool functions

2015-12-02 Thread Wang Weijun
> On Dec 3, 2015, at 2:38 AM, Mandy Chung wrote: > > Hi Max, > > Is there any reason why this X509CertificateBuilder can’t be Java SE API? Well, not much. When we first design the new API, it was meant to be a quick alternative to sun.security.tools.keytool.Main since that class will be in

Re: RFR 8058778: New APIs for some keytool functions

2015-12-02 Thread larry mccay
Hi Max - Happy to see this enhancement - it would be great if it made its way into SE and other JVM implementations as a result! If not, what would the added dependency be for consuming applications? thanks, --larry On Wed, Dec 2, 2015 at 1:38 PM, Mandy Chung wrote: > Hi Max, > > Is there an

Re: RFR 8058778: New APIs for some keytool functions

2015-12-02 Thread Mandy Chung
Hi Max, Is there any reason why this X509CertificateBuilder can’t be Java SE API? Have you considered defining this builder API in java.security.cert.X509Certificate.Builder? Mandy > On Dec 2, 2015, at 6:36 AM, Wang Weijun wrote: > > Hi All > > This enhancement creates a new jdk.security.c

Re: RFR [9] 8144480: Remove test dependencies on sun.misc.BASE64Encoder and BASE64Decoder

2015-12-02 Thread Alan Bateman
On 02/12/2015 15:26, Chris Hegarty wrote: Thanks Max, I'm ok with this version, if you are. I'll include it in the final push. This version looks okay to me too. -Alan.

Re: RFR [9] 8144480: Remove test dependencies on sun.misc.BASE64Encoder and BASE64Decoder

2015-12-02 Thread Wang Weijun
> On Dec 2, 2015, at 11:26 PM, Chris Hegarty wrote: > > Thanks Max, > > I'm ok with this version, if you are. I'll include it in the final push. Please. --Max > > -Chris. > > On 02/12/15 15:13, Wang Weijun wrote: >> >>> On Dec 2, 2015, at 10:52 PM, Wang Weijun wrote: >>> >>> My fault to

Re: RFR [9] 8144480: Remove test dependencies on sun.misc.BASE64Encoder and BASE64Decoder

2015-12-02 Thread Chris Hegarty
Thanks Max, I'm ok with this version, if you are. I'll include it in the final push. -Chris. On 02/12/15 15:13, Wang Weijun wrote: On Dec 2, 2015, at 10:52 PM, Wang Weijun wrote: My fault to use an internal class. I should have simply used the hex encoding. Please wait a while and I'll se

Re: RFR [9] 8144480: Remove test dependencies on sun.misc.BASE64Encoder and BASE64Decoder

2015-12-02 Thread Wang Weijun
> On Dec 2, 2015, at 10:52 PM, Wang Weijun wrote: > > My fault to use an internal class. I should have simply used the hex > encoding. Please wait a while and I'll send you a fix. > > Thanks > Max S11N.java Description: Binary data

Re: RFR [9] 8144480: Remove test dependencies on sun.misc.BASE64Encoder and BASE64Decoder

2015-12-02 Thread Chris Hegarty
Updated to remove all use of reflection. If someone really wants to run S11N on an older JDK, then it is a simple edit to uncomment/comment 3 lines. http://cr.openjdk.java.net/~chegar/Base64-test-updates.01/webrev/ -Chris. On 02/12/15 14:15, Chris Hegarty wrote: On 02/12/15 14:03, Alan Bateman

Re: RFR [9] 8144480: Remove test dependencies on sun.misc.BASE64Encoder and BASE64Decoder

2015-12-02 Thread Wang Weijun
My fault to use an internal class. I should have simply used the hex encoding. Please wait a while and I'll send you a fix. Thanks Max > On Dec 2, 2015, at 10:15 PM, Chris Hegarty wrote: > > On 02/12/15 14:03, Alan Bateman wrote: >> >> On 02/12/2015 12:08, Chris Hegarty wrote: >>> The regress

RFR 8058778: New APIs for some keytool functions

2015-12-02 Thread Wang Weijun
Hi All This enhancement creates a new jdk.security.cert.X509CertificateBuilder API that does what keytool -genkeypair/-certreq/-gencert can do. code changes: http://cr.openjdk.java.net/~weijun/8058778/webrev.04 http://cr.openjdk.java.net/~weijun/8058778/dev/webrev.01/ spec: http://cr.o

Re: RFR [9] 8144480: Remove test dependencies on sun.misc.BASE64Encoder and BASE64Decoder

2015-12-02 Thread Chris Hegarty
On 02/12/15 14:03, Alan Bateman wrote: On 02/12/2015 12:08, Chris Hegarty wrote: The regression tests in the jdk should be updated, where possible, to use java.util.Base64. http://cr.openjdk.java.net/~chegar/Base64-test-updates/webrev/ Should S11N be updated to serialize with JDK 8 so that th

Re: RFR [9] 8144480: Remove test dependencies on sun.misc.BASE64Encoder and BASE64Decoder

2015-12-02 Thread Alan Bateman
On 02/12/2015 12:08, Chris Hegarty wrote: The regression tests in the jdk should be updated, where possible, to use java.util.Base64. http://cr.openjdk.java.net/~chegar/Base64-test-updates/webrev/ Should S11N be updated to serialize with JDK 8 so that the core reflection code isn't needed?

Re: RFR [9] 8144480: Remove test dependencies on sun.misc.BASE64Encoder and BASE64Decoder

2015-12-02 Thread Paul Sandoz
> On 2 Dec 2015, at 13:08, Chris Hegarty wrote: > > The regression tests in the jdk should be updated, where possible, to use > java.util.Base64. > > http://cr.openjdk.java.net/~chegar/Base64-test-updates/webrev/ > +1 Paul. signature.asc Description: Message signed with OpenPGP using GPGM

RFR [9] 8144480: Remove test dependencies on sun.misc.BASE64Encoder and BASE64Decoder

2015-12-02 Thread Chris Hegarty
The regression tests in the jdk should be updated, where possible, to use java.util.Base64. http://cr.openjdk.java.net/~chegar/Base64-test-updates/webrev/ -Chris.