Re: RFR 8138638: Security tests using jdk/test/sun/security/krb5/auto/KDC.java fail intermittently with OutOfMemoryError

2015-12-06 Thread Xuelei Fan
OK. Looks fine now. Xuelei On 12/7/2015 12:35 PM, Wang Weijun wrote: > Its caught 5 lines below and then ignored. > > --Max > >> 在 2015年12月7日,12:02,Xuelei Fan 写道: >> >>> On 12/7/2015 11:51 AM, Wang Weijun wrote: >>> Please review the fix at >>> >>> http://cr.openjdk.java.net/~weijun/8138638/

Re: RFR 8138638: Security tests using jdk/test/sun/security/krb5/auto/KDC.java fail intermittently with OutOfMemoryError

2015-12-06 Thread Wang Weijun
Its caught 5 lines below and then ignored. --Max > 在 2015年12月7日,12:02,Xuelei Fan 写道: > >> On 12/7/2015 11:51 AM, Wang Weijun wrote: >> Please review the fix at >> >> http://cr.openjdk.java.net/~weijun/8138638/webrev.00/ >> >> It looks like the TCP server should be accessed in the failed test

Re: RFR 8138638: Security tests using jdk/test/sun/security/krb5/auto/KDC.java fail intermittently with OutOfMemoryError

2015-12-06 Thread Xuelei Fan
On 12/7/2015 11:51 AM, Wang Weijun wrote: > Please review the fix at > > http://cr.openjdk.java.net/~weijun/8138638/webrev.00/ > > It looks like the TCP server should be accessed in the failed tests. Maybe a > random process happens to connect to the server? This code change will ignore > the

Re: RFR 8058778: New APIs for some keytool functions

2015-12-06 Thread Wang Weijun
> On Dec 6, 2015, at 4:43 AM, Mike StJohns wrote: > > Hi Max - > > This comes under the heading of meta issues. There are at least two forms of > certificate request - PKCS10 (RFC2986) and CRMF (RFC4211). There may be > others (not sure that SCEP is a request per se vs a protocol). I can c

RFR 8138638: Security tests using jdk/test/sun/security/krb5/auto/KDC.java fail intermittently with OutOfMemoryError

2015-12-06 Thread Wang Weijun
Please review the fix at http://cr.openjdk.java.net/~weijun/8138638/webrev.00/ It looks like the TCP server should be accessed in the failed tests. Maybe a random process happens to connect to the server? This code change will ignore the unknown request. Thanks Max

Re: Code Review Request 8141593 Test RetryHttps timed out intermittently

2015-12-06 Thread Wang Weijun
Change looks fine. Best luck. Thanks Max > On Dec 7, 2015, at 10:52 AM, Xuelei Fan wrote: > > Hi Weijun, > > Are you available review this patch for JDK-8141593? > >http://cr.openjdk.java.net/~xuelei/8141593/webrev.00/ > > Test RetryHttps.java timed out intermittently, and the exception

Code Review Request 8141593 Test RetryHttps timed out intermittently

2015-12-06 Thread Xuelei Fan
Hi Weijun, Are you available review this patch for JDK-8141593? http://cr.openjdk.java.net/~xuelei/8141593/webrev.00/ Test RetryHttps.java timed out intermittently, and the exception looks weird to me: javax.net.ssl.SSLException: Unsupported or unrecognized SSL message Looks like there

Code Review Request 8144566, Custom HostnameVerifier disables SNI extension

2015-12-06 Thread Xuelei Fan
Hi, Please review the update for JDK-8144566: http://cr.openjdk.java.net/~xuelei/8144566/webrev.00/ For HttpsURLConnection, the server name may be set after the TLS connection and handshake has been initialized. As may result in that the server name does not present at TLS ClientHello messag